Skip to content

[CP Staging] Revert "Blur Magic Code input when click outside"#28611

Merged
mountiny merged 1 commit intoExpensify:mainfrom
wojtus7:revert-24012-magic-code-blur
Oct 2, 2023
Merged

[CP Staging] Revert "Blur Magic Code input when click outside"#28611
mountiny merged 1 commit intoExpensify:mainfrom
wojtus7:revert-24012-magic-code-blur

Conversation

@wojtus7
Copy link
Contributor

@wojtus7 wojtus7 commented Oct 2, 2023

Reverts #24012

@wojtus7 wojtus7 requested a review from a team as a code owner October 2, 2023 12:42
@melvin-bot melvin-bot bot requested review from lakchote and removed request for a team October 2, 2023 12:43
@melvin-bot
Copy link

melvin-bot bot commented Oct 2, 2023

@lakchote Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

@mountiny mountiny changed the title Revert "Blur Magic Code input when click outside" [CP Staging] Revert "Blur Magic Code input when click outside" Oct 2, 2023
mountiny
mountiny approved these changes Oct 2, 2023
View reviewed changes
Copy link
Contributor

@mountiny mountiny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Straight revert, omitting checklists

@mountiny mountiny merged commit dccc07b into Expensify:main Oct 2, 2023
@melvin-bot melvin-bot bot added the Emergency label Oct 2, 2023
@melvin-bot
Copy link

melvin-bot bot commented Oct 2, 2023

@mountiny looks like this was merged without a test passing. Please add a note explaining why this was done and remove the Emergency label if this is not an emergency.

@mountiny mountiny removed the Emergency label Oct 2, 2023
@mountiny
Copy link
Contributor

mountiny commented Oct 2, 2023

Straight revert

@OSBotify
Copy link
Contributor

OSBotify commented Oct 2, 2023

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify pushed a commit that referenced this pull request Oct 2, 2023
@mountiny @OSBotify
Merge pull request #28611 from wojtus7/revert-24012-magic-code-blur
3ace98e 
[CP Staging] Revert "Blur Magic Code input when click outside"

(cherry picked from commit dccc07b)
@OSBotify OSBotify mentioned this pull request Oct 2, 2023
Closed
@OSBotify
Copy link
Contributor

OSBotify commented Oct 2, 2023

🚀 Cherry-picked to staging by https://github.com/mountiny in version: 1.3.75-10 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes.

@OSBotify
Copy link
Contributor

OSBotify commented Oct 2, 2023

🚀 Deployed to production by https://github.com/mountiny in version: 1.3.75-12 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 failure ❌
🕸 web 🕸 success ✅

@wojtus7 wojtus7 mentioned this pull request Oct 3, 2023
Merged
57 tasks
@OSBotify OSBotify mentioned this pull request Oct 3, 2023
Closed
@OSBotify
Copy link
Contributor

OSBotify commented Oct 3, 2023

🚀 Deployed to staging by https://github.com/mountiny in version: 1.3.77-0 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@OSBotify
Copy link
Contributor

OSBotify commented Oct 5, 2023

🚀 Deployed to production by https://github.com/mountiny in version: 1.3.77-7 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 failure ❌
🕸 web 🕸 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mountiny mountiny mountiny approved these changes

@lakchote lakchote Awaiting requested review from lakchote

Assignees

@wojtus7 wojtus7

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@wojtus7 @mountiny @OSBotify