mWeb: Keep the focus state of the composer when closing three dots menu in report header by ginsuma · Pull Request #28899 · Expensify/App

ginsuma · 2023-10-05T09:36:34Z

Details

We no longer use the video chat button on the report header. We use the three dots menu instead. This PR keeps the focus state of the composer on mWeb when closing the three dots menu on the report header.

Fixed Issues

$ #26763
PROPOSAL: #26763 (comment)

Tests

Open a chat report.
Focus on the main composer.
Tap the three dots icon.
Tap outside the menu to exit.
Verify that:

On Web and desktop, the main composer is unfocused.
On mWeb and native apps, the main composer is focused.

Blur the main composer.
Tap the three dots icon.
Tap outside the menu to exit.
Verify that the main composer is unfocused.

Verify that no errors appear in the JS console

Offline tests

N/A

QA Steps

Same as tests

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Web

Screen.Recording.2023-10-09.at.1.21.13.PM.mov

Mobile Web - Safari

Screen.Recording.2023-10-09.at.1.34.42.PM.mov

Mobile Web - Chrome

Screen.Recording.2023-10-09.at.1.36.39.PM.mov

Desktop

Screen.Recording.2023-10-09.at.1.56.32.PM.mov

iOS

Screen.Recording.2023-10-09.at.1.21.52.PM.mov

Android

Screen.Recording.2023-10-09.at.3.45.19.PM.mov

ginsuma · 2023-10-05T09:41:18Z

src/pages/home/HeaderView.js

                                <ThreeDotsMenu
                                    anchorPosition={styles.threeDotsPopoverOffset(props.windowWidth)}
                                    menuItems={threeDotMenuItems}
+                                    shouldSetModalVisibility={false}


On mWeb, we focus on the main composer by the modal state. This led to the inconsistency between mWeb and native apps.

App/src/pages/home/report/ReportActionCompose/ComposerWithSuggestions.js

Lines 477 to 481 in 25f7ac1

if (!(willBlurTextInputOnTapOutside && !isNextModalWillOpenRef.current && !modal.isVisible && isFocused && (prevIsModalVisible || !prevIsFocused))) {

return;

}

focus();

ginsuma · 2023-10-05T09:50:24Z

src/pages/home/HeaderView.js

+                                    onIconPress={() => {
+                                        const {composerRef, editComposerRef, isFocused, isEditFocused} = ReportActionComposeFocusManager;
+                                        if (isFocused()) {
+                                            composerRef.current.blur();
+                                        } else if (isEditFocused()) {
+                                            editComposerRef.current.blur();
+                                        }
+                                    }}


On native apps, the composer doesn't blur when we click on buttons. We need to blur it by code like we did here

App/src/pages/home/report/ReportActionCompose/ReportActionCompose.js

Lines 203 to 208 in 25f7ac1

const onAddActionPressed = useCallback(() => {

if (!willBlurTextInputOnTapOutside) {

isKeyboardVisibleWhenShowingModalRef.current = composerRef.current.isFocused();

}

composerRef.current.blur();

}, []);

I also blurred the edit composer to make consistency between mWeb and native apps.

@ginsuma This change causes regression on mobile-web and native. When closing the modal, the composer doesn't re-focus in case when it was focused before. The issue is that when the composer was not focused, after opening and closing the modal, the composer shouldn't focus.

@ArekChr I think whether the composer is focused or not if we open the three dots menu, the composer will blur. We only re-focus on some cases, like opening an emoji picker or adding actions.

But we also can restore the keyboard state if this is our expected behavior. On Desktop Web, we don't restore or keep the focus state when clicking on the three dots button.

But we also can restore the keyboard state if this is our expected behavior

Remove onIconPress above.

Add onMouseDown={(e) => Browser.isMobile() && e.preventDefault()} to PressableWithoutFeedback in ThreeDotsMenu to keep the focus state.

@ArekChr I will wait for your confirmation before pushing a new commit and recording new videos.

@pecanoro any thoughts? I think that the composer should be refocused when it was focused before, like on the emoji picker

I was testing it and in any other case, if the composer was focused and we open any modal or menu, it get's refocused on going back, so we should do the same with the 3 dots!

melvin-bot · 2023-10-05T09:50:56Z

@ArekChr Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

ginsuma · 2023-10-09T08:52:01Z

@ArekChr I updated the code to keep the focus state.

ArekChr · 2023-10-09T13:05:22Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android / native
- Android / Chrome
- iOS / native
- iOS / Safari
- MacOS / Chrome / Safari
- MacOS / Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

web.mov

Mobile Web - Chrome

android.chrome.mov

Mobile Web - Safari

ios.safari.mov

Desktop

desktop.mov

iOS

Nagranie.z.ekranu.2023-10-11.o.10.26.41.mov

Android

Nagranie.z.ekranu.2023-10-11.o.10.27.22.mov

ArekChr · 2023-10-09T13:06:02Z

I can't test Android because of some build errors, will update video after fixing it

ArekChr

As expected, it works on the mobile web, and nothing has changed on other platforms.

pecanoro · 2023-10-10T13:23:44Z

I mentioned in a comment that we should refocus the composer as we do for the other modals, but I see we just remove the focus completely.

ginsuma · 2023-10-10T13:46:16Z

I mentioned in a comment that we should refocus the composer as we do for the other modals, but I see we just remove the focus completely.

@pecanoro After closing the three-dots menu, we keep the focus state like before. Could you share with me which platform did you test?

ArekChr · 2023-10-11T08:31:12Z

@pecanoro I re-uploaded android and iOS recordings

pecanoro · 2023-10-11T11:51:48Z

If the composer is focused, open the 3 dots modal and close it, the composer is not focused again.

Monosnap.screencast.2023-10-11.20-50-42.mp4

ginsuma · 2023-10-11T13:28:07Z

If the composer is focused, open the 3 dots modal and close it, the composer is not focused again.

@pecanoro I thought that was expected behavior on Web/Desktop. We have a similar menu, and we just remove the focus when opening/closing this menu on Web/Desktop. I keep the current behavior and update the mWeb behavior in this PR.

But if we need to keep the focus state on these platforms, too. Which should we choose?

The composer will still be focused when opening the three-dot menu. Users can type messages. This will be simple.

When we close the three-dots menu, we will focus on the main composer on all platforms as we did with Emoji Picker modal or Add Actions modal.
The composer will be blurred when opening the menu and back to the previous focus state when closing the menu. We need to save the focus state of the main composer and the edit composer. Then, handling separately between Web/Desktop, mWeb, and native apps.

I'm looking forward to hearing your idea. Thanks!

ArekChr · 2023-10-12T09:22:13Z

@pecanoro The same behavior is on staging on the web and desktop platforms

pecanoro · 2023-10-12T10:46:49Z

@pecanoro The same behavior is on staging on the web and desktop platforms

What do you mean by this?

I see two different behaviors with the other two modals:

Add actions: it seems to keep the state of whatever state was the composer before it was opened.
Emoji picker: it will focus the composer no matter what when closing it
Sny other menu that is not a modal and opens the LHN (profile, search, etc). It seems to refocus the composer when closed.

ArekChr · 2023-10-12T10:51:05Z

@pecanoro I mean that behavior on a web browser doesn't change compared to staging, The issue is to prevent focusing composer while opening and closing the dots modal, in the scenario when the composer was not focused before opening the modal on the mobile web

ginsuma · 2023-10-17T12:14:01Z

@pecanoro, what is the next step here?

pecanoro · 2023-10-17T22:17:59Z

I was doing some testing on mobile and it seems it's also pretty inconsistent, so we can leave it unfocused.

pecanoro · 2023-10-17T22:20:19Z

src/components/ThreeDotsMenu/index.js

                            }
                        }}
+                        onMouseDown={(e) => {
+                            if (!Browser.isMobile()) {


One last request, can you explain here why we need this?

@pecanoro, on Web and mWeb, the composer will blur if we click outside the text input. This is expected on Web, but not mWeb. On there, we want to keep the focus state like we did on native apps when closing the menu.

Sorry, what I meant is, can you add a comment in the code before the if condition explaining that? 😄

@pecanoro I added it.

OSBotify · 2023-10-18T17:28:35Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2023-10-19T00:32:55Z

🚀 Deployed to staging by https://github.com/pecanoro in version: 1.3.87-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	failure ❌
🕸 web 🕸	success ✅

OSBotify · 2023-10-19T00:58:36Z

🚀 Deployed to staging by https://github.com/pecanoro in version: 1.3.87-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	failure ❌
🕸 web 🕸	success ✅

OSBotify · 2023-10-20T21:07:40Z

🚀 Deployed to production by https://github.com/francoisl in version: 1.3.87-12 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	failure ❌
🕸 web 🕸	success ✅

OSBotify · 2023-10-20T21:40:12Z

🚀 Deployed to staging by https://github.com/pecanoro in version: 1.3.88-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2023-10-23T04:52:24Z

🚀 Deployed to production by https://github.com/chiragsalian in version: 1.3.88-11 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	failure ❌
🕸 web 🕸	success ✅

ginsuma added 2 commits October 5, 2023 14:00

Remove focus when closing three dots menu in report header

c126b5f

Remove focus on native apps

71ab28c

ginsuma commented Oct 5, 2023

View reviewed changes

ginsuma marked this pull request as ready for review October 5, 2023 09:50

ginsuma requested a review from a team as a code owner October 5, 2023 09:50

melvin-bot bot requested review from ArekChr and removed request for a team October 5, 2023 09:50

ginsuma mentioned this pull request Oct 5, 2023

Remove focus on the main composer when closing the phone menu #28121

Merged

57 tasks

ginsuma added 2 commits October 9, 2023 12:27

Merge branch 'main' into fix/26763-new-ui

c5b5685

Keep focus state on mWeb

063ac7a

ArekChr approved these changes Oct 9, 2023

View reviewed changes

melvin-bot bot requested a review from pecanoro October 9, 2023 13:08

Merge branch 'main' into fix/26763-new-ui

5882ae2

ginsuma mentioned this pull request Oct 12, 2023

[HOLD for payment 2023-10-27] [WAITING ON #28899][$500] [ANDROID] Chat - Closing phone menu, opens keypad with focus on compose #26763

Closed

6 tasks

ginsuma changed the title ~~Remove focus when closing three dots menu in report header~~ Keep the focus state of the composer when closing three dots menu in report header Oct 12, 2023

ginsuma changed the title ~~Keep the focus state of the composer when closing three dots menu in report header~~ mWeb: Keep the focus state of the composer when closing three dots menu in report header Oct 12, 2023

pecanoro requested changes Oct 17, 2023

View reviewed changes

ginsuma added 2 commits October 19, 2023 00:07

Merge branch 'main' into fix/26763-new-ui

7387238

Add comment

1a7a5dc

pecanoro approved these changes Oct 18, 2023

View reviewed changes

pecanoro merged commit 44c90d3 into Expensify:main Oct 18, 2023

OSBotify mentioned this pull request Oct 18, 2023

Deploy Checklist: New Expensify 2023-10-18 #29926

Closed

64 tasks

OSBotify mentioned this pull request Oct 20, 2023

Deploy Checklist: New Expensify 2023-10-20 #30108

Closed

sobitneupane mentioned this pull request Feb 5, 2024

[HOLD #41128] [$500] mWeb - Chat - The keyboard appears for a moment when leaving the thread #35494

Closed

6 tasks

	if (!(willBlurTextInputOnTapOutside && !isNextModalWillOpenRef.current && !modal.isVisible && isFocused && (prevIsModalVisible \|\| !prevIsFocused))) {
	return;
	}

	focus();

	const onAddActionPressed = useCallback(() => {
	if (!willBlurTextInputOnTapOutside) {
	isKeyboardVisibleWhenShowingModalRef.current = composerRef.current.isFocused();
	}
	composerRef.current.blur();
	}, []);

Conversation

ginsuma commented Oct 5, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

ArekChr Oct 5, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

ginsuma Oct 5, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

melvin-bot bot commented Oct 5, 2023

Uh oh!

ginsuma commented Oct 9, 2023

Uh oh!

ArekChr commented Oct 9, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

ArekChr commented Oct 9, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ArekChr left a comment

Choose a reason for hiding this comment

Uh oh!

pecanoro commented Oct 10, 2023

Uh oh!

ginsuma commented Oct 10, 2023

Uh oh!

ArekChr commented Oct 11, 2023

Uh oh!

pecanoro commented Oct 11, 2023

Uh oh!

ginsuma commented Oct 11, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ArekChr commented Oct 12, 2023

Uh oh!

pecanoro commented Oct 12, 2023

Uh oh!

ArekChr commented Oct 12, 2023

Uh oh!

ginsuma commented Oct 17, 2023

Uh oh!

pecanoro commented Oct 17, 2023

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

OSBotify commented Oct 18, 2023

Uh oh!

OSBotify commented Oct 19, 2023

Uh oh!

OSBotify commented Oct 19, 2023

ginsuma commented Oct 5, 2023 •

edited

Loading

ArekChr Oct 5, 2023 •

edited

Loading

ginsuma Oct 5, 2023 •

edited

Loading

ArekChr commented Oct 9, 2023 •

edited

Loading

ArekChr commented Oct 9, 2023 •

edited

Loading

ginsuma commented Oct 11, 2023 •

edited

Loading