fixed offline jumping behaviour by shubham1206agra · Pull Request #29045 · Expensify/App

shubham1206agra · 2023-10-07T06:18:16Z

Details

Fixes offline jumping behaviour due to quick uncaught error in non-web platforms

Fixed Issues

$ #29030

Tests

Open Expensify App
Login with any account
Create new or go to existing workspace
Go to Workspace > Bank Account
Select any connection option
Follow the flow until 'Company information' and 'Personal Information' pages
Go Offline
Enter address in 'Company address' line on 'Company information' page

Verify that no errors appear in the JS console

Offline tests

Same as Tests

QA Steps

Same as Tests

PR Author Checklist

I linked the correct issue in the ### Fixed Issues section above
I wrote clear testing steps that cover the changes made in this PR
- I added steps for local testing in the Tests section
- I added steps for the expected offline behavior in the Offline steps section
- I added steps for Staging and/or Production testing in the QA steps section
- I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
- I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
I included screenshots or videos for tests on all platforms
I ran the tests on all platforms & verified they passed on:
- Android / native
- Android / Chrome
- iOS / native
- iOS / Safari
- MacOS / Chrome / Safari
- MacOS / Desktop
I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
I followed proper code patterns (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
  - If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I followed the guidelines as stated in the Review Guidelines
I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
I verified that if a function's arguments changed that all usages have also been updated correctly
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- If we are not using the full Onyx data that we loaded, I've added the proper selector in order to ensure the component only re-renders when the data it is using changes
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG))
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR author checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

Screen.Recording.2023-10-18.at.8.40.12.AM.mov

Mobile Web - Chrome

Mobile Web - Safari

Screen.Recording.2023-10-18.at.8.46.33.AM.mov

Desktop

Screen.Recording.2023-10-18.at.8.51.20.AM.mov

iOS

Screen.Recording.2023-10-18.at.9.10.38.AM.mov

Android

melvin-bot · 2023-10-07T06:18:20Z

Hey! I see that you made changes to our Form component. Make sure to update the docs in FORMS.md accordingly. Cheers!

melvin-bot · 2023-10-07T06:18:22Z

@mollfpr Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

shubham1206agra · 2023-10-07T06:19:27Z

This will work for now.
I will dig deeper later as this is an odd problem with library mp.

shubham1206agra · 2023-10-08T06:31:02Z

Please do not merge before
FaridSafi/react-native-google-places-autocomplete#914

mountiny · 2023-10-09T09:51:36Z

@shubham1206agra sorry i am confused should we go ahead with the fix in this pr?

shubham1206agra · 2023-10-09T10:34:22Z

I am trying to get upstream PR merged
So I can just do a version update instead of the workaround present here

mountiny · 2023-10-09T14:48:19Z

@shubham1206agra Alright I have remoevd the deploy blocker label so we dont have to rush so much as with upstream that might take longer

shubham1206agra · 2023-10-09T16:32:05Z

PR is ready for review

mollfpr · 2023-10-15T11:55:01Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

29045.Web.mp4

Mobile Web - Chrome

29045.mWeb-Chrome.mp4

Mobile Web - Safari

29045.mWeb.Safari.mp4

Desktop

29045.Desktop.mp4

iOS

29045.iOS.mp4

Android

29045.Android.mp4

mollfpr

Sorry for the late review. I just got out from the hospital after surgery on my right hand because of the motorcycle accident 🙏

The test looks good on all platforms. @shubham1206agra, Could you please complete the test recordings so I can approve the PR? Thank you!

mollfpr · 2023-10-17T04:55:18Z

Friendly bump @shubham1206agra to complete the recordings.

shubham1206agra · 2023-10-17T05:03:17Z

I will complete this today

mollfpr · 2023-10-18T02:50:53Z

Friendly bump @shubham1206agra for the recordings.

shubham1206agra · 2023-10-18T03:05:22Z

My Android emulator is crashing on start. If you are fine without Android recordings, then I will update it in 15 mins

shubham1206agra · 2023-10-18T03:44:54Z

If you are fine without android, all the remaining recordings has been uploaded.

mollfpr

I think we are okay to use the recordings for mWeb/Chrome and Android from mine. I just check the latest commit on all platforms and it still working well.

All yours @marcochavezf

mollfpr · 2023-10-23T02:40:38Z

Friendly bump @marcochavezf for final review.

mollfpr

Approving again to trigger the internal engineer.

marcochavezf · 2023-10-30T17:40:16Z

LGTM, thanks guys!

OSBotify · 2023-10-30T17:48:22Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2023-10-31T22:00:28Z

🚀 Deployed to staging by https://github.com/marcochavezf in version: 1.3.94-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	failure ❌
🕸 web 🕸	success ✅

OSBotify · 2023-11-01T08:52:28Z

🚀 Deployed to staging by https://github.com/marcochavezf in version: 1.3.94-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	failure ❌
🕸 web 🕸	success ✅

OSBotify · 2023-11-02T10:15:48Z

🚀 Deployed to production by https://github.com/Beamanator in version: 1.3.94-2 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2023-11-02T10:40:38Z

🚀 Deployed to staging by https://github.com/marcochavezf in version: 1.3.95-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2023-11-06T22:10:41Z

🚀 Deployed to production by https://github.com/puneetlath in version: 1.3.95-9 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

fixed offline jumping behaviour

f9717fd

shubham1206agra requested a review from a team as a code owner October 7, 2023 06:18

melvin-bot bot requested review from mollfpr and removed request for a team October 7, 2023 06:18

fix package upstream

1660875

mollfpr reviewed Oct 15, 2023

View reviewed changes

Merge branch 'Expensify:main' into fix-offline-listLoader

a4dc44f

mollfpr approved these changes Oct 18, 2023

View reviewed changes

shubham1206agra mentioned this pull request Oct 22, 2023

[HOLD for payment 2024-07-22] [$500] Distance - Search list displays old searched results in offline mode #30123

Closed

6 tasks

mollfpr approved these changes Oct 30, 2023

View reviewed changes

melvin-bot bot requested a review from marcochavezf October 30, 2023 06:20

marcochavezf approved these changes Oct 30, 2023

View reviewed changes

marcochavezf merged commit 443bb82 into Expensify:main Oct 30, 2023

OSBotify mentioned this pull request Oct 31, 2023

Deploy Checklist: New Expensify 2023-10-31 #30662

Closed

97 tasks

melvin-bot bot mentioned this pull request Nov 2, 2023

[HOLD for payment 2023-11-09] [$500] BA - Part of the screen shakes when entering an address offline #29030

Closed

6 tasks

OSBotify mentioned this pull request Nov 2, 2023

Deploy Checklist: New Expensify 2023-11-02 #30752

Closed

shubham1206agra deleted the fix-offline-listLoader branch February 6, 2024 03:01

Conversation

shubham1206agra commented Oct 7, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot bot commented Oct 7, 2023

Uh oh!

melvin-bot bot commented Oct 7, 2023

Uh oh!

shubham1206agra commented Oct 7, 2023

Uh oh!

shubham1206agra commented Oct 8, 2023

Uh oh!

mountiny commented Oct 9, 2023

Uh oh!

shubham1206agra commented Oct 9, 2023

Uh oh!

mountiny commented Oct 9, 2023

Uh oh!

shubham1206agra commented Oct 9, 2023

Uh oh!

mollfpr commented Oct 15, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

mollfpr left a comment

Choose a reason for hiding this comment

Uh oh!

mollfpr commented Oct 17, 2023

Uh oh!

shubham1206agra commented Oct 17, 2023

Uh oh!

mollfpr commented Oct 18, 2023

Uh oh!

shubham1206agra commented Oct 18, 2023

Uh oh!

shubham1206agra commented Oct 18, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

mollfpr left a comment

Choose a reason for hiding this comment

Uh oh!

mollfpr commented Oct 23, 2023

Uh oh!

mollfpr left a comment

Choose a reason for hiding this comment

Uh oh!

marcochavezf commented Oct 30, 2023

Uh oh!

OSBotify commented Oct 30, 2023

Uh oh!

OSBotify commented Oct 31, 2023

Uh oh!

OSBotify commented Nov 1, 2023

Uh oh!

OSBotify commented Nov 2, 2023

Uh oh!

OSBotify commented Nov 2, 2023

Uh oh!

OSBotify commented Nov 6, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

shubham1206agra commented Oct 7, 2023 •

edited

Loading

mollfpr commented Oct 15, 2023 •

edited

Loading

shubham1206agra commented Oct 18, 2023 •

edited

Loading