Skip to content

Conversation

@tgolen
Copy link
Contributor

@tgolen tgolen commented Aug 25, 2020

Fixes #259

image

Tests

  1. Post a comment that has a link
  2. On web, verify you can right-click on it and open the link in a new tab
  3. On mobile, verify that clicking on the link works

@tgolen tgolen requested a review from thienlnam August 25, 2020 16:58
@tgolen tgolen self-assigned this Aug 25, 2020
@tgolen tgolen changed the title Enable right-clicking on links for desktop Enable right-clicking on links for web Aug 25, 2020
Copy link
Contributor

@thienlnam thienlnam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@thienlnam thienlnam merged commit 2e6629e into master Aug 25, 2020
@thienlnam thienlnam deleted the tgolen-render-links branch August 25, 2020 23:30
@thienlnam
Copy link
Contributor

I'm merging this and then going to spin up another issue on the styling so this doesn't have to hold on that

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Prove right-clicking on link in web can open up "Open in new tab" menu

3 participants