[No QA] [TS Migration] Migrate useReportScrollManager and ReportScreenContext to TypeScript#29315
Merged
roryabraham merged 6 commits intoExpensify:mainfrom Oct 26, 2023
Conversation
| } | ||
|
|
||
| flatListRef.current.scrollToIndex(index); | ||
| flatListRef.current.scrollToIndex({index}); |
Contributor
There was a problem hiding this comment.
why this change?
If its necessary please make sure its not causing any regressions
Contributor
There was a problem hiding this comment.
It's correct now - https://reactnative.dev/docs/flatlist#scrolltoindex
Contributor
There was a problem hiding this comment.
But it wasn't correct before, and it can cause a regression. Please test it 🙌
rezkiy37
approved these changes
Oct 11, 2023
blazejkustra
suggested changes
Oct 13, 2023
| } | ||
|
|
||
| flatListRef.current.scrollToIndex(index); | ||
| flatListRef.current.scrollToIndex({index}); |
Contributor
There was a problem hiding this comment.
But it wasn't correct before, and it can cause a regression. Please test it 🙌
Contributor
Author
|
@blazejkustra I updated the PR, I also checked for regressions and haven't found any, it scroll as expected, here is a proof: proof-compressed.mp4 |
blazejkustra
suggested changes
Oct 17, 2023
melvin-bot
bot
requested review from
roryabraham
and removed request for
a team
|
@roryabraham Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
roryabraham
approved these changes
Oct 19, 2023
Contributor
roryabraham
left a comment
roryabraham
left a comment
There was a problem hiding this comment.
LGTM, awaiting C+ reviewer checklist
Contributor
|
Put out a CTA for a C+ reviewer: https://expensify.slack.com/archives/C02NK2DQWUX/p1698089338027039 |
Contributor
Reviewer Checklist
Screenshots/VideosWeb
Mobile Web - ChromeScreen.Recording.2023-10-26.at.11.19.12.AM.movMobile Web - SafariScreen.Recording.2023-10-26.at.11.17.50.AM.movDesktopScreen.Recording.2023-10-26.at.11.20.42.AM.moviOSScreen.Recording.2023-10-26.at.11.18.22.AM.movAndroidScreen.Recording.2023-10-26.at.11.20.04.AM.mov |
|
🎯 @allroundexperts, thanks for reviewing and testing this PR! 🎉 An E/App issue has been created to issue payment here: #30413. |
Contributor
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
Contributor
Performance Comparison Report 📊Significant Changes To Duration
Show details
Meaningless Changes To DurationShow entries
Show details
|
github-actions
bot
added
the
DeployBlockerCash
Contributor
|
@Expensify/mobile-deployers 📣 Please look into this performance regression as it's a deploy blocker. |
Contributor
|
🚀 Deployed to staging by https://github.com/roryabraham in version: 1.3.93-0 🚀
|
97 tasks
Contributor
|
🚀 Deployed to production by https://github.com/Beamanator in version: 1.3.93-1 🚀
|
Contributor
|
🚀 Deployed to staging by https://github.com/roryabraham in version: 1.3.94-0 🚀
|
1 similar comment
Contributor
|
🚀 Deployed to staging by https://github.com/roryabraham in version: 1.3.94-0 🚀
|
Contributor
|
🚀 Deployed to production by https://github.com/Beamanator in version: 1.3.94-2 🚀
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Details
Fixed Issues
$ #24949
PROPOSAL: N/A
Tests
N/A
Offline tests
N/A
QA Steps
N/A
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectiontoggleReportand notonIconClick)myBool && <MyComponent />.src/languages/*files and using the translation methodWaiting for Copylabel for a copy review on the original GH to get the correct copy.STYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)/** comment above it */thisproperly so there are no scoping issues (i.e. foronClick={this.submit}the methodthis.submitshould be bound tothisin the constructor)thisare necessary to be bound (i.e. avoidthis.submit = this.submit.bind(this);ifthis.submitis never passed to a component event handler likeonClick)StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG))Avataris modified, I verified thatAvataris working as expected in all cases)ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari
MacOS: Desktop