[No QA]Comment out bot messages since e2e are too flaky#29579
Merged
Conversation
|
@ Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
Deploying with
|
| Latest commit: |
f705db3
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://91ceb9bb.helpdot.pages.dev |
| Branch Preview URL: | https://andrew-e2e-silence.helpdot.pages.dev |
Contributor
Reviewer Checklist
Screenshots/VideosN/A WebMobile Web - ChromeMobile Web - SafariDesktopiOSAndroid |
Contributor
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
Contributor
|
🚀 Deployed to staging by https://github.com/mountiny in version: 1.3.85-0 🚀
|
Contributor
|
🚀 Deployed to production by https://github.com/francoisl in version: 1.3.85-4 🚀
|
Contributor
|
🚀 Deployed to staging by https://github.com/mountiny in version: 1.3.86-0 🚀
|
Contributor
|
🚀 Deployed to production by https://github.com/francoisl in version: 1.3.86-5 🚀
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Details
This PR will comment out the bot that is commenting on PRs due to flaky e2e performance tests. We will uncomment this code once we have the tests working again.
Fixed Issues
$ N/A
Tests
main.Offline tests
N/A
QA Steps
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectiontoggleReportand notonIconClick)myBool && <MyComponent />.src/languages/*files and using the translation methodWaiting for Copylabel for a copy review on the original GH to get the correct copy.STYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)/** comment above it */thisproperly so there are no scoping issues (i.e. foronClick={this.submit}the methodthis.submitshould be bound tothisin the constructor)thisare necessary to be bound (i.e. avoidthis.submit = this.submit.bind(this);ifthis.submitis never passed to a component event handler likeonClick)StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG))Avataris modified, I verified thatAvataris working as expected in all cases)ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
N/A - tests only
Android: mWeb Chrome
N/A - tests only
iOS: Native
N/A - tests only
iOS: mWeb Safari
N/A - tests only
MacOS: Chrome / Safari
N/A - tests only
MacOS: Desktop
N/A - tests only