Skip to content

fix: console error on the description push-to-page in the Send money flow #29673

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
youssef-lr merged 1 commit into from
Oct 18, 2023
Merged

fix: console error on the description push-to-page in the Send money flow #29673

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion src/pages/iou/MoneyRequestDescriptionPage.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,11 +45,12 @@ const propTypes = {
}).isRequired,

/** The current tab we have navigated to in the request modal. String that corresponds to the request type. */
selectedTab: PropTypes.oneOf([CONST.TAB.DISTANCE, CONST.TAB.MANUAL, CONST.TAB.SCAN]).isRequired,
selectedTab: PropTypes.oneOf(['', CONST.TAB.DISTANCE, CONST.TAB.MANUAL, CONST.TAB.SCAN]),
};

const defaultProps = {
iou: iouDefaultProps,
selectedTab: '',
Copy link
Copy Markdown
Contributor

@abdulrahuman5196 abdulrahuman5196 Oct 16, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@akinwale Do we even need an Empty string? We can just set the default value as null?

Copy link
Copy Markdown
Contributor Author

@akinwale akinwale Oct 16, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@abdulrahuman5196 I assumed since we're using PropTypes.oneOf for the type, it had to be a literal value. I guess we can just change the type to PropTypes.string?

Copy link
Copy Markdown
Contributor

@abdulrahuman5196 abdulrahuman5196 Oct 16, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I assumed since we're using PropTypes.oneOf for the type, it had to be a literal value

I don't have a strong preference here, I did check our code base and we seem to have set null alone as default value with removing isRequired and also the way this PR is provided.
I think it would make a difference after TS migration but not ATM in this file I suppose.

So I will review with the current change itself.

};

function MoneyRequestDescriptionPage({iou, route, selectedTab}) {
Expand Down