[CP Staging] Revert "Remove `withNavigationFallback.js` HOC" by tienifr · Pull Request #29844 · Expensify/App

tienifr · 2023-10-18T03:58:20Z

Details

Restore the withNavigationFallback to avoid app crashing. Straight revert of PR #29449.

Fixed Issues

$ #29839
PROPOSAL: #29839 (comment)

Tests

Login in ND
Go to any chat
Send any message
Hold message >> Delete message
Verify that message is deleted and user can continue use app

Verify that no errors appear in the JS console

Offline tests

NA

QA Steps

Login in ND
Go to any chat
Send any message
Hold message >> Delete message
Verify that message is deleted and user can continue use app

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

hoc-android-compressed.mov

Android: mWeb Chrome

hoc-chrome-compressed.mov

iOS: Native

hoc-ios-compressed.mov

iOS: mWeb Safari

hoc-safari-compressed.mov

MacOS: Chrome / Safari

hoc-web-compressed.mov

MacOS: Desktop

hoc-desktop-compressed.mov

melvin-bot · 2023-10-18T04:33:53Z

@thesahindia Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

Julesssss

Hmm, this is not quite a straight revert due to these and these changes. Are they necessary?

tienifr · 2023-10-18T08:06:19Z

Because we're restoring withNavigationFallback and getComponentDisplayName and a pascal-cased variable (WrappedComponent) were used there. The original author may forget to discard those changes after removing the HOC.

Julesssss · 2023-10-18T08:13:08Z

Alright, thanks let me find someone for the C+ review 👍

rushatgabhane

Revert looks clean to me

rushatgabhane

@tienifr i can't delete the message on web

tap and hold
delete

Uncaught TypeError: Cannot read properties of undefined (reading '3708590258034326363')
    at eval (ReportActionsUtils.js:387:85)
    at Array.forEach (<anonymous>)
    at Module.getLastVisibleAction (ReportActionsUtils.js:386:1)
    at Module.getLastVisibleMessage (ReportUtils.js:1211:27)
    at Module.deleteReportComment (Report.js:990:33)
    at Object.eval [as onConfirm] (PopoverReportActionContextMenu.js:249:7)
    at Object.onConfirm [as onPress] (ConfirmModal.js:85:1)

Screen.Recording.2023-10-18.at.13.58.05.mov

tienifr · 2023-10-18T08:43:44Z

Hmm I think it's another issue because I can still delete it 🤔 . Can you try other messages?

rushatgabhane · 2023-10-18T09:11:18Z

still no luck, could you retest after merging main?

rushatgabhane · 2023-10-18T17:47:11Z

Tested again, still can't delete any messages

…49-ts-migration/withNavigationFallback-hoc

youssef-lr · 2023-10-18T18:54:08Z

@rushatgabhane since it's late for you @situchan will be completing the checklist

situchan · 2023-10-18T19:02:19Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android / native
- Android / Chrome
- iOS / native
- iOS / Safari
- MacOS / Chrome / Safari
- MacOS / Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

web.mov

Mobile Web - Chrome

mchrome.mov

Mobile Web - Safari

msafari.mov

Desktop

desktop.mov

iOS

ios.mov

Android

android.mov

tienifr · 2023-10-18T19:10:32Z

I tried what @rushatgabhane told above but can't really reproduce the issue but faced another one instead. Note that he was deleting comment using popover context menu (not the mini one).

It did not throw any error or crashed the app but the comment was not deleted until I switched to another report and came back. I think this is out of scope.

delete-web-compressed.mov

youssef-lr · 2023-10-18T19:11:49Z

@tienifr what do you think about this bug @situchan encountered here? also cc @kacper-mikolajczak I see you encountered this bug before here

situchan · 2023-10-18T19:13:53Z

It did not throw any error or crashed the app but the comment was not deleted until I switched to another report and came back

This seems like another deploy blocker with different root cause

tienifr · 2023-10-18T19:16:12Z

@tienifr what do you think about this bug @situchan encountered here?

@youssef-lr Yes, I was able to reproduce the resizing issue. Having looked at the errors, I thought it's not related to this PR.

youssef-lr · 2023-10-18T19:17:06Z

Yes, I was able to reproduce the resizing issue. Having looked at the errors, I thought it's not related to this PR.

Yeah my guess as well, I think we have another PR causing this issue. So I'm gonna go ahead and merge this one, thanks everyone!

OSBotify · 2023-10-18T19:23:24Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

tienifr · 2023-10-18T19:25:15Z

It did not throw any error or crashed the app but the comment was not deleted until I switched to another report and came back

This seems like another deploy blocker with different root cause

@youssef-lr Can you please create a GH issue for this? Seems critical. I'd like to investigate.

WIP: I'm writing a draft following bug report template.

…NavigationFallback-hoc Revert "Remove `withNavigationFallback.js` HOC" (cherry picked from commit fbab24b)

youssef-lr · 2023-10-18T19:34:38Z

sounds good @tienifr, also, this PR just got deployed yesterday, @kacper-mikolajczak ran into this issue while working on it, could it be what's causing that bug on staging?

youssef-lr · 2023-10-18T19:37:11Z

Yeah I know. I think we also need to figure out the resizing issue.

tienifr · 2023-10-18T19:44:03Z

Hmm so strange. I can't reproduce it (i.e. the delete by popover menu issue) anymore on the latest main after we merged this. Thanks for your patience @youssef-lr !

situchan · 2023-10-18T19:51:33Z

Hmm so strange. I can't reproduce it (i.e. the delete by popover menu issue) anymore on the latest main after we merged this. Thanks for your patience @youssef-lr !

I suspect #29784 (merged 15 min ago) might have fixed this as it's the only one related to popover merged within 1 hr.
I was able to reproduce 1 hr ago on this branch merged with latest main locally.

OSBotify · 2023-10-18T20:01:51Z

🚀 Cherry-picked to staging by https://github.com/francoisl in version: 1.3.86-4 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes.

rushatgabhane · 2023-10-18T22:08:05Z

@situchan @youssef-lr why did we merge this PR? we still can't delete messages on staging with the same error as here #29844 (review)

Screen.Recording.2023-10-19.at.03.35.37.mov

OSBotify · 2023-10-18T23:53:18Z

🚀 Deployed to production by https://github.com/francoisl in version: 1.3.86-5 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	failure ❌
🕸 web 🕸	success ✅

situchan · 2023-10-19T05:03:20Z

@rushatgabhane I can delete message successfully on staging (both from context menu and from mini context menu)

Screen.Recording.2023-10-19.at.11.00.57.AM.mov

Screen.Recording.2023-10-19.at.11.01.31.AM.mov

youssef-lr · 2023-10-19T11:07:52Z

@situchan @tienifr the resizing error has made it to production, can we confirm if this PR is the culprit? just a guess as Kacper encountered this error while working on the PR

youssef-lr · 2023-10-19T11:13:53Z

OK I can confirm that reverting that PR fixes the issue for me locally

kacper-mikolajczak · 2023-10-19T11:22:02Z

Looking into it now 🔧

youssef-lr · 2023-10-19T11:23:01Z

Thanks @kacper-mikolajczak!

OSBotify · 2023-10-20T21:39:51Z

🚀 Deployed to staging by https://github.com/youssef-lr in version: 1.3.88-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2023-10-23T04:52:03Z

🚀 Deployed to production by https://github.com/chiragsalian in version: 1.3.88-11 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	failure ❌
🕸 web 🕸	success ✅

tienifr and others added 3 commits October 18, 2023 03:52

Revert "Remove 'withNavigationFallback.js' HOC"

b24474d

fix lint

6a2173b

fix ts error

a8f3d66

tienifr changed the title ~~Revert "Remove 'withNavigationFallback.js' HOC"~~ Revert "Remove withNavigationFallback.js HOC" Oct 18, 2023

tienifr marked this pull request as ready for review October 18, 2023 04:33

tienifr requested a review from a team as a code owner October 18, 2023 04:33

melvin-bot bot removed the request for review from a team October 18, 2023 04:33

melvin-bot bot requested a review from thesahindia October 18, 2023 04:33

This was referenced Oct 18, 2023

[HOLD for payment 2023-10-27] [HOLD for payment 2023-10-25] [$250] Chat - Deleting message in chat causes black screen #29839

Closed

Fix: Login page loads infinitely when logging in from Another login page is open page #29797

Merged

Julesssss approved these changes Oct 18, 2023

View reviewed changes

Julesssss reviewed Oct 18, 2023

View reviewed changes

Julesssss assigned tienifr Oct 18, 2023

Julesssss requested review from rushatgabhane and removed request for thesahindia October 18, 2023 08:15

rushatgabhane reviewed Oct 18, 2023

View reviewed changes

rushatgabhane suggested changes Oct 18, 2023

View reviewed changes

ikevin127 mentioned this pull request Oct 18, 2023

fix/28334: Missing displayName prop leads to console error (testID undefined) #28813

Merged

59 tasks

Merge branch 'main' of https://github.com/tienifr/App into revert-294…

a7e50e9

…49-ts-migration/withNavigationFallback-hoc

Expensify deleted a comment from rushatgabhane Oct 18, 2023

youssef-lr requested a review from situchan October 18, 2023 18:57

situchan approved these changes Oct 18, 2023

View reviewed changes

youssef-lr merged commit fbab24b into Expensify:main Oct 18, 2023

youssef-lr changed the title ~~Revert "Remove withNavigationFallback.js HOC"~~ [CP Staging] Revert "Remove withNavigationFallback.js HOC" Oct 18, 2023

OSBotify pushed a commit that referenced this pull request Oct 18, 2023

Merge pull request #29844 from tienifr/revert-29449-ts-migration/with…

420ae96

…NavigationFallback-hoc Revert "Remove `withNavigationFallback.js` HOC" (cherry picked from commit fbab24b)

OSBotify mentioned this pull request Oct 18, 2023

Deploy Checklist: New Expensify 2023-10-17 #29837

Closed

lanitochka17 mentioned this pull request Oct 18, 2023

Chat - Can't delete a message using the right click menu with Delete CTA unresponsive #29918

Closed

6 tasks

VickyStash mentioned this pull request Oct 19, 2023

[TS migration] Migrate 'withNavigationFallback.js' HOC to TypeScript #24953

Closed

OSBotify mentioned this pull request Oct 20, 2023

Deploy Checklist: New Expensify 2023-10-20 #30108

Closed

kacper-mikolajczak mentioned this pull request Oct 23, 2023

Migrate index.js to function component #16161

Closed

1 task

youssef-lr mentioned this pull request Oct 30, 2023

[HOLD for payment 2023-11-07] [$500] Web - App crash on device toolbar toggle #30278

Closed

6 tasks

Conversation

tienifr commented Oct 18, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot bot commented Oct 18, 2023

Uh oh!

Julesssss left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

tienifr commented Oct 18, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Julesssss commented Oct 18, 2023

Uh oh!

rushatgabhane left a comment

Choose a reason for hiding this comment

Uh oh!

rushatgabhane left a comment

Choose a reason for hiding this comment

Uh oh!

tienifr commented Oct 18, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

rushatgabhane commented Oct 18, 2023

Uh oh!

rushatgabhane commented Oct 18, 2023

Uh oh!

youssef-lr commented Oct 18, 2023

Uh oh!

situchan commented Oct 18, 2023

Reviewer Checklist

Screenshots/Videos

Uh oh!

tienifr commented Oct 18, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

youssef-lr commented Oct 18, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

situchan commented Oct 18, 2023

Uh oh!

tienifr commented Oct 18, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

youssef-lr commented Oct 18, 2023

Uh oh!

OSBotify commented Oct 18, 2023

Uh oh!

tienifr commented Oct 18, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

youssef-lr commented Oct 18, 2023

Uh oh!

youssef-lr commented Oct 18, 2023

Uh oh!

tienifr commented Oct 18, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

situchan commented Oct 18, 2023

Uh oh!

OSBotify commented Oct 18, 2023

Uh oh!

rushatgabhane commented Oct 18, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

OSBotify commented Oct 18, 2023

Uh oh!

situchan commented Oct 19, 2023

Uh oh!

youssef-lr commented Oct 19, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

tienifr commented Oct 18, 2023 •

edited

Loading

Julesssss left a comment •

edited

Loading

tienifr commented Oct 18, 2023 •

edited

Loading

tienifr commented Oct 18, 2023 •

edited

Loading

tienifr commented Oct 18, 2023 •

edited

Loading

youssef-lr commented Oct 18, 2023 •

edited

Loading

tienifr commented Oct 18, 2023 •

edited

Loading

tienifr commented Oct 18, 2023 •

edited

Loading

tienifr commented Oct 18, 2023 •

edited

Loading

rushatgabhane commented Oct 18, 2023 •

edited

Loading

youssef-lr commented Oct 19, 2023 •

edited

Loading