Add the currency sign to IOU request flow

[iwiznia]

Details

Fixed Issues

Fixes https://github.com/Expensify/Expensify/issues/164533

Tests

Request Money

• Click the + icon and select Request Money
• Enter $50 on the IOUAmount page and click next
• Observe that the header of the IOUParticipants page reads Request $50
  
• Select a participant to move on to the IOUConfirm page
• Observe that the header & confirmation button both read Request $50
  

Split Bill

• Click the + icon and select Split Bill
• Enter $50 on the IOUAmount page and click next
• Observe that the header of the IOUParticipants page reads Split $50
  
• Select a couple of participants and click next
• Observe that the header of the IOUConfirm page also reads Split $50
  

Tested On

• Web
• Mobile Web
• Desktop
• iOS
• Android

[Julesssss]

@iwiznia FYI conflicts

[Julesssss]

We've got a condition, translation, and number format all in one chunk. Maybe separating out amount would simplify this statement a bit.

[iwiznia]

I don't see why adding more variable is simpler, the amount of code is the same.

[Beamanator]

Looking at it like this, I'm not sure it offers too much of an improvement 🤷

const phrase = this.props.hasMultipleParticipants ? 'common.split' : 'iou.request';
const variables = {
    amount: this.props.numberFormat(
        this.props.iouAmount,
        {style: 'currency', currency: this.props.selectedCurrency},
    ),
};
const buttonText = this.props.translate(phrase, variables);

[Julesssss]

I think it shouldn't be common anymore, as it must have an amount. It should be listed beneath iou.request IMO

[iwiznia]

The fact that it has an amount does not make a difference. We are using this in 3 places, so it is pretty common to me.

[Beamanator]

I see iou.request used in the same places as common.split - both in IOUConfirmationList.js and IOUModal.js.

My opinion is that adding an ${amount} in the text makes it very iou-related so I'd agree with Jules.

[Julesssss]

Same here. Separating this into two steps would be a lot simpler.

[Julesssss]

Requested a few changes

[iwiznia]

Updated

[iwiznia]

Updated

[Beamanator]

Tested and works well on Desktop & iOS 👍