[No QA] [TS Migration] migrate KeyboardAvoidingView.js to TypeScript#29955
Merged
lakchote merged 4 commits intoExpensify:mainfrom Oct 31, 2023
Merged
Conversation
| import {KeyboardAvoidingView as KeyboardAvoidingViewComponent, KeyboardAvoidingViewProps} from 'react-native'; | ||
|
|
||
| function KeyboardAvoidingView(props) { | ||
| function KeyboardAvoidingView(props: KeyboardAvoidingViewProps): React.ReactNode { |
Contributor
There was a problem hiding this comment.
I think we decided to not add return types to components
|
|
||
| function KeyboardAvoidingView(props) { | ||
| const viewProps = _.omit(props, ['behavior', 'contentContainerStyle', 'enabled', 'keyboardVerticalOffset']); | ||
| function KeyboardAvoidingView(props: KeyboardAvoidingViewProps): React.ReactNode { |
barttom
approved these changes
Oct 19, 2023
| function KeyboardAvoidingView(props) { | ||
| const viewProps = _.omit(props, ['behavior', 'contentContainerStyle', 'enabled', 'keyboardVerticalOffset']); | ||
| function KeyboardAvoidingView(props: KeyboardAvoidingViewProps): React.ReactNode { | ||
| const {behavior, contentContainerStyle, enabled, keyboardVerticalOffset, ...rest} = props; |
Contributor
There was a problem hiding this comment.
do YOu use these variables? behavior, contentContainerStyle, enabled, keyboardVerticalOffset
blazejkustra
suggested changes
Oct 24, 2023
Contributor
blazejkustra
left a comment
blazejkustra
left a comment
There was a problem hiding this comment.
@JKobrynski types.ts file with common types is missing
Contributor
Author
What would you like to see in such a file? |
Contributor
|
@JKobrynski Something like this: //types.ts
import {KeyboardAvoidingViewProps} from 'react-native';
export default KeyboardAvoidingViewProps;
// index.tsx / index.ios.tsx
import KeyboardAvoidingViewProps from './types'I know it's silly but we need to define a common type to make sure all implementations have the same props. It will make it more saf ein the future if someone decide to change the types. |
Contributor
Author
|
@blazejkustra done! |
blazejkustra
approved these changes
Oct 26, 2023
Contributor
Reviewer Checklist
Screenshots/VideosAndroid: NativeAndroid: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari
MacOS: Desktop
|
lakchote
approved these changes
Oct 31, 2023
Contributor
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
97 tasks
Contributor
|
🚀 Deployed to staging by https://github.com/lakchote in version: 1.3.94-0 🚀
|
1 similar comment
Contributor
|
🚀 Deployed to staging by https://github.com/lakchote in version: 1.3.94-0 🚀
|
Contributor
|
🚀 Deployed to production by https://github.com/Beamanator in version: 1.3.94-2 🚀
|
Contributor
|
🚀 Deployed to staging by https://github.com/lakchote in version: 1.3.95-0 🚀
|
Contributor
|
🚀 Deployed to production by https://github.com/puneetlath in version: 1.3.95-9 🚀
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Details
Fixed Issues
$ #25002
PROPOSAL: N/A
Tests
Offline tests
N/A
QA Steps
N/A
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectiontoggleReportand notonIconClick)myBool && <MyComponent />.src/languages/*files and using the translation methodWaiting for Copylabel for a copy review on the original GH to get the correct copy.STYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)/** comment above it */thisproperly so there are no scoping issues (i.e. foronClick={this.submit}the methodthis.submitshould be bound tothisin the constructor)thisare necessary to be bound (i.e. avoidthis.submit = this.submit.bind(this);ifthis.submitis never passed to a component event handler likeonClick)StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG))Avataris modified, I verified thatAvataris working as expected in all cases)ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari
MacOS: Desktop