fix: Chat - App displays mention suggestion for sometime when we remove spaces before by paultsimura · Pull Request #29957 · Expensify/App

paultsimura · 2023-10-19T10:46:47Z

Details

This is a workaround to stop the suggestions list from showing on the removal of symbols before the "@".
The original idea caused a regression, so we have to go with a workaround until the migration to the Fabric Architecture.

Fixed Issues

$ #28170
PROPOSAL: #28170 (comment)

Tests

Same as QA.

Offline tests

Same as QA.

QA Steps

Open any report
Type "@"

Verify that the mention suggestions are opened (especially on iOS Native)

Add space before the "@"
Remove the space

Verify that the mention suggestions are not opened
Verify that no errors appear in the JS console

PR Author Checklist

I linked the correct issue in the ### Fixed Issues section above
I wrote clear testing steps that cover the changes made in this PR
- I added steps for local testing in the Tests section
- I added steps for the expected offline behavior in the Offline steps section
- I added steps for Staging and/or Production testing in the QA steps section
- I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
- I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
I included screenshots or videos for tests on all platforms
I ran the tests on all platforms & verified they passed on:
- Android / native
- Android / Chrome
- iOS / native
- iOS / Safari
- MacOS / Chrome / Safari
- MacOS / Desktop
I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
I followed proper code patterns (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
  - If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I followed the guidelines as stated in the Review Guidelines
I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
I verified that if a function's arguments changed that all usages have also been updated correctly
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- If we are not using the full Onyx data that we loaded, I've added the proper selector in order to ensure the component only re-renders when the data it is using changes
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG))
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR author checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

web.mp4

Mobile Web - Chrome

mWeb.mp4

Mobile Web - Safari

video_2023-10-02_09-29-41.mp4

Desktop

desktop.mov

iOS

Simulator.Screen.Recording.-.iPhone.15.-.2023-10-19.at.13.16.32.mov

Android

android.mov

melvin-bot · 2023-10-19T10:46:53Z

@cubuspl42 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

jakub-trzebiatowski · 2023-10-19T11:53:41Z

Lint issues

paultsimura · 2023-10-19T11:58:27Z

Lint issues

My bad, fixed.

paultsimura · 2023-10-21T05:23:06Z

Hey @cubuspl42, did you have any luck getting this tested/reviewed?

jakub-trzebiatowski · 2023-10-23T08:52:37Z

src/pages/home/report/ReportActionCompose/SuggestionMention.js

    useEffect(() => {
+        if (value.length < previousValue.length) {
+            // A workaround to not show the suggestions list when the user deletes a character before the mention.
+            // It is caused by a buggy behavior of the TextInput on iOS. Should be fixed after migration to the Fabric Arc.


Arc -> Arch (or just "Fabric")

jakub-trzebiatowski · 2023-10-23T08:58:09Z

src/pages/home/report/ReportActionCompose/SuggestionMention.js

+
        calculateMentionSuggestion(selection.end);
-    }, [selection, calculateMentionSuggestion]);
+    }, [selection, value, previousValue, calculateMentionSuggestion]);


Both value and previousValue are necessary, right?

I would omit both values from dependencies, but in that case, we get a lint error – it requires both to be present

Oh, sure. The truth is that we opt-out quite often from that lint... In this case I would go whichever path is less likely to create another regression...

I agree with you @cubuspl42, we should follow the path that is less likely to create another regression.

jakub-trzebiatowski · 2023-10-23T09:02:17Z

We are over 1000 commits behind main; please merge it.

Even if there are no Git conflicts on the textual level, such diversion can:

create lint issues on main
result in bugs

jakub-trzebiatowski · 2023-10-23T09:13:55Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android / native
- Android / Chrome
- iOS / native
- iOS / Safari
- MacOS / Chrome / Safari
- MacOS / Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

fix-suggestions-remove-space-again-web.mp4

Mobile Web - Chrome

fix-suggestions-remove-space-again-android-web-compressed.mp4

Mobile Web - Safari

fix-suggestions-remove-space-again-ios-web.mp4

Desktop

iOS

fix-suggestions-remove-space-again-ios.mp4

Android

fix-suggestions-remove-space-again-android-compressed.mp4

jakub-trzebiatowski · 2023-10-23T12:13:21Z

@lakchote This is our second try, as previously, we reverted the changes because of a regression caused by a tricky iOS React Native bug.

OSBotify · 2023-10-23T14:28:32Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2023-10-24T02:00:29Z

🚀 Deployed to staging by https://github.com/lakchote in version: 1.3.90-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2023-10-25T16:37:23Z

🚀 Deployed to production by https://github.com/marcaaron in version: 1.3.90-2 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	failure ❌
🕸 web 🕸	success ✅

OSBotify · 2023-10-25T17:02:17Z

🚀 Deployed to staging by https://github.com/lakchote in version: 1.3.91-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2023-10-26T22:44:18Z

🚀 Deployed to production by https://github.com/marcaaron in version: 1.3.91-8 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

paultsimura added 3 commits October 17, 2023 19:30

Try build an iOS workaround

0ca7dcb

Try build an iOS workaround

ff4bfdb

Remove logs

a6c8519

paultsimura requested a review from a team as a code owner October 19, 2023 10:46

melvin-bot bot requested review from jakub-trzebiatowski and removed request for a team October 19, 2023 10:46

Fix dependencies list

f401385

Lint fix

1cb6ba6

jakub-trzebiatowski reviewed Oct 23, 2023

View reviewed changes

paultsimura added 2 commits October 23, 2023 11:31

Merge branch 'main' into fix/28170-mention-on-delete

95a9dfe

Fix Fabric-related comment

54d1baf

paultsimura requested a review from jakub-trzebiatowski October 23, 2023 10:11

jakub-trzebiatowski approved these changes Oct 23, 2023

View reviewed changes

melvin-bot bot requested a review from lakchote October 23, 2023 12:12

lakchote approved these changes Oct 23, 2023

View reviewed changes

lakchote merged commit 35a7ac4 into Expensify:main Oct 23, 2023

OSBotify mentioned this pull request Oct 24, 2023

Deploy Checklist: New Expensify 2023-10-24 #30224

Closed

43 tasks

melvin-bot bot mentioned this pull request Oct 25, 2023

[HOLD for payment 2023-11-01] [HOLD for payment 2023-10-13] [$500] Chat - App displays mention suggestion for sometime when we remove space from before @ #28170

Closed

6 tasks

OSBotify mentioned this pull request Oct 25, 2023

Deploy Checklist: New Expensify 2023-10-25 #30365

Closed

99 tasks

Kicu mentioned this pull request Mar 21, 2024

Enable Live Markdown Preview on web #38152

Merged

50 tasks

Conversation

paultsimura commented Oct 19, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot bot commented Oct 19, 2023

Uh oh!

jakub-trzebiatowski commented Oct 19, 2023

Uh oh!

paultsimura commented Oct 19, 2023

Uh oh!

paultsimura commented Oct 21, 2023

Uh oh!

jakub-trzebiatowski Oct 23, 2023

Choose a reason for hiding this comment

Uh oh!

jakub-trzebiatowski Oct 23, 2023

Choose a reason for hiding this comment

Uh oh!

jakub-trzebiatowski Oct 23, 2023

Choose a reason for hiding this comment

Uh oh!

jakub-trzebiatowski Oct 23, 2023

Choose a reason for hiding this comment

Uh oh!

paultsimura Oct 23, 2023

Choose a reason for hiding this comment

Uh oh!

jakub-trzebiatowski Oct 23, 2023

Choose a reason for hiding this comment

Uh oh!

lakchote Oct 23, 2023

Choose a reason for hiding this comment

Uh oh!

jakub-trzebiatowski commented Oct 23, 2023

Uh oh!

jakub-trzebiatowski commented Oct 23, 2023

Reviewer Checklist

Screenshots/Videos

Uh oh!

jakub-trzebiatowski commented Oct 23, 2023

Uh oh!

OSBotify commented Oct 23, 2023

Uh oh!

OSBotify commented Oct 24, 2023

Uh oh!

OSBotify commented Oct 25, 2023

Uh oh!

OSBotify commented Oct 25, 2023

Uh oh!

OSBotify commented Oct 26, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

paultsimura commented Oct 19, 2023 •

edited

Loading