Fix bug with When deleting a money request offline, the IOU skeleton changes the currency to $0.00

[ZhenjaHorbach]

Details

When deleting a money request offline, the IOU skeleton changes the currency to $0.00

Fixed Issues

$ #29048
PROPOSAL: #29048 (comment)

Tests

1. Open app
2. Log in with any account
3. Click on the FAB button
4. Click on 'Request Money'
5. Choose 'Manual' and add an amount
6. Click on the 'Next' button
7. Select any user
8. Save money request
9. Repeat steps 3-8
10. Switch to offline mode
11. Delete the first created IOU
12. Notice that IOU skeleton not changes the currency to $0.00

• Verify that no errors appear in the JS console

Offline tests

1. Open app
2. Log in with any account
3. Click on the FAB button
4. Click on 'Request Money'
5. Choose 'Manual' and add an amount
6. Click on the 'Next' button
7. Select any user
8. Save money request
9. Repeat steps 3-8
10. Switch to offline mode
11. Delete the first created IOU
12. Notice that IOU skeleton not changes the currency to $0.00

QA Steps

1. Open app
2. Log in with any account
3. Click on the FAB button
4. Click on 'Request Money'
5. Choose 'Manual' and add an amount
6. Click on the 'Next' button
7. Select any user
8. Save money request
9. Repeat steps 3-8
10. Switch to offline mode
11. Delete the first created IOU
12. Notice that IOU skeleton not changes the currency to $0.00

• Verify that no errors appear in the JS console

PR Author Checklist

• I linked the correct issue in the ### Fixed Issues section above
• I wrote clear testing steps that cover the changes made in this PR
  • I added steps for local testing in the Tests section
  • I added steps for the expected offline behavior in the Offline steps section
  • I added steps for Staging and/or Production testing in the QA steps section
  • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
  • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
  • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
• I included screenshots or videos for tests on all platforms
• I ran the tests on all platforms & verified they passed on:
  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop
• I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
• I followed proper code patterns (see Reviewing the code)
  • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
  • I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
  • I verified that comments were added to code that is not self explanatory
  • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
  • I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
    • If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
  • I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
  • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
  • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
  • I verified the JSDocs style guidelines (in STYLE.md) were followed
• If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
• I followed the guidelines as stated in the Review Guidelines
• I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
• I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
• I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
• I verified that if a function's arguments changed that all usages have also been updated correctly
• If a new component is created I verified that:
  • A similar component doesn't exist in the codebase
  • All props are defined accurately and each prop has a /** comment above it */
  • The file is named correctly
  • The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
  • The only data being stored in the state is data necessary for rendering and nothing else
  • If we are not using the full Onyx data that we loaded, I've added the proper selector in order to ensure the component only re-renders when the data it is using changes
  • For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
  • Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
  • All JSX used for rendering exists in the render method
  • The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
• If any new file was added I verified that:
  • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
• If a new CSS style is added I verified that:
  • A similar style doesn't already exist
  • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG))
• If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
• If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
• If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
• If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
• If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
• If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
• I have checked off every checkbox in the PR author checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

android.mov

Android: mWeb Chrome

android-web.mov

iOS: Native

ios.mov

iOS: mWeb Safari

ios-web.mov

MacOS: Chrome / Safari

web.mov

MacOS: Desktop

desktop.mov

[melvin-bot]

@rushatgabhane Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

[ZhenjaHorbach]

@rushatgabhane
Hello )
PR is ready

[ZhenjaHorbach]

@rushatgabhane
Hello )
PR is ready

[ZhenjaHorbach]

@rushatgabhane
Hello )
Sorry for the reminder )
But bump )

[rushatgabhane]

Reviewer Checklist

• I have verified the author checklist is complete (all boxes are checked off).
• I verified the correct issue is linked in the ### Fixed Issues section above
• I verified testing steps are clear and they cover the changes made in this PR
  • I verified the steps for local testing are in the Tests section
  • I verified the steps for Staging and/or Production testing are in the QA steps section
  • I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
  • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
• I checked that screenshots or videos are included for tests on all platforms
• I included screenshots or videos for tests on all platforms
• I verified tests pass on all platforms & I tested again on:
  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop
• If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
• I verified proper code patterns were followed (see Reviewing the code)
  • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
  • I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
  • I verified that comments were added to code that is not self explanatory
  • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
  • I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
  • I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
  • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
  • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
  • I verified the JSDocs style guidelines (in STYLE.md) were followed
• If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
• I verified that this PR follows the guidelines as stated in the Review Guidelines
• I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
• I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
• I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
• If a new component is created I verified that:
  • A similar component doesn't exist in the codebase
  • All props are defined accurately and each prop has a /** comment above it */
  • The file is named correctly
  • The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
  • The only data being stored in the state is data necessary for rendering and nothing else
  • For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
  • Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
  • All JSX used for rendering exists in the render method
  • The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
• If any new file was added I verified that:
  • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
• If a new CSS style is added I verified that:
  • A similar style doesn't already exist
  • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
• If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
• If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
• If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
• If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
• If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
• If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
• I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

Screen.Recording.2023-10-25.at.09.21.19.mov

Mobile Web - Chrome

Mobile Web - Safari

Desktop

iOS

Android

[OSBotify]

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

[github-actions]

Performance Comparison Report 📊

Significant Changes To Duration

Name	Duration
App start TTI	1115.263 ms → 1182.262 ms (+67.000 ms, +6.0%) 🔴

Show details

Name

Duration

App start TTI

Baseline Mean: 1115.263 ms Stdev: 33.958 ms (3.0%) Runs: 1027.386264000088 1043.314578999998 1060.1315860000905 1064.7711139998864 1073.2824719999917 1076.9626629999839 1077.6452450000215 1079.252657999983 1080.2056509999093 1081.2553439999465 1083.9354799999855 1086.4712340000551 1087.2193670000415 1089.814449999947 1093.0852920000907 1093.9562820000574 1095.6655329999048 1099.1618959999178 1101.2313439999707 1102.0570160001516 1102.7248649999965 1102.8104749999475 1103.6693369999994 1103.7623159999494 1104.0775999999605 1106.4638340000529 1106.7361560000572 1108.0190240000375 1108.068181999959 1110.3615800000262 1112.3627599999309 1116.3759049999062 1118.9544659999665 1120.6478609999176 1123.069661000045 1124.5077090000268 1126.0805150000378 1127.157734000124 1127.7809469997883 1127.887422000058 1129.5706299999729 1132.4834949998185 1134.056317999959 1134.9764360000845 1138.9550650001038 1139.0940119998995 1145.3936340000946 1150.6375329999719 1150.784982000012 1151.3382510000374 1155.1461760001257 1156.5863169999793 1161.1021310000215 1163.932022999972 1164.1810540000442 1165.209370000055 1168.9927109999117 1174.1590170001145 1205.5744019998237 Current Mean: 1182.262 ms Stdev: 42.741 ms (3.6%) Runs: 1086.6129839997739 1102.250597000122 1114.1246220003814 1115.8084640000015 1121.1297230003402 1121.3315909998491 1123.2075509997085 1125.173259000294 1128.2574070002884 1131.6815929999575 1135.7748109996319 1146.775004999712 1147.1846540002152 1151.4675540002063 1151.6803489997983 1154.9831630000845 1160.8831860003993 1161.667201999575 1167.3798420000821 1169.438784999773 1169.8047979995608 1170.0999079998583 1172.5409650001675 1173.9439740004018 1173.9760189997032 1176.18094499968 1176.5195420002565 1176.620091999881 1177.5164000000805 1178.4947220003232 1178.8667799998075 1181.3828189997002 1182.5533840004355 1182.7519939998165 1184.6165340002626 1186.1174039999023 1188.5683960001916 1197.5443259999156 1197.8833919996396 1198.5312259998173 1203.838433000259 1204.1841989997774 1205.2492859996855 1207.5250110002235 1207.9921359997243 1208.3332470003515 1211.0798059999943 1214.589494000189 1217.7445010002702 1225.8607759997249 1228.9410220002756 1229.5625090003014 1229.694679000415 1243.059399000369 1243.6550749996677 1250.6422560000792 1256.2689589997754 1262.3580120000988 1268.427617000416 1275.4127939995378

Meaningless Changes To Duration

Show entries

Name	Duration
Open Search Page TTI	701.992 ms → 720.702 ms (+18.710 ms, +2.7%)
App start runJsBundle	793.600 ms → 808.288 ms (+14.688 ms, +1.9%)
App start regularAppStart	0.014 ms → 0.014 ms (+0.000 ms, ±0.0%)
App start nativeLaunch	22.898 ms → 22.310 ms (-0.588 ms, -2.6%)

Show details

Name	Duration
Open Search Page TTI	Baseline Mean: 701.992 ms Stdev: 37.519 ms (5.3%) Runs: 635.5682779997587 639.7563889999874 643.3089189999737 649.0679520000704 656.2727049998939 657.2030039997771 658.0397950001061 658.2954919999465 663.4230960002169 664.8341470002197 665.4064539996907 666.2708339998499 668.2097570002079 669.1995040001348 671.6126709999517 672.4785569999367 672.6746829999611 674.8014730000868 676.0170900002122 679.2098799999803 681.647299000062 681.9540609996766 682.8598629999906 690.7379970001057 691.581625000108 692.7165530002676 694.0652269995771 695.0306400000118 695.1967779998668 695.9258220000193 696.4938159999438 698.7879229998216 699.6976729999296 704.8842780003324 705.1312259999104 705.8298340002075 706.6145020001568 707.1992999999784 707.4081230000593 709.4510909998789 709.850463999901 711.3878179998137 712.8411870002747 723.0740970000625 730.5170089998282 730.7613929999061 735.5525719998404 735.6221519997343 735.9548349999823 736.1665860000066 739.5945640001446 741.4876710004173 744.5196529999375 751.3020839998499 754.5544440001249 755.8152270000428 756.2828379999846 770.906534999609 779.6149900001474 785.9086509998888 794.9290779996663 Current Mean: 720.702 ms Stdev: 44.510 ms (6.2%) Runs: 635.3645430002362 646.003866000101 647.8000090001151 658.6131589999422 675.3630379997194 675.596516999416 677.2473959997296 677.7452800003812 678.3580329995602 678.9232179997489 680.5469159996137 682.2761230003089 682.5732829999179 683.7923590000719 684.1942549999803 686.6629640003666 686.8259689994156 688.6021740008146 688.6402190001681 689.8557949997485 692.6536459997296 692.7690840000287 693.0800790004432 694.7826340002939 695.5933030005544 697.6318370001391 699.8294679997489 701.6657309997827 709.7297369996086 711.5891519999132 712.4111329996958 712.6416420005262 716.2986250007525 716.3092450005934 716.850097999908 721.1795659996569 726.4581709997728 727.084920999594 733.0620929999277 738.1251640003175 740.5858150003478 748.3461099993438 752.01977599971 752.8465580008924 755.5611569993198 756.097737999633 759.0898439995944 760.3291430007666 761.9846200002357 762.956991000101 767.7872729999945 773.099324000068 776.7075199997053 780.8079019999132 781.897299000062 790.0615649996325 790.8745529996231 800.8131919996813 801.8911950001493 813.7396250003949 820.6153570003808
App start runJsBundle	Baseline Mean: 793.600 ms Stdev: 28.007 ms (3.5%) Runs: 733 738 748 752 756 763 764 765 765 769 771 772 772 773 773 775 776 777 778 778 779 780 781 781 782 783 783 784 789 789 789 791 792 795 795 797 797 798 801 804 807 807 810 811 813 816 817 817 818 825 826 827 830 835 838 840 841 842 845 863 Current Mean: 808.288 ms Stdev: 32.582 ms (4.0%) Runs: 735 736 750 757 758 761 762 768 770 773 778 781 785 786 787 789 790 791 793 796 797 797 799 802 804 806 806 807 807 808 809 810 814 814 816 819 820 821 821 821 826 826 826 827 828 830 831 842 843 846 849 851 852 854 855 858 862 869 870
App start regularAppStart	Baseline Mean: 0.014 ms Stdev: 0.001 ms (5.5%) Runs: 0.012370000127702951 0.012409999966621399 0.012735999887809157 0.012898999964818358 0.013020000187680125 0.01310200011357665 0.013142999960109591 0.013142999960109591 0.013223999878391623 0.013264999957755208 0.013428000034764409 0.013509999960660934 0.013630999717861414 0.013630999717861414 0.013630999950692058 0.013672000030055642 0.013712000101804733 0.013752999948337674 0.013793000020086765 0.013833999866619706 0.01387499994598329 0.013875999953597784 0.013916000025346875 0.013916000025346875 0.013956999871879816 0.01395700010471046 0.013996999943628907 0.0139979999512434 0.013998000416904688 0.014038000022992492 0.014038000022992492 0.014078000094741583 0.01411899970844388 0.014282000018283725 0.014283000025898218 0.014322999864816666 0.014405000023543835 0.014444999862462282 0.014445000095292926 0.01448600017465651 0.014526000013574958 0.014526000013574958 0.014567000092938542 0.014567000092938542 0.014607999939471483 0.014688999857753515 0.014934000093489885 0.01509599993005395 0.015176999848335981 0.01521899993531406 0.015299000078812242 0.015340000158175826 0.015584999928250909 0.016194999683648348 Current Mean: 0.014 ms Stdev: 0.001 ms (5.9%) Runs: 0.012409999966621399 0.01285799965262413 0.012859000824391842 0.012980000115931034 0.013143000192940235 0.013143000192940235 0.01318300049751997 0.013224000111222267 0.013264999724924564 0.013305999338626862 0.013345999643206596 0.013345999643206596 0.013387000188231468 0.013590000569820404 0.013590999878942966 0.013631999492645264 0.013632000423967838 0.013671999797224998 0.013671999797224998 0.013712000101804733 0.013712000101804733 0.013794000260531902 0.013833999633789062 0.01387499924749136 0.013876000419259071 0.013956000097095966 0.013957000337541103 0.01407800056040287 0.014078999869525433 0.014078999869525433 0.014119000174105167 0.01411999948322773 0.014159999787807465 0.014159999787807465 0.014240999706089497 0.014241999946534634 0.014241999946534634 0.014282000251114368 0.0143630001693964 0.014363999478518963 0.014404000714421272 0.014405000023543835 0.014526000246405602 0.014566999860107899 0.014649000018835068 0.014688999392092228 0.014973999932408333 0.015015000477433205 0.015054999850690365 0.015137000009417534 0.015217999927699566 0.015584000386297703 0.015868999995291233 0.015951000154018402 0.016073000617325306 0.016276000067591667
App start nativeLaunch	Baseline Mean: 22.898 ms Stdev: 2.137 ms (9.3%) Runs: 19 20 20 20 20 20 21 21 21 21 21 21 21 21 21 21 22 22 22 22 22 22 22 22 22 22 22 22 22 22 22 22 23 23 23 23 23 23 23 24 24 24 24 24 24 24 25 25 25 26 26 26 26 26 27 27 27 27 28 Current Mean: 22.310 ms Stdev: 3.583 ms (16.1%) Runs: 18 18 18 18 19 19 19 19 19 19 19 19 19 19 19 20 20 20 20 20 20 20 20 20 20 20 20 20 21 21 21 22 22 22 23 23 23 23 23 23 24 24 25 25 25 25 26 26 27 27 28 28 28 29 29 29 30 31

[github-actions]

@Expensify/mobile-deployers 📣 Please look into this performance regression as it's a deploy blocker.

[OSBotify]

🚀 Deployed to staging by https://github.com/stitesExpensify in version: 1.3.92-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

[OSBotify]

🚀 Deployed to production by https://github.com/Beamanator in version: 1.3.92-4 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

[OSBotify]

🚀 Deployed to staging by https://github.com/stitesExpensify in version: 1.3.93-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

[OSBotify]

🚀 Deployed to production by https://github.com/Beamanator in version: 1.3.93-1 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅