Update dependencies on desktop package file to fix vulnerabilities by pecanoro · Pull Request #30186 · Expensify/App

pecanoro · 2023-10-23T16:27:49Z

Details

Bumping to one of the latest versions to fix security vulnerabilities. I know quite the jump, I read the changelogs and I think we should be fine since most breaking changes are for Windows.

CHANGELOGS!! Checked the PRs for comments about breaking changes:

fix: inappropriate electron-updater cache directory on macOS electron-userland/electron-builder#7032
fix: Allow disabling of webinstaller files to avoid confusion with actual installers electron-userland/electron-builder#6575
fix: Update certificate validation on Windows to check full DN electron-userland/electron-builder#6576
BIGGEST CHANGES (Windows related): chore: v23.0.0 alpha electron-userland/electron-builder#6556

Fixed Issues

$ https://github.com/Expensify/Expensify/issues/298613
PROPOSAL:

Tests

Run the following commands, and make sure that the apps launch and nothing blows up:

npm run ios
npm run android
npm run web
npm run desktop

Let's also make sure that the desktop build succeeds.
1. Delete the Chat app
2. Comment this code in config/electronBuilder.config.js
```
// Comment out notarizing
// afterSign: 'desktop/notarize.js',

// Also comment out publishing step
// publish: [{
//     provider: 's3',
//     bucket: 'chat-test-expensify-com',
//     channel: 'latest'
// }],
```
1. Run npm run desktop-build
2. Open the project in finder, double-click on dist/Chat.dmg, and install the app. Run it and make sure it works.
3. The logs for the desktop production app live in ~/Library/Logs/react-native-chat/main.log. Inspect them by any means you prefer and search for the log line "Checking for update". This indicates that the auto-updater is running. Because this is a local production build, you'll likely see a 404 error against a query to Github's servers immediately after. That's expected for a local production build.

Verify that no errors appear in the JS console

Offline tests

QA Steps

Open the desktop app
Click on Check for Updates in the system menu
If a new version is available, click to download it and make sure it gets installed
If no new versions are available, the Update Not Available should show up.
It should not crash or return any unexpected errors.

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

melvin-bot · 2023-10-23T19:07:33Z

@aimane-chnaif Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

pecanoro · 2023-10-23T19:09:10Z

@aimane-chnaif I need you to check that I won't be breaking the electron updater that checks for uploads on desktop. I think most of the major changes were aimed at Windows so it does not apply, but we need to test it. I did so and it seems it's working fine, but we need to double-check.

aimane-chnaif · 2023-10-23T19:18:06Z

I see HOLD tests in title. Does this depend on something (like backend)?

pecanoro · 2023-10-23T22:41:28Z

Ahh no sorry, I added it because I was testing it earlier, I will remove it.

pecanoro · 2023-10-26T15:18:57Z

@aimane-chnaif Friendly bump!

aimane-chnaif · 2023-10-26T15:19:41Z

Thanks for the bump. On it now

aimane-chnaif · 2023-10-26T16:05:36Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android / native
- Android / Chrome
- iOS / native
- iOS / Safari
- MacOS / Chrome / Safari
- MacOS / Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

Mobile Web - Chrome

Mobile Web - Safari

Desktop

desktop2.mov

iOS

Android

aimane-chnaif

LGTM 🎉

I am seeing below error in console but I think it's expected for local build

[2023-10-26 17:01:59.167] [info] Checking for update
[2023-10-26 17:01:59.723] [info] Generated new staging user ID: 4686d03d-e917-5107-9e1e-8e27b62f3c5d
[2023-10-26 17:02:02.875] [error] Error: Error: Cannot find latest-mac.yml in the latest release artifacts (https://github.com/Expensify/App/releases/download/1.3.91-6/latest-mac.yml): HttpError: 404

melvin-bot · 2023-10-26T16:09:24Z

@tylerkaraszewski Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

melvin-bot · 2023-10-26T16:09:28Z

🎯 @aimane-chnaif, thanks for reviewing and testing this PR! 🎉

An E/App issue has been created to issue payment here: #30453.

OSBotify · 2023-10-26T23:39:21Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2023-10-30T08:02:35Z

🚀 Deployed to staging by https://github.com/tylerkaraszewski in version: 1.3.93-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2023-10-31T21:35:44Z

🚀 Deployed to production by https://github.com/Beamanator in version: 1.3.93-1 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2023-10-31T22:02:37Z

🚀 Deployed to staging by https://github.com/tylerkaraszewski in version: 1.3.94-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	failure ❌
🕸 web 🕸	success ✅

OSBotify · 2023-11-01T08:54:36Z

🚀 Deployed to staging by https://github.com/tylerkaraszewski in version: 1.3.94-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	failure ❌
🕸 web 🕸	success ✅

OSBotify · 2023-11-02T10:17:57Z

🚀 Deployed to production by https://github.com/Beamanator in version: 1.3.94-2 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

pecanoro added 2 commits October 23, 2023 11:47

Update semver on desktop

e4364b3

Update to 6.0 (good luck)

8de04a6

pecanoro self-assigned this Oct 23, 2023

pecanoro marked this pull request as ready for review October 23, 2023 19:07

pecanoro requested a review from a team as a code owner October 23, 2023 19:07

melvin-bot bot removed the request for review from a team October 23, 2023 19:07

melvin-bot bot requested a review from aimane-chnaif October 23, 2023 19:07

pecanoro changed the title ~~[HOLD tests] Update dependencies on desktop package file to fix vulnerabilities~~ Update dependencies on desktop package file to fix vulnerabilities Oct 23, 2023

aimane-chnaif approved these changes Oct 26, 2023

View reviewed changes

melvin-bot bot requested a review from tylerkaraszewski October 26, 2023 16:09

melvin-bot bot mentioned this pull request Oct 26, 2023

[Hold for payment 11-09-2023] Payment issue for E/App PR#30186 #30453

Closed

tylerkaraszewski approved these changes Oct 26, 2023

View reviewed changes

tylerkaraszewski merged commit 83e2b97 into main Oct 26, 2023

tylerkaraszewski deleted the rocio-DesktopSemver branch October 26, 2023 23:33

OSBotify mentioned this pull request Oct 30, 2023

Deploy Checklist: New Expensify 2023-10-30 #30560

Closed

OSBotify mentioned this pull request Oct 31, 2023

Deploy Checklist: New Expensify 2023-10-31 #30662

Closed

97 tasks

Conversation

pecanoro commented Oct 23, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot bot commented Oct 23, 2023

Uh oh!

pecanoro commented Oct 23, 2023

Uh oh!

aimane-chnaif commented Oct 23, 2023

Uh oh!

pecanoro commented Oct 23, 2023

Uh oh!

pecanoro commented Oct 26, 2023

Uh oh!

aimane-chnaif commented Oct 26, 2023

Uh oh!

aimane-chnaif commented Oct 26, 2023

Reviewer Checklist

Screenshots/Videos

Uh oh!

aimane-chnaif left a comment

Choose a reason for hiding this comment

Uh oh!

melvin-bot bot commented Oct 26, 2023

Uh oh!

melvin-bot bot commented Oct 26, 2023

Uh oh!

OSBotify commented Oct 26, 2023

Uh oh!

OSBotify commented Oct 30, 2023

Uh oh!

OSBotify commented Oct 31, 2023

Uh oh!

OSBotify commented Oct 31, 2023

Uh oh!

OSBotify commented Nov 1, 2023

Uh oh!

OSBotify commented Nov 2, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

pecanoro commented Oct 23, 2023 •

edited

Loading