Skip to content

reduce label size and remove placeholder in new chat room #30213

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
danieldoglas merged 1 commit into from
Oct 26, 2023
Merged

reduce label size and remove placeholder in new chat room #30213

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion src/components/ValuePicker/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,8 @@ import MenuItemWithTopDescription from '../MenuItemWithTopDescription';
import ValueSelectorModal from './ValueSelectorModal';
import FormHelpMessage from '../FormHelpMessage';
import refPropTypes from '../refPropTypes';
import * as StyleUtils from '../../styles/StyleUtils';
import variables from '../../styles/variables';

const propTypes = {
/** Form Error description */
Expand Down Expand Up @@ -59,7 +61,7 @@ function ValuePicker({value, label, items, placeholder, errorText, onInputChange
hidePickerModal();
};

const descStyle = value.length === 0 ? styles.textNormal : null;
const descStyle = value.length === 0 ? StyleUtils.getFontSizeStyle(variables.fontSizeLabel) : null;
Copy link
Copy Markdown
Contributor

@hungvu193 hungvu193 Mar 10, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The MenuItem handled this case, we don't need it anymore. More info here:
#57310 (comment)

const selectedItem = _.find(items, {value});
const selectedLabel = selectedItem ? selectedItem.label : '';

Expand Down
1 change: 0 additions & 1 deletion src/pages/workspace/WorkspaceNewRoomPage.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -216,7 +216,6 @@ function WorkspaceNewRoomPage(props) {
<ValuePicker
inputID="policyID"
label={translate('workspace.common.workspace')}
placeholder={translate('newRoomPage.selectAWorkspace')}
items={workspaceOptions}
onValueChange={setPolicyID}
/>
Expand Down
Loading