fix error message positioning on amount page by aman-atg · Pull Request #30287 · Expensify/App

aman-atg · 2023-10-24T17:36:03Z

Details

#29204 (comment)
Using absolute position for the error message to avoid displacing the input

Fixed Issues

$ #29204
PROPOSAL: #29204 (comment)

Tests

Login to ND
Click on FAB > Request Money > Manual
Click on Next
Verify that the error message is shown and input isn't displaced

Verify that no errors appear in the JS console

Offline tests

na

QA Steps

Login to ND
Click on FAB > Request Money > Manual
Click on Next
Verify that the error message is shown and input isn't displaced

Verify that no errors appear in the JS console

PR Author Checklist

I linked the correct issue in the ### Fixed Issues section above
I wrote clear testing steps that cover the changes made in this PR
- I added steps for local testing in the Tests section
- I added steps for the expected offline behavior in the Offline steps section
- I added steps for Staging and/or Production testing in the QA steps section
- I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
- I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
I included screenshots or videos for tests on all platforms
I ran the tests on all platforms & verified they passed on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
I followed proper code patterns (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
  - If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I followed the guidelines as stated in the Review Guidelines
I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
I verified that if a function's arguments changed that all usages have also been updated correctly
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- If we are not using the full Onyx data that we loaded, I've added the proper selector in order to ensure the component only re-renders when the data it is using changes
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG))
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR author checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

android.mov

Android: mWeb Chrome

chrome.mov

iOS: Native

pr-ios.mov

iOS: mWeb Safari

pr-safari.mov

MacOS: Chrome / Safari

web.mov

MacOS: Desktop

desktop.mov

…essage-positioning-on-amount-page

aman-atg · 2023-10-24T17:50:04Z

We should also make sure that error message is not overlapped with amount input on very small device (even smaller than iPhone SE)

Does this look good to you?
I'm using '12px of gap' below the error message, the same value that we use for non-touch devices (Web, Desktop) when BigNumberPad is not present.

demo.mov

aman-atg · 2023-10-24T17:56:14Z

oops! forgot to tag.
cc: @situchan

situchan · 2023-10-24T18:00:55Z

I'm using '12px of gap' below the error message, the same value that we use for non-touch devices (Web, Desktop) when BigNumberPad is not present.

What is original value?

aman-atg · 2023-10-24T18:04:09Z

@situchan 16px => styles.mb1 (FormHelpMessage's own style) +styles.mt3(from NumberPad)

situchan · 2023-10-24T18:07:21Z

Please share screenshot (before fix and after fix). We can always get approval from design team

aman-atg · 2023-10-24T18:09:43Z

Margin 8px	Margin 12px	Margin 16px

I think for consistency we can go with 12px

aman-atg · 2023-10-24T18:10:51Z

Sharing 'before and after' shortly

aman-atg · 2023-10-24T18:19:50Z

Before fix	After fix

cc: @situchan

situchan · 2023-10-24T18:21:13Z

cc: @Expensify/design for the best padding selection

aman-atg · 2023-10-24T18:31:45Z

Compiling the key comments for design team's review here:

cc: @Expensify/design @shawnborton

shawnborton · 2023-10-25T14:07:10Z

I'm cool with 12px but can you show a side-by-side of what it looks like both with and without the error message present?

dannymcclain · 2023-10-25T14:25:16Z

12px feels good to me too. (+1 I would also like to see side-by-side of with and without on a pretty common viewport size)

aman-atg · 2023-10-25T18:20:54Z

The first row is iPhone SE and the second row is iPhone 14.
cc : @shawnborton @dannymcclain

Error state	Normal state

dannymcclain · 2023-10-25T18:22:14Z

That's feelin pretty good to me.

shawnborton · 2023-10-25T19:17:02Z

Yup, same!

melvin-bot · 2023-10-26T05:42:02Z

@situchan Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

situchan · 2023-10-26T17:24:28Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android / native
- Android / Chrome
- iOS / native
- iOS / Safari
- MacOS / Chrome / Safari
- MacOS / Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

web.mov

Mobile Web - Chrome

mchrome.mov

Mobile Web - Safari

msafari.mov

Desktop

desktop.mov

iOS

ios.mov

Android

android.mov

situchan

aman-atg · 2023-10-27T10:43:29Z

bump @amyevans

aman-atg · 2023-10-27T13:44:08Z

friendly bump @amyevans

OSBotify · 2023-10-30T08:02:23Z

🚀 Deployed to staging by https://github.com/amyevans in version: 1.3.93-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2023-10-31T21:35:32Z

🚀 Deployed to production by https://github.com/Beamanator in version: 1.3.93-1 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2023-10-31T22:02:22Z

🚀 Deployed to staging by https://github.com/amyevans in version: 1.3.94-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	failure ❌
🕸 web 🕸	success ✅

OSBotify · 2023-11-01T08:54:21Z

🚀 Deployed to staging by https://github.com/amyevans in version: 1.3.94-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	failure ❌
🕸 web 🕸	success ✅

OSBotify · 2023-11-02T10:17:42Z

🚀 Deployed to production by https://github.com/Beamanator in version: 1.3.94-2 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

jjcoffee · 2024-01-02T09:59:43Z

src/pages/iou/steps/MoneyRequestAmountForm.js

                />
+                {!_.isEmpty(formError) && (
+                    <FormHelpMessage
+                        style={[styles.pAbsolute, styles.b0, styles.mb0, styles.ph5, styles.w100]}


Absolutely positioning the error message caused #32661 where the error message starts to overlap the amount input when zooming in.

aman-atg added 2 commits October 24, 2023 21:25

use absolute positioning for error message and ensure 12px of gap

a6e963d

Merge branch 'main' of github.com:Expensify/App into aman/fix-error-m…

f63eba0

…essage-positioning-on-amount-page

aman-atg marked this pull request as ready for review October 26, 2023 05:41

aman-atg requested a review from a team as a code owner October 26, 2023 05:41

melvin-bot bot requested review from situchan and removed request for a team October 26, 2023 05:42

aman-atg mentioned this pull request Oct 26, 2023

[HOLD for payment 2023-11-07] [$500] Request Money - Amount input getting displaced if there is an error #29204

Closed

6 tasks

situchan approved these changes Oct 26, 2023

View reviewed changes

melvin-bot bot requested a review from amyevans October 26, 2023 17:24

amyevans approved these changes Oct 27, 2023

View reviewed changes

amyevans merged commit be779f0 into Expensify:main Oct 27, 2023

OSBotify mentioned this pull request Oct 30, 2023

Deploy Checklist: New Expensify 2023-10-30 #30560

Closed

OSBotify mentioned this pull request Oct 31, 2023

Deploy Checklist: New Expensify 2023-10-31 #30662

Closed

97 tasks

FitseTLT mentioned this pull request Dec 7, 2023

[HOLD for payment 2023-12-29] [$500] IOU - Error message in Amount page overlaps with amount field when zoom level in 150% #32661

Closed

6 tasks

jjcoffee reviewed Jan 2, 2024

View reviewed changes

Conversation

aman-atg commented Oct 24, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

aman-atg commented Oct 24, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

aman-atg commented Oct 24, 2023

Uh oh!

situchan commented Oct 24, 2023

Uh oh!

aman-atg commented Oct 24, 2023

Uh oh!

situchan commented Oct 24, 2023

Uh oh!

aman-atg commented Oct 24, 2023

Uh oh!

aman-atg commented Oct 24, 2023

Uh oh!

aman-atg commented Oct 24, 2023

Uh oh!

situchan commented Oct 24, 2023

Uh oh!

aman-atg commented Oct 24, 2023

Uh oh!

shawnborton commented Oct 25, 2023

Uh oh!

dannymcclain commented Oct 25, 2023

Uh oh!

aman-atg commented Oct 25, 2023

Uh oh!

dannymcclain commented Oct 25, 2023

Uh oh!

shawnborton commented Oct 25, 2023

Uh oh!

melvin-bot bot commented Oct 26, 2023

Uh oh!

situchan commented Oct 26, 2023

Reviewer Checklist

Screenshots/Videos

Uh oh!

situchan left a comment

Choose a reason for hiding this comment

Uh oh!

aman-atg commented Oct 27, 2023

Uh oh!

aman-atg commented Oct 27, 2023

Uh oh!

OSBotify commented Oct 30, 2023

Uh oh!

OSBotify commented Oct 31, 2023

Uh oh!

OSBotify commented Oct 31, 2023

Uh oh!

OSBotify commented Nov 1, 2023

Uh oh!

OSBotify commented Nov 2, 2023

Uh oh!

jjcoffee Jan 2, 2024

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

aman-atg commented Oct 24, 2023 •

edited

Loading

aman-atg commented Oct 24, 2023 •

edited

Loading