Fix/29812: Same page has different error text color for different errors by Victor-Nyagudi · Pull Request #30325 · Expensify/App

Victor-Nyagudi · 2023-10-25T07:00:26Z

Details

Errors in Expensify are shown in red text, but the error shown when trying to create a distance request without adding waypoints has a red dot accompanied by light-greyish green text (the color of success messages when accompanied by a green dot).

This PR restores the red color to the error text.

Fixed Issues

$ #29812
PROPOSAL: #29812 (comment)

Tests

Log into a test account.
Click the green circle with a "+" sign in it at the bottom left of the screen.
Select "Request money" from the modal that appears.
If you're on Mac Chrome, Mac Safari, or the Mac desktop app and the app/browser is at least half the width of the screen, a panel will appear on the right side. If on mobile, a modal this panel/modal will fill the screen. Click on the "Distance" tab.
Click on the large, green pill button at the bottom of the panel/modal that says "Next".
Verify a red dot appears above the button in step 5 with red text to its right that says "Please enter at least two waypoints".
Tap on the left facing caret/arrow at the top of the modal next to the words "Request money" to go back/close the panel/modal.
Click on the avatar at the top left of the screen and then click on "Profile" in the panel/modal that appears.
Click on "Contact method" and then click on the green pill button at the bottom that says "New contact method".
Enter a valid email e.g. another test account you have access to, and then click on the green pill button at the bottom that says "Add". You'll be redirected to the previous screen.
Click on the email you just added. It should have a green dot next to it.
Verify a green dot with light-greyish green text to its right saying "Please enter the magic code sent to [the email you entered in Step 10]" is shown below the header with the Step 10 email and left facing caret/arrow.

Verify that no errors appear in the JS console

Offline tests

After logging into an account while online, turn off the wifi/internet connection and perform steps 2 through 6 in the "Tests" section above. You can also force offline by clicking on the avatar at the top left of the screen -> preferences -> toggle offline.

You can add a contact method while offline, but you won't be able to click it (step 11) to navigate to the screen with the green dot and light-greyish green text.

QA Steps

Same as above in the "Tests" section.

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

Victor-Nyagudi · 2023-10-25T14:44:50Z

It appears this bug occurs in other places too like when you try uploading an image over 6MB as your avatar.

Image upload error before changes

Same thing if you input the wrong magic link numbers when trying to add another contact method.

Contact method error before changes

In addition, trying to unlink a login method with account errors (tried but not sure how to reproduce this one) or if it's detected you committed domain fraud (I prefer to stay out of jail, so I won't try reproducing this), the error shows up in the wrong text color.

App/src/pages/signin/UnlinkLoginForm.js

Lines 73 to 79 in 38d647e

    
           {!_.isEmpty(props.account.errors) && ( 
        
               <DotIndicatorMessage 
        
                   style={[styles.mb5]} 
        
                   type="error" 
        
                   messages={props.account.errors} 
        
               /> 
        
           )}

App/src/pages/settings/Wallet/ExpensifyCardPage.js

Lines 89 to 96 in 38d647e

    
           {hasDetectedDomainFraud ? ( 
        
               <DotIndicatorMessage 
        
                   style={[styles.pageWrapper]} 
        
                   textStyle={[styles.walletLockedMessage]} 
        
                   messages={{0: translate('cardPage.cardLocked')}} 
        
                   type="error" 
        
               /> 
        
           ) : null}

The changes in this PR will address those cases. Here's a sample.

Image upload error after changes

However, during my testing, I stumbled on this other error that doesn't show red text if you deny location permissions when adding a start position to a distance request i.e. click on FAB -> Request money -> Distance -> Click start -> Select "Use your location" from dropdown when input is focused-> deny location permission

Denied location permission error

The current changes won't apply because this particular error is rendered using LocationErrorMessage, not DotIndicatorMessage.

App/src/components/LocationErrorMessage/BaseLocationErrorMessage.js

Lines 43 to 52 in 2d6e8ef

    
           {isPermissionDenied ? ( 
        
               <Text> 
        
                   <Text style={[styles.offlineFeedback.text]}>{`${translate('location.permissionDenied')} ${translate('location.please')}`}</Text> 
        
                   <TextLink 
        
                       onPress={onAllowLocationLinkPress} 
        
                       style={styles.locationErrorLinkText} 
        
                   > 
        
                       {` ${translate('location.allowPermission')} `} 
        
                   </TextLink> 
        
                   <Text style={[styles.offlineFeedback.text]}>{translate('location.tryAgain')}</Text>

The text there is styled using styles.offlineFeedback.text, similar to the text in DotIndicatorMessage, except the color isn't set back to red.

I figured I'd ask first before making any changes other than the ones agreed upon in my proposal.

Should we opt to fix the denied permission error in this PR, we could potentially create a helper method like getFormErrorColor() in StyleUtils that returns the {color: styles.formError.color} style and apply it in both DotIndicatorMessage and BaseLocationErrorMessage.

We could even create a new style seeing as it will be used twice in LocationErrorMessage. Something like:

locationErrorMessage {
    ...offlineFeedback.text,
    color: formError.color
}

Let me know your thoughts on this.

Victor-Nyagudi · 2023-10-25T17:12:48Z

I'm yet to find other places where the error text color is light greyish-green isn't of red.

melvin-bot · 2023-10-25T17:12:58Z

@thesahindia Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

…n-same-page

Victor-Nyagudi · 2023-10-27T18:50:17Z

Friendly bump @thesahindia for a review.

…n-same-page

thesahindia · 2023-10-28T09:54:33Z

Should we opt to fix the denied permission error in this PR, we could potentially create a helper method like getFormErrorColor() in StyleUtils that returns the {color: styles.formError.color} style and apply it in both DotIndicatorMessage and BaseLocationErrorMessage.

Yeah, let's do it.

Victor-Nyagudi · 2023-10-28T09:56:49Z

I'm on it.

Victor-Nyagudi · 2023-10-28T11:28:54Z

All yours, @thesahindia.

Tests well too.

thesahindia · 2023-10-28T19:32:31Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

thesahindia · 2023-10-28T19:33:05Z

@Victor-Nyagudi please resolve the conflicts.

Victor-Nyagudi · 2023-10-28T21:30:55Z

@thesahindia All conflicts have been resolved.

We're good to move forward.

thesahindia

LGTM!

OSBotify · 2023-10-30T19:58:10Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2023-10-31T22:00:10Z

🚀 Deployed to staging by https://github.com/bondydaa in version: 1.3.94-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	failure ❌
🕸 web 🕸	success ✅

OSBotify · 2023-11-01T08:52:09Z

🚀 Deployed to staging by https://github.com/bondydaa in version: 1.3.94-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	failure ❌
🕸 web 🕸	success ✅

OSBotify · 2023-11-02T10:15:30Z

🚀 Deployed to production by https://github.com/Beamanator in version: 1.3.94-2 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2023-11-02T10:40:17Z

🚀 Deployed to staging by https://github.com/bondydaa in version: 1.3.95-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2023-11-06T22:10:20Z

🚀 Deployed to production by https://github.com/puneetlath in version: 1.3.95-9 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

Change error text color to red if the message type is 'error'

9bc0018

Victor-Nyagudi changed the title ~~Fix-29812: Different error text colors for different errors~~ Fix/29812: Same page has different error text color for different errors Oct 25, 2023

Rename isErrorMessageType to isErrorMessage

39472e6

Victor-Nyagudi marked this pull request as ready for review October 25, 2023 17:12

Victor-Nyagudi requested a review from a team as a code owner October 25, 2023 17:12

melvin-bot bot requested review from thesahindia and removed request for a team October 25, 2023 17:12

Victor-Nyagudi mentioned this pull request Oct 25, 2023

[HOLD for payment 2023-11-09] [$500] Same page has different error text color for different errors #29812

Closed

6 tasks

Merge branch 'Expensify:main' into fix/29812-different-error-colors-o…

3604963

…n-same-page

Merge branch 'Expensify:main' into fix/29812-different-error-colors-o…

f7f3a88

…n-same-page

Victor-Nyagudi added 3 commits October 28, 2023 13:54

Create helper method to style red dot error text

a48b5ce

Remove unnecessary type annotation

8cfc2d5

Run prettier for prettier diff

b992aed

Victor-Nyagudi and others added 2 commits October 28, 2023 23:53

Merge branch 'main' into fix/29812-different-error-colors-on-same-page

9bf6961

Run prettier to fix diffs

f497b16

thesahindia approved these changes Oct 29, 2023

View reviewed changes

melvin-bot bot requested a review from bondydaa October 29, 2023 03:37

bondydaa approved these changes Oct 30, 2023

View reviewed changes

bondydaa merged commit 50a327c into Expensify:main Oct 30, 2023

OSBotify mentioned this pull request Oct 31, 2023

Deploy Checklist: New Expensify 2023-10-31 #30662

Closed

97 tasks

OSBotify mentioned this pull request Nov 2, 2023

Deploy Checklist: New Expensify 2023-11-02 #30752

Closed

Victor-Nyagudi mentioned this pull request Nov 13, 2023

HOLD for payment 2023-11-17 - [$1000] Web - Incorrect comment formatting after approval #27544

Closed

6 tasks

Conversation

Victor-Nyagudi commented Oct 25, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

Victor-Nyagudi commented Oct 25, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Victor-Nyagudi commented Oct 25, 2023

Uh oh!

melvin-bot bot commented Oct 25, 2023

Uh oh!

Victor-Nyagudi commented Oct 27, 2023

Uh oh!

thesahindia commented Oct 28, 2023

Uh oh!

Victor-Nyagudi commented Oct 28, 2023

Uh oh!

Victor-Nyagudi commented Oct 28, 2023

Uh oh!

thesahindia commented Oct 28, 2023

Reviewer Checklist

Screenshots/Videos

Uh oh!

thesahindia commented Oct 28, 2023

Uh oh!

Victor-Nyagudi commented Oct 28, 2023

Uh oh!

thesahindia left a comment

Choose a reason for hiding this comment

Uh oh!

OSBotify commented Oct 30, 2023

Uh oh!

OSBotify commented Oct 31, 2023

Uh oh!

OSBotify commented Nov 1, 2023

Uh oh!

OSBotify commented Nov 2, 2023

Uh oh!

OSBotify commented Nov 2, 2023

Uh oh!

OSBotify commented Nov 6, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Victor-Nyagudi commented Oct 25, 2023 •

edited

Loading

Victor-Nyagudi commented Oct 25, 2023 •

edited

Loading