Skip to content

[CP Staging] Fix viewing attachments #30481

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tgolen merged 4 commits into from
Oct 27, 2023
Merged

[CP Staging] Fix viewing attachments #30481

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
e0e51ed
Fix viewing attachments
youssef-lr Oct 27, 2023
d2844c9
Add dependencies to useCallback
youssef-lr Oct 27, 2023
1c8903f
Remove unneeded ref
youssef-lr Oct 27, 2023
8531566
Apply fix in AttachmentModal instead of BaseOptionsList
youssef-lr Oct 27, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 10 additions & 5 deletions src/pages/home/report/ReportAttachments.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import React from 'react';
import React, {useCallback} from 'react';
import _ from 'underscore';
import PropTypes from 'prop-types';
import AttachmentModal from '../../../components/AttachmentModal';
Expand All @@ -24,17 +24,22 @@ function ReportAttachments(props) {
const report = ReportUtils.getReport(reportID);
const source = decodeURI(_.get(props, ['route', 'params', 'source']));

const onCarouselAttachmentChange = useCallback(
(attachment) => {
const route = ROUTES.REPORT_ATTACHMENTS.getRoute(reportID, attachment.source);
Navigation.navigate(route);
},
[reportID],
);

return (
<AttachmentModal
allowDownload
defaultOpen
report={report}
source={source}
onModalHide={() => Navigation.dismissModal()}
onCarouselAttachmentChange={(attachment) => {
const route = ROUTES.REPORT_ATTACHMENTS.getRoute(reportID, attachment.source);
Navigation.navigate(route);
}}
onCarouselAttachmentChange={onCarouselAttachmentChange}
/>
);
}
Expand Down