[NoQA] test(reassure): get last visible action#30482
Merged
mountiny merged 7 commits intoExpensify:mainfrom Nov 1, 2023
Merged
[NoQA] test(reassure): get last visible action#30482mountiny merged 7 commits intoExpensify:mainfrom
mountiny merged 7 commits intoExpensify:mainfrom
Conversation
Contributor
Author
|
@mountiny could you please advise on which issue to link back in the description? Thanks!! |
Contributor
|
@adhorodyski lets just link the original reassure issue |
barttom
reviewed
Oct 30, 2023
|
@ Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
Contributor
Author
|
@mountiny now ready for your review :) |
Contributor
Reviewer Checklist
Screenshots/VideosAndroid: NativeAndroid: mWeb ChromeiOS: NativeiOS: mWeb SafariMacOS: Chrome / SafariMacOS: Desktop |
Contributor
|
🚀 Deployed to staging by https://github.com/mountiny in version: 1.3.95-0 🚀
|
Contributor
|
🚀 Deployed to production by https://github.com/puneetlath in version: 1.3.95-9 🚀
|
Contributor
|
🚀 Deployed to staging by https://github.com/mountiny in version: 1.3.96-0 🚀
|
Contributor
|
🚀 Deployed to production by https://github.com/puneetlath in version: 1.3.96-15 🚀
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Details
This PR introduces performance tests using Reassure, covering
getLastVisibleActionmethod.Fixed Issues
$ #30482
Tests
N/A
Offline tests
N/A
QA Steps
N/A
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectiontoggleReportand notonIconClick)myBool && <MyComponent />.src/languages/*files and using the translation methodWaiting for Copylabel for a copy review on the original GH to get the correct copy.STYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)/** comment above it */thisproperly so there are no scoping issues (i.e. foronClick={this.submit}the methodthis.submitshould be bound tothisin the constructor)thisare necessary to be bound (i.e. avoidthis.submit = this.submit.bind(this);ifthis.submitis never passed to a component event handler likeonClick)StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG))Avataris modified, I verified thatAvataris working as expected in all cases)ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
N/A, this PR only introduces performance tests.
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari
MacOS: Desktop