fix: don't focus composer if emoji picker is opened by dummy-1111 · Pull Request #30483 · Expensify/App

dummy-1111 · 2023-10-27T08:40:46Z

Details

Don't focus the composer when emoji picker is visible

Fixed Issues

$ #30119
PROPOSAL: #30119 (comment)

Tests

Note: Tests are only for web and desktop

Open ND and log in with any account
Navigate to any chat
Send message A
Send message B
React message A with any emoji
Swith message B to edit mode
Open EmojiPicker by tapping emoji button in message B edit composer
Open EmojiPicker by tapping emoji bubble button in message A
Verify that the focus is in EmojiPicker
Open EmojiPicker by tapping emoji button in the main composer
Open EmojiPicker by tapping emoji bubble button in message A
Verify that the focus is in EmojiPicker

Verify that no errors appear in the JS console

Offline tests

Open ND and log in with any account
Navigate to any chat
Send message A
Send message B
React message A with any emoji
Swith message B to edit mode
Open EmojiPicker by tapping emoji button in message B edit composer
Open EmojiPicker by tapping emoji bubble button in message A
Verify that the focus is in EmojiPicker
Open EmojiPicker by tapping emoji button in the main composer
Open EmojiPicker by tapping emoji bubble button in message A
Verify that the focus is in EmojiPicker

QA Steps

Open ND and log in with any account
Navigate to any chat
Send message A
Send message B
React message A with any emoji
Swith message B to edit mode
Open EmojiPicker by tapping emoji button in message B edit composer
Open EmojiPicker by tapping emoji bubble button in message A
Verify that the focus is in EmojiPicker
Open EmojiPicker by tapping emoji button in the main composer
Open EmojiPicker by tapping emoji bubble button in message A
Verify that the focus is in EmojiPicker

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

30119_android_native.mp4

Android: mWeb Chrome

30119_android_chrome.mp4

iOS: Native

30119_ios_native.mp4

iOS: mWeb Safari

30119_ios_safari.mp4

MacOS: Chrome / Safari

30119_mac_chrome.mp4

MacOS: Desktop

30119_mac_desktop.mp4

melvin-bot · 2023-10-27T08:49:27Z

@cubuspl42 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

jakub-trzebiatowski · 2023-10-27T09:15:20Z

@s-alves10 When describing tests with users "A" and "B", note in the "Tests" section which users have to be logged-in on the app built from the PR branch.

dummy-1111 · 2023-10-27T09:18:39Z

I'm sorry but I didn't understand you. You mean put them in quotes?

jakub-trzebiatowski · 2023-10-27T09:19:29Z

@s-alves10 I'm sorry, I'm a bit sleepy it appears. I thought your test describes a multi-user scenario (for user A and user B). Nevermind.

jakub-trzebiatowski · 2023-10-27T09:33:47Z

QA Steps should also mention that the expected results are only for web/desktop

jakub-trzebiatowski · 2023-10-27T09:39:19Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android / native
- Android / Chrome
- iOS / native
- iOS / Safari
- MacOS / Chrome / Safari
- MacOS / Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

focus-emoji-picker-web.mp4

Mobile Web - Chrome

Mobile Web - Safari

Desktop

focus-emoji-picker-desktop.mp4

iOS

Android

jakub-trzebiatowski · 2023-10-27T09:44:17Z

Actually, I noticed a behavior that's worrying:

composer-flicker-1.mov

Can you see that the composer for message "bbb" flickers when the emoji picker for message "aaa" is opened?

dummy-1111 · 2023-10-27T10:58:33Z

@cubuspl42

I don't think that isn't an issue, also I can't reproduce it. Is that desktop?

jakub-trzebiatowski · 2023-10-27T11:01:16Z

@s-alves10 It's Web, tested on Chrome and Firefox. Are you sure you're clicking the composers in the exactly same order?

dummy-1111 · 2023-10-27T13:00:09Z

@cubuspl42

I found the reason. When modal hide, we set isFocused state to true. I don't think this is needed because this state is set in onFocus handler.
Update

App/src/pages/home/report/ReportActionItemMessageEdit.js

Lines 435 to 438 in eef8347

    
           onModalHide={() => { 
        
               setIsFocused(true); 
        
               focus(true); 
        
           }}

to

        onModalHide={() => focus(true)}

This works fine. Please check

jakub-trzebiatowski · 2023-10-30T08:44:47Z

@s-alves10 Please fix conflicts

dummy-1111 · 2023-10-30T09:31:22Z

@cubuspl42

Conflicts were resolved

jakub-trzebiatowski · 2023-10-30T10:28:42Z

@s-alves10 No we have this:

focus-issue-1.mp4

dummy-1111 · 2023-10-30T10:58:31Z

@cubuspl42

The issue you mentioned is producible in staging as well. Looks like beyond the scope of this issue

jakub-trzebiatowski · 2023-10-31T13:34:46Z

@s-alves10 You're right, this is not related to this PR

OSBotify · 2023-10-31T20:14:35Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2023-10-31T21:58:37Z

🚀 Deployed to staging by https://github.com/flodnv in version: 1.3.94-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	failure ❌
🕸 web 🕸	success ✅

OSBotify · 2023-11-01T08:50:36Z

🚀 Deployed to staging by https://github.com/flodnv in version: 1.3.94-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	failure ❌
🕸 web 🕸	success ✅

OSBotify · 2023-11-02T10:13:57Z

🚀 Deployed to production by https://github.com/Beamanator in version: 1.3.94-2 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2023-11-02T10:38:44Z

🚀 Deployed to staging by https://github.com/flodnv in version: 1.3.95-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

getusha · 2023-11-03T13:42:40Z

src/libs/focusComposerWithDelay.ts

+ * Create a function that focuses the composer.
 */
-function focusWithDelay(textInput: TextInput | null): FocusWithDelay {
+function focusComposerWithDelay(textInput: TextInput | null): FocusComposerWithDelay {


Why is the name change required? we still have the option to pass the textInput ref, it is possible the input component not be the composer we are trying to focus always.

@getusha

Please check #30119 (comment)

OSBotify · 2023-11-06T22:08:47Z

🚀 Deployed to production by https://github.com/puneetlath in version: 1.3.95-9 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

fix: don't focus composer if emoji picker is opened

2603105

dummy-1111 marked this pull request as ready for review October 27, 2023 08:49

dummy-1111 requested a review from a team as a code owner October 27, 2023 08:49

melvin-bot bot requested review from jakub-trzebiatowski and removed request for a team October 27, 2023 08:49

dummy-1111 mentioned this pull request Oct 27, 2023

[HOLD for payment 2023-11-09] [$500] Chat - Focus on edit even when reaction emoji picker is opened #30119

Closed

6 tasks

fix: remove redundant focusing

d0ea6f0

sangar-1028 added 2 commits October 30, 2023 04:01

fix: conflicts

feb289c

fix: prettier

db3d93b

jakub-trzebiatowski approved these changes Oct 31, 2023

View reviewed changes

melvin-bot bot requested a review from flodnv October 31, 2023 13:35

flodnv approved these changes Oct 31, 2023

View reviewed changes

flodnv merged commit 902d7cc into Expensify:main Oct 31, 2023

OSBotify mentioned this pull request Oct 31, 2023

Deploy Checklist: New Expensify 2023-10-31 #30662

Closed

97 tasks

OSBotify mentioned this pull request Nov 2, 2023

Deploy Checklist: New Expensify 2023-11-02 #30752

Closed

getusha reviewed Nov 3, 2023

View reviewed changes

dummy-1111 deleted the fix/issue-30119 branch December 21, 2023 07:37

Conversation

dummy-1111 commented Oct 27, 2023

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot bot commented Oct 27, 2023

Uh oh!

jakub-trzebiatowski commented Oct 27, 2023

Uh oh!

dummy-1111 commented Oct 27, 2023

Uh oh!

jakub-trzebiatowski commented Oct 27, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

jakub-trzebiatowski commented Oct 27, 2023

Uh oh!

jakub-trzebiatowski commented Oct 27, 2023

Reviewer Checklist

Screenshots/Videos

Uh oh!

jakub-trzebiatowski commented Oct 27, 2023

Uh oh!

dummy-1111 commented Oct 27, 2023

Uh oh!

jakub-trzebiatowski commented Oct 27, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

dummy-1111 commented Oct 27, 2023

Uh oh!

jakub-trzebiatowski commented Oct 30, 2023

Uh oh!

dummy-1111 commented Oct 30, 2023

Uh oh!

jakub-trzebiatowski commented Oct 30, 2023

Uh oh!

dummy-1111 commented Oct 30, 2023

Uh oh!

jakub-trzebiatowski commented Oct 31, 2023

Uh oh!

OSBotify commented Oct 31, 2023

Uh oh!

OSBotify commented Oct 31, 2023

Uh oh!

OSBotify commented Nov 1, 2023

Uh oh!

OSBotify commented Nov 2, 2023

Uh oh!

OSBotify commented Nov 2, 2023

Uh oh!

getusha Nov 3, 2023

Choose a reason for hiding this comment

Uh oh!

dummy-1111 Nov 3, 2023

Choose a reason for hiding this comment

Uh oh!

OSBotify commented Nov 6, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

jakub-trzebiatowski commented Oct 27, 2023 •

edited

Loading

jakub-trzebiatowski commented Oct 27, 2023 •

edited

Loading