emoji/mention suggestion are displayed by HardikChoudhary24 · Pull Request #30521 · Expensify/App

HardikChoudhary24 · 2023-10-27T15:15:55Z

Details

This PR fixes the regression caused by #29434.

Fixed Issues

$ #28149
PROPOSAL:

Tests

Open any chat and paste an RTL text in the compose box, for example " مثال "
Continue typing some content
Verify that the content gets displayed from left to right
Verify that emoji/mention suggestions are displayed when triggered.

Verify that no errors appear in the JS console

Offline tests

QA Steps

Open any chat and paste an RTL text in the compose box, for example " مثال "
Continue typing some content.
Verify that the content gets displayed from left to right.
Verify that Emoji/Mention suggestions are showing

Verify that no errors appear in the JS console

PR Author Checklist

I linked the correct issue in the ### Fixed Issues section above
I wrote clear testing steps that cover the changes made in this PR
- I added steps for local testing in the Tests section
- I added steps for the expected offline behavior in the Offline steps section
- I added steps for Staging and/or Production testing in the QA steps section
- I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
- I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
I included screenshots or videos for tests on all platforms
I ran the tests on all platforms & verified they passed on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
I followed proper code patterns (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
  - If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I followed the guidelines as stated in the Review Guidelines
I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
I verified that if a function's arguments changed that all usages have also been updated correctly
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- If we are not using the full Onyx data that we loaded, I've added the proper selector in order to ensure the component only re-renders when the data it is using changes
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG))
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR author checklist, including those that don't apply to this PR.

Screenshots/Videos

MacOS: Chrome

chrome.mov

MacOS: Desktop

desktop.mov

Android: mWeb Chrome

WhatsApp.Video.2023-10-27.at.8.16.07.PM.mp4

iOS: Native

ios.mov

iOS: mWeb Safari

iOSWeb.mov

MacOS: Safari

safariweb.mov

Android: Native

android.mp4

melvin-bot · 2023-10-27T15:16:01Z

@burczu Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

situchan · 2023-10-27T15:22:35Z

Coming from #29434 (comment):

I think @burczu is already off for the weekend. If so I can do expedite review.
cc: @neil-marcellini

situchan

Still doesn't work with MacOS emoji

Screen.Recording.2023-10-27.at.9.41.23.PM.mov

HardikChoudhary24 · 2023-10-27T15:47:20Z

Still doesn't work with MacOS emoji

Screen.Recording.2023-10-27.at.9.41.23.PM.mov

@situchan yes I just read the conversation on slack, I am pushing the changes to support native emoji also. It is not included in the LTR or RTL range so need to check for it in a different function

HardikChoudhary24 · 2023-10-27T17:03:20Z

@situchan I have fixed it for native emojis also and have tested on all the platforms.

situchan · 2023-10-27T17:13:34Z

Nice! I like the approach of removing LTR pattern.
Can you also make sure that this doesn't break the fix of original issue?

HardikChoudhary24 · 2023-10-27T17:14:59Z

Yes I have ensured that it doesn't break the original issue. You can also test it, although I have added screen recording in the PR description

situchan · 2023-10-27T17:42:21Z

Just to confirm this console error is not caused by your PRs, right?

HardikChoudhary24 · 2023-10-27T17:49:21Z

Just to confirm this console error is not caused by your PRs, right?

No, I don't think so. Also it is not there on my console.

situchan · 2023-10-27T18:01:52Z

Not caused by this PR but is this expected? Cursor moves to the end when type at the beginning

Screen.Recording.2023-10-28.at.12.00.43.AM.mov

HardikChoudhary24 · 2023-10-27T18:12:22Z

Yes, that's happening because CONST.UNICODE.LTR is added at the start of the string if it begins with an RTL (Right-to-Left) character. When you traverse back to the start and start typing, it behaves normally. However, if you traverse to the start and then move one step backward, the issue is reproduced.

Screen.Recording.2023-10-27.at.11.36.43.PM.mov

But if you directly place the cursor at the start, it works normally. This issue seems to be related to CONST.UNICODE.LTR and only occurs when the string starts with an RTL character. I'm not sure if there is a solution for this, but I'm open to suggestions.

situchan · 2023-10-27T18:14:35Z

That seems like separate issue though and happens only when RTL text is added which is not normal flow.
We should first fix this critical bug (suggestion not displaying) so going ahead checklist.

situchan · 2023-10-27T18:14:45Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

android.mov

Android: mWeb Chrome

mchrome.mov

iOS: Native

ios.mov

iOS: mWeb Safari

msafari.mov

MacOS: Chrome / Safari

web.mov

MacOS: Desktop

desktop.mov

neil-marcellini

Thanks for the quick fix.

OSBotify · 2023-10-27T19:14:51Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

aimane-chnaif · 2023-10-29T13:24:03Z

src/libs/convertToLTRForComposer/index.ts

+    // Ensure that the text starts with RTL characters if not we return the same text to avoid concatination with special character at the start which leads to unexpected behaviour for Emoji/Mention suggestions.
+    if (!hasRTLCharacters(text)) {
+        // If text is empty string return empty string to avoid an empty draft due to special character.
+        if (text === '' || CONST.UNICODE.LTR.match(text)) {


@HardikChoudhary24 I am not able to type [ in composer

Can you raise quick PR fixing that?

@aimane-chnaif Thanks for the feedback. I have fixed the issue and raised the PR #30559.

OSBotify · 2023-10-30T08:01:47Z

🚀 Deployed to staging by https://github.com/neil-marcellini in version: 1.3.93-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2023-10-31T21:34:57Z

🚀 Deployed to production by https://github.com/Beamanator in version: 1.3.93-1 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2023-10-31T22:01:40Z

🚀 Deployed to staging by https://github.com/neil-marcellini in version: 1.3.94-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	failure ❌
🕸 web 🕸	success ✅

OSBotify · 2023-11-01T08:53:40Z

🚀 Deployed to staging by https://github.com/neil-marcellini in version: 1.3.94-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	failure ❌
🕸 web 🕸	success ✅

OSBotify · 2023-11-02T10:17:00Z

🚀 Deployed to production by https://github.com/Beamanator in version: 1.3.94-2 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

emoji/mention suggestion are displayed

6777fb5

HardikChoudhary24 requested a review from a team as a code owner October 27, 2023 15:15

melvin-bot bot requested review from burczu and removed request for a team October 27, 2023 15:15

situchan reviewed Oct 27, 2023

View reviewed changes

native emoji support added

11053d9

situchan approved these changes Oct 27, 2023

View reviewed changes

melvin-bot bot requested a review from neil-marcellini October 27, 2023 18:15

neil-marcellini approved these changes Oct 27, 2023

View reviewed changes

neil-marcellini merged commit e3f4311 into Expensify:main Oct 27, 2023

aimane-chnaif reviewed Oct 29, 2023

View reviewed changes

HardikChoudhary24 mentioned this pull request Oct 29, 2023

[CP Staging] input of '[' and other special characters fixed #30559

Merged

59 tasks

OSBotify mentioned this pull request Oct 30, 2023

Deploy Checklist: New Expensify 2023-10-30 #30560

Closed

lanitochka17 mentioned this pull request Oct 30, 2023

[HOLD for payment 2024-01-04] [$500] Android - Chat - Message gets displayed from right to left #30584

Closed

6 tasks

grgia mentioned this pull request Oct 30, 2023

Chat - Unable to type a few symbols and console error shows up #30583

Closed

6 tasks

melvin-bot bot mentioned this pull request Oct 31, 2023

[HOLD for payment 2023-11-09] [$500] Chat - Compose box - Wrong cursor position for RTL texts and inverted arrow keys functionality #28149

Closed

6 tasks

OSBotify mentioned this pull request Oct 31, 2023

Deploy Checklist: New Expensify 2023-10-31 #30662

Closed

97 tasks

Conversation

HardikChoudhary24 commented Oct 27, 2023

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot bot commented Oct 27, 2023

Uh oh!

situchan commented Oct 27, 2023

Uh oh!

situchan left a comment

Choose a reason for hiding this comment

Uh oh!

HardikChoudhary24 commented Oct 27, 2023

Uh oh!

HardikChoudhary24 commented Oct 27, 2023

Uh oh!

situchan commented Oct 27, 2023

Uh oh!

HardikChoudhary24 commented Oct 27, 2023

Uh oh!

situchan commented Oct 27, 2023

Uh oh!

HardikChoudhary24 commented Oct 27, 2023

Uh oh!

situchan commented Oct 27, 2023

Uh oh!

HardikChoudhary24 commented Oct 27, 2023

Uh oh!

situchan commented Oct 27, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

situchan commented Oct 27, 2023

Reviewer Checklist

Screenshots/Videos

Uh oh!

neil-marcellini left a comment

Choose a reason for hiding this comment

Uh oh!

OSBotify commented Oct 27, 2023

Uh oh!

aimane-chnaif Oct 29, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

HardikChoudhary24 Oct 29, 2023

Choose a reason for hiding this comment

Uh oh!

OSBotify commented Oct 30, 2023

Uh oh!

OSBotify commented Oct 31, 2023

Uh oh!

OSBotify commented Oct 31, 2023

Uh oh!

OSBotify commented Nov 1, 2023

Uh oh!

OSBotify commented Nov 2, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

situchan commented Oct 27, 2023 •

edited

Loading

aimane-chnaif Oct 29, 2023 •

edited

Loading