Remove openreport api calls while switching windows#30572
Remove openreport api calls while switching windows#30572marcaaron merged 2 commits intoExpensify:mainfrom
Conversation
|
@hoangzinh Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
|
Let me know when your PR is ready to review. Thanks |
|
ready for review @hoangzinh |
|
@saranshbalyan-1234 how come the PR title is "resolved conflicts"? |
|
Changed title @hoangzinh |
|
@saranshbalyan-1234 what is bold text "Login as User A" mean in your QA test? And how come we don't have any test in Tests section? (usually Tests section describes what you gonna test/record) |
|
@hoangzinh updated again :) |
Reviewer Checklist
Screenshots/VideosAndroid: NativeScreen.Recording.2023-10-30.at.23.10.18.-.android.movAndroid: mWeb ChromeScreen.Recording.2023-10-30.at.22.59.52.-.android.chrome.moviOS: NativeScreen.Recording.2023-10-30.at.22.42.39.-.ios.mp4Screen.Recording.2023-10-30.at.22.44.21.-.ios.offline.moviOS: mWeb SafariScreen.Recording.2023-10-30.at.22.46.02.-.ios.safari.movMacOS: Chrome / SafariScreen.Recording.2023-10-30.at.22.54.41.-.web.movMacOS: DesktopScreen.Recording.2023-10-30.at.22.57.35.-.desktop.mov |
|
There is a missing "Verify that no errors appear in the JS console" checkbox in PR description for QA tests. Could you check? https://github.com/Expensify/App/blob/main/.github/PULL_REQUEST_TEMPLATE.md#qa-steps |
updated |
hoangzinh
left a comment
There was a problem hiding this comment.
Looks good! @saranshbalyan-1234 please prepare the PR description better next time.
|
@hoangzinh thank you |
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
Performance Comparison Report 📊Significant Changes To Duration
Show details
Meaningless Changes To DurationShow entries
Show details
|
|
@Expensify/mobile-deployers 📣 Please look into this performance regression as it's a deploy blocker. |
|
The reported deploy blocker is likely a false positive, investigating … |
|
🚀 Deployed to staging by https://github.com/marcaaron in version: 1.3.94-0 🚀
|
|
🚀 Deployed to staging by https://github.com/marcaaron in version: 1.3.94-0 🚀
|
|
🚀 Deployed to production by https://github.com/Beamanator in version: 1.3.94-2 🚀
|
|
🚀 Deployed to staging by https://github.com/marcaaron in version: 1.3.95-0 🚀
|
|
🚀 Deployed to production by https://github.com/puneetlath in version: 1.3.95-9 🚀
|

Details
Fixed Issues
$ #27887
PROPOSAL: #27887 (comment)
Tests
On Web/mWeb
On Desktop/Native app
Offline tests
Same as QA steps
QA Steps
On Web/mWeb
On Desktop/Native app
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectiontoggleReportand notonIconClick)myBool && <MyComponent />.src/languages/*files and using the translation methodWaiting for Copylabel for a copy review on the original GH to get the correct copy.STYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)/** comment above it */thisproperly so there are no scoping issues (i.e. foronClick={this.submit}the methodthis.submitshould be bound tothisin the constructor)thisare necessary to be bound (i.e. avoidthis.submit = this.submit.bind(this);ifthis.submitis never passed to a component event handler likeonClick)StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG))Avataris modified, I verified thatAvataris working as expected in all cases)ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
android.mp4
screen-recording-2023-10-27-at-73444-pm_YTTZdAbw.mp4
Android: mWeb Chrome
chrome.mp4
WhatsApp.Video.2023-10-27.at.6.53.00.PM.mp4
iOS: Native
screen-recording-2023-10-28-at-53406-pm_CE77IvDh.mp4
screen-recording-2023-10-27-at-22738-pm_V2cYSfRu.mp4
iOS: mWeb Safari
safari.mp4
WhatsApp.Video.2023-10-27.at.6.53.01.PM.mp4
MacOS: Chrome / Safari
web.mp4
screen-recording-2023-10-25-at-24510-pm_FKqGXMw3.mp4
screen-recording-2023-10-26-at-111015-pm_ELxruhWH.mp4
MacOS: Desktop
desktop.mp4
screen-recording-2023-10-25-at-52758-pm_41MXnLP8.mp4
screen-recording-2023-10-27-at-123850-pm_1Kg5l47V.mp4