Update users to focus mode automatically if they have the minimum report number#30664
Merged
Update users to focus mode automatically if they have the minimum report number#30664
Conversation
…t into a different PR
…e() to happen forever
marcaaron
commented
Nov 1, 2023
|
@ Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
|
@ Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
bondydaa
approved these changes
Dec 5, 2023
This was referenced Dec 6, 2023
situchan
reviewed
Dec 6, 2023
| displayName={displayName} | ||
| // Only pass the press handler for internal links. For public links or whitelisted internal links fallback to default link handling | ||
| onPress={internalNewExpensifyPath || internalExpensifyPath ? navigateToLink : undefined} | ||
| onPress={internalNewExpensifyPath || internalExpensifyPath ? Link.openLink : undefined} |
Contributor
There was a problem hiding this comment.
App crashes when open internal link. Link.openLink requires 3 params as above.
Here's PR fixing this - #32553
74 tasks
Contributor
|
🚀 Deployed to staging by https://github.com/bondydaa in version: 1.4.9-0 🚀
|
1 similar comment
Contributor
|
🚀 Deployed to staging by https://github.com/bondydaa in version: 1.4.9-0 🚀
|
47 tasks
Contributor
|
🚀 Deployed to production by https://github.com/yuwenmemon in version: 1.4.9-5 🚀
|
6 tasks
50 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Details
Front end changes required to auto-switch a user over to focus mode when they exceed a certain number of reports.
This PR must be tested together with:
Auth PR: https://github.com/Expensify/Auth/pull/9085
Web-PR: https://github.com/Expensify/Web-Expensify/pull/39450
Fixed Issues
https://github.com/Expensify/Expensify/issues/329101
$ #32372
Tests
Dev only test to simulate signed in users getting new app version
switch to main and sign in with an account that has not switched to focus mode yet and is still in "Most recent" mode
switch to this branch and refresh
verify the modal appear
Verify that no errors appear in the JS console
Offline tests
QA Steps
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectiontoggleReportand notonIconClick)myBool && <MyComponent />.src/languages/*files and using the translation methodWaiting for Copylabel for a copy review on the original GH to get the correct copy.STYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)/** comment above it */thisare necessary to be bound (i.e. avoidthis.submit = this.submit.bind(this);ifthis.submitis never passed to a component event handler likeonClick)StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG))Avataris modified, I verified thatAvataris working as expected in all cases)ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari
MacOS: Desktop