Fix ios and msafari to scroll text of edit message to bottom when click edit comment by tsa321 · Pull Request #30857 · Expensify/App

tsa321 · 2023-11-03T15:48:52Z

Details

Fixed Issues

$ #29782
PROPOSAL: #29782 (comment)

Tests

Open any report
Send comment/message with multiple lines 7 or more
Edit the message
Notice the text input show the last line of the message at the bottom of the text input

Verify that no errors appear in the JS console

Offline tests

QA Steps

Open any report
Send comment/message with multiple lines 7 or more
Edit the message
Notice the text input show the last line of the message at the bottom of the text input

Verify that no errors appear in the JS console

PR Author Checklist

I linked the correct issue in the ### Fixed Issues section above
I wrote clear testing steps that cover the changes made in this PR
- I added steps for local testing in the Tests section
- I added steps for the expected offline behavior in the Offline steps section
- I added steps for Staging and/or Production testing in the QA steps section
- I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
- I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
I included screenshots or videos for tests on all platforms
I ran the tests on all platforms & verified they passed on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
I followed proper code patterns (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
  - If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I followed the guidelines as stated in the Review Guidelines
I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
I verified that if a function's arguments changed that all usages have also been updated correctly
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- If we are not using the full Onyx data that we loaded, I've added the proper selector in order to ensure the component only re-renders when the data it is using changes
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG))
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR author checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

android-native_d.mp4

Android: mWeb Chrome

android-mweb_d.mp4

iOS: Native

ios-native_d.mp4

iOS: mWeb Safari

ios-msfari_d.mp4

MacOS: Chrome / Safari

macos-web_d.mp4

MacOS: Desktop

macos-desktop_d.mp4

…ck edit comment Signed-off-by: Tsaqif <tsaiinkwa@yahoo.com>

melvin-bot · 2023-11-03T15:48:57Z

@narefyev91 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

tsa321 · 2023-11-03T15:53:14Z

src/pages/home/report/ReportActionItem.js


+        if (textInputRef.current) {
+            textInputRef.current.focus();
+        }


I am putting the focus here because if I put it in the mount of ReportActionItemMessageEdit, there will be a regression about:
If user leave the edited text message without closing it then he visit other report and comeback to the first report, the report action list will scroll to the unclosed text input of the edited message.

Hey @tsa321 - i think it's not a regression - if user has opened edit message - and move back and again to the same report - we should focus editing message box

scroll_to_edit_d.mp4

@narefyev91 Just to confirm, this is expected right? I will edit the code...

Yes - that's expected

@tsa321 let me know - when you will be remove those lines of code - i will start testing in parallel

Please wait, maybe in one or two hours I will move those lines to mount of the ReportActionEditMessage.

tsa321 · 2023-11-03T15:56:11Z

src/pages/home/report/ReportActionItemMessageEdit.js

                });
                return prevDraft;
            });
+            textInputRef.current.scrollTop = textInputRef.current.scrollHeight;


this line is specifically for ios-msafari, so I am putting it here.

narefyev91 · 2023-11-06T14:22:36Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android / native
- Android / Chrome
- iOS / native
- iOS / Safari
- MacOS / Chrome / Safari
- MacOS / Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

web.1.mp4

Mobile Web - Chrome

android-web.1.mp4

Mobile Web - Safari

ios-web.mp4

Desktop

desktop.mp4

iOS

ios.mp4

Android

android.mp4

narefyev91

Just need to remove lines from this file.
LGTM!
🎀 👀 🎀 C+ reviewed

Signed-off-by: Tsaqif <tsaiinkwa@yahoo.com>

tsa321 · 2023-11-06T16:00:51Z

src/pages/home/report/ReportActionsList.js

                    keyboardShouldPersistTaps="handled"
                    onLayout={onLayoutInner}
                    onScroll={trackVerticalScrolling}
+                    onScrollToIndexFailed={() => {}}


Error img:

Because I get this error when testing, I add this to catch the error.

OSBotify · 2023-11-06T20:00:35Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2023-11-06T22:29:49Z

🚀 Deployed to staging by https://github.com/tylerkaraszewski in version: 1.3.96-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

cristipaval · 2023-11-07T13:57:36Z

This PR introduced this regression.

tsa321 · 2023-11-07T14:21:59Z

@narefyev91 since this PR introduce regression on andorid, Can I move the logic into IOS or safari specific platform code?

narefyev91 · 2023-11-07T14:24:37Z

@narefyev91 since this PR introduce regression on andorid, Can I move the logic into IOS or safari specific platform code?

Yes let's separate fix only for platforms in which we have issues

tsa321 · 2023-11-08T04:24:12Z

Here is the follow up PR: #31041

lanitochka17 · 2023-11-09T14:28:22Z

Issue reproducible on latest build 1.3.97-2

RPReplay_Final1699517579.MP4

tsa321 · 2023-11-09T15:50:15Z

@narefyev91 Looks like my proposal for IOS native doesn't always works reliably, What should we do?
I am not sure if there is any react native api for scrolling the ios text input content.
I am fine with reverting this PR completely and opening for new proposal...

OSBotify · 2023-11-09T22:47:22Z

🚀 Deployed to production by https://github.com/puneetlath in version: 1.3.96-15 🚀

platform	result
🤖 android 🤖	failure ❌
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2023-11-10T15:43:54Z

🚀 Deployed to production by https://github.com/puneetlath in version: 1.3.97-7 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

narefyev91 · 2023-11-13T11:56:03Z

Was not able to reproduce issue mentioned in 1.3.97-2. Tested on latest main

Screen.Recording.2023-11-13.at.13.55.05.mov

Fix ios and msafari to scroll text of edit message to bottom when cli…

9402276

…ck edit comment Signed-off-by: Tsaqif <tsaiinkwa@yahoo.com>

tsa321 requested a review from a team as a code owner November 3, 2023 15:48

melvin-bot bot requested review from narefyev91 and removed request for a team November 3, 2023 15:48

tsa321 commented Nov 3, 2023

View reviewed changes

narefyev91 approved these changes Nov 6, 2023

View reviewed changes

melvin-bot bot requested a review from tylerkaraszewski November 6, 2023 14:40

Move the code into mount of ReportActionMessageEdit

657b79e

Signed-off-by: Tsaqif <tsaiinkwa@yahoo.com>

tsa321 commented Nov 6, 2023

View reviewed changes

tylerkaraszewski approved these changes Nov 6, 2023

View reviewed changes

tylerkaraszewski merged commit 55799dc into Expensify:main Nov 6, 2023

OSBotify mentioned this pull request Nov 6, 2023

Deploy Checklist: New Expensify 2023-11-06 #30929

Closed

narefyev91 mentioned this pull request Nov 7, 2023

[HOLD for payment 2023-11-21] [$500] iOS - Chat - Lines disappear in edit composer when editing multiline text #29782

Closed

6 tasks

kbecciv mentioned this pull request Nov 7, 2023

[$500] Chat - Scrolling down on edit composer with multi lines scrolls up the chat history #30987

Closed

6 tasks

OSBotify mentioned this pull request Nov 8, 2023

Deploy Checklist: New Expensify 2023-11-08 #31077

Closed

Conversation

tsa321 commented Nov 3, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot bot commented Nov 3, 2023

Uh oh!

tsa321 Nov 3, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

narefyev91 Nov 6, 2023

Choose a reason for hiding this comment

Uh oh!

tsa321 Nov 6, 2023

Choose a reason for hiding this comment

Uh oh!

narefyev91 Nov 6, 2023

Choose a reason for hiding this comment

Uh oh!

narefyev91 Nov 6, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

tsa321 Nov 6, 2023

Choose a reason for hiding this comment

Uh oh!

tsa321 Nov 6, 2023

Choose a reason for hiding this comment

Uh oh!

tsa321 Nov 3, 2023

Choose a reason for hiding this comment

Uh oh!

narefyev91 commented Nov 6, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

narefyev91 left a comment

Choose a reason for hiding this comment

Uh oh!

tsa321 Nov 6, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

OSBotify commented Nov 6, 2023

Uh oh!

OSBotify commented Nov 6, 2023

Uh oh!

cristipaval commented Nov 7, 2023

Uh oh!

tsa321 commented Nov 7, 2023

Uh oh!

narefyev91 commented Nov 7, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

tsa321 commented Nov 8, 2023

Uh oh!

lanitochka17 commented Nov 9, 2023

Uh oh!

tsa321 commented Nov 9, 2023

Uh oh!

OSBotify commented Nov 9, 2023

Uh oh!

OSBotify commented Nov 10, 2023

Uh oh!

narefyev91 commented Nov 13, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

tsa321 commented Nov 3, 2023 •

edited

Loading

tsa321 Nov 3, 2023 •

edited

Loading

narefyev91 Nov 6, 2023 •

edited

Loading

narefyev91 commented Nov 6, 2023 •

edited

Loading

tsa321 Nov 6, 2023 •

edited

Loading

narefyev91 commented Nov 7, 2023 •

edited

Loading