RBR should appear in LHN on failed split receipt scans by dukenv0307 · Pull Request #31043 · Expensify/App

dukenv0307 · 2023-11-08T06:38:56Z

Details

RBR should appear in LHN on failed split receipt scans and LHN preview message shows Receipt missing details

Fixed Issues

$ #29733
PROPOSAL: #29733 (comment)

Tests

Global create > Request money > scan a picture of your receipt or an image file that will fail
Select 2 participants to split > confirm
Wait for receipt scanning to fail
Observe the groupDM chat in the LHN does not have a red dot on the chat row
Verify that :
i. The chat row in the LHN has an RBR red dot
ii. The LHN preview message shows the Receipt missing details

Verify that no errors appear in the JS console

Offline tests

QA Steps

Global create > Request money > scan a picture of your receipt or an image file that will fail
Select 2 participants to split > confirm
Wait for receipt scanning to fail
Observe the groupDM chat in the LHN does not have a red dot on the chat row
Verify that :
i. The chat row in the LHN has an RBR red dot
ii. The LHN preview message shows the Receipt missing details

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

android-resize.mov

Android: mWeb Chrome

chrome-resize.mov

iOS: Native

ios-resize.mov

iOS: mWeb Safari

safari-resize.mov

MacOS: Chrome / Safari

web-resize.mov

MacOS: Desktop

desktop-resize.mov

melvin-bot · 2023-11-14T06:16:42Z

@Ollyws Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

dukenv0307 · 2023-11-16T03:58:26Z

@Ollyws Friendly bump. please help review the PR

Ollyws · 2023-11-17T15:29:24Z

Did we want to apply this to 1:1 messages too?

dukenv0307 · 2023-11-20T07:41:02Z

@Ollyws I believe we already agree on applying for both group and 1-1 DM. Please check this comment

Ollyws · 2023-11-20T16:48:11Z

@dukenv0307 It's not working for me in 1-1 DMs as you can see here.

dukenv0307 · 2023-11-24T05:25:18Z

@Ollyws If I am not wrong, the image here is a request money without splitting.
Not sure if we want to apply this in normal request money as well

Ollyws · 2023-11-27T14:51:24Z

@dukenv0307 Ah yes I suppose that is out of scope for this issue. We have some conflicts if you could take a look, thanks.

trjExpensify · 2023-11-29T16:52:25Z

@dukenv0307 can you fix the conflicts please?

dukenv0307 · 2023-11-30T04:47:31Z

@Ollyws I updated.

Ollyws · 2023-11-30T13:46:39Z

src/libs/ReportUtils.ts

+        const isReportPreviewError = ReportActionsUtils.isReportPreviewAction(action) && hasMissingSmartscanFields(ReportActionsUtils.getIOUReportIDFromReportActionPreview(action));
+        const isSplitBillError =
+            ReportActionsUtils.isSplitBillAction(action) &&
+            TransactionUtils.hasMissingSmartscanFields(TransactionUtils.getTransaction((action.originalMessage as IOUMessage).IOUTransactionID ?? '0') as Transaction);


getTransaction is marked as deprecated. Is there any alternative?

@Ollyws Code updated to use Onyx.connect instead of deprecated getTransaction func. Please re-review

Ollyws · 2023-12-04T17:13:33Z

@dukenv0307 Thanks for the update but we have a lint error.

Ollyws · 2023-12-05T17:10:58Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

01_Android_Native.mp4

Android: mWeb Chrome

02_Android_Chrome.mp4

iOS: Native

03_iOS_Native.mp4

iOS: mWeb Safari

04_iOS_Safari.mp4

MacOS: Chrome / Safari

MacOS: Desktop

Ollyws

LGTM.

trjExpensify · 2023-12-06T10:58:55Z

👋 @dukenv0307 can you address the conflicts today, please? Thanks!

dukenv0307 · 2023-12-06T11:14:23Z

@trjExpensify Updated.

trjExpensify · 2023-12-06T11:34:12Z

Perfect, thanks!

youssef-lr · 2023-12-06T17:16:45Z

Testing & reviewing now

youssef-lr · 2023-12-06T17:39:40Z

src/libs/ReportUtils.ts

+ * @param reportActions
+ * @returns
+ */
+function hasRequestError(reportActions: ReportAction[]) {


Suggested change

function hasRequestError(reportActions: ReportAction[]) {

function hasSmartscanError(reportActions: ReportAction[]) {

dukenv0307 · 2023-12-07T08:31:49Z

Resolved. @youssef-lr please help review again

OSBotify · 2023-12-07T15:47:14Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2023-12-08T01:23:56Z

🚀 Deployed to staging by https://github.com/youssef-lr in version: 1.4.10-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	cancelled 🔪
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2023-12-08T02:53:49Z

🚀 Deployed to staging by https://github.com/youssef-lr in version: 1.4.10-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2023-12-11T10:41:06Z

🚀 Deployed to production by https://github.com/Julesssss in version: 1.4.10-1 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	cancelled 🔪
🕸 web 🕸	success ✅

OSBotify · 2023-12-11T15:23:01Z

🚀 Deployed to production by https://github.com/Julesssss in version: 1.4.10-1 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	failure ❌
🕸 web 🕸	success ✅

dukenv0307 added 4 commits November 8, 2023 13:38

RBR should appear in LHN on failed split receipt scans

322e8d6

Merge branch 'main' into fix/29733

01e639f

Merge branch 'main' into fix/29733

7c184d3

update conditions

89a9cb1

dukenv0307 marked this pull request as ready for review November 14, 2023 06:16

dukenv0307 requested a review from a team as a code owner November 14, 2023 06:16

melvin-bot bot requested review from Ollyws and removed request for a team November 14, 2023 06:16

merge main

417f38a

merge main

e7484d2

merge main

273df2d

dukenv0307 added 2 commits November 30, 2023 11:48

fix prettier

a668cc9

fix jest

0de7ca9

Ollyws reviewed Nov 30, 2023

View reviewed changes

using onyx connect to get all transactions

d8b9f9e

rename all transactions variables

206dffe

Ollyws approved these changes Dec 5, 2023

View reviewed changes

melvin-bot bot requested a review from youssef-lr December 5, 2023 17:29

merge main

71626c6

youssef-lr reviewed Dec 6, 2023

View reviewed changes

rename function

e4e5b8f

youssef-lr approved these changes Dec 7, 2023

View reviewed changes

youssef-lr merged commit d3ea6ea into Expensify:main Dec 7, 2023

github-actions bot mentioned this pull request Dec 8, 2023

Deploy Checklist: New Expensify 2023-12-08 #32704

Closed

27 tasks

melvin-bot bot mentioned this pull request Dec 11, 2023

[HOLD for payment 2023-12-18] [$500] RBR polish on failed split receipt scans #29733

Closed

6 tasks

	function hasRequestError(reportActions: ReportAction[]) {
	function hasSmartscanError(reportActions: ReportAction[]) {

Conversation

dukenv0307 commented Nov 8, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot bot commented Nov 14, 2023

Uh oh!

dukenv0307 commented Nov 16, 2023

Uh oh!

Ollyws commented Nov 17, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

dukenv0307 commented Nov 20, 2023

Uh oh!

Ollyws commented Nov 20, 2023

Uh oh!

dukenv0307 commented Nov 24, 2023

Uh oh!

Ollyws commented Nov 27, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

trjExpensify commented Nov 29, 2023

Uh oh!

dukenv0307 commented Nov 30, 2023

Uh oh!

Ollyws Nov 30, 2023

Choose a reason for hiding this comment

Uh oh!

dukenv0307 Dec 4, 2023

Choose a reason for hiding this comment

Uh oh!

Ollyws commented Dec 4, 2023

Uh oh!

Ollyws commented Dec 5, 2023

Reviewer Checklist

Screenshots/Videos

Uh oh!

Ollyws left a comment

Choose a reason for hiding this comment

Uh oh!

trjExpensify commented Dec 6, 2023

Uh oh!

dukenv0307 commented Dec 6, 2023

Uh oh!

trjExpensify commented Dec 6, 2023

Uh oh!

youssef-lr commented Dec 6, 2023

Uh oh!

youssef-lr Dec 6, 2023

Choose a reason for hiding this comment

Uh oh!

dukenv0307 commented Dec 7, 2023

Uh oh!

OSBotify commented Dec 7, 2023

Uh oh!

OSBotify commented Dec 8, 2023

Uh oh!

OSBotify commented Dec 8, 2023

Uh oh!

OSBotify commented Dec 11, 2023

Uh oh!

OSBotify commented Dec 11, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

dukenv0307 commented Nov 8, 2023 •

edited

Loading

Ollyws commented Nov 17, 2023 •

edited

Loading

Ollyws commented Nov 27, 2023 •

edited

Loading