Add `DateTimeFormat` polyfills with timezone abbreviations by tienifr · Pull Request #31074 · Expensify/App

tienifr · 2023-11-08T17:58:32Z

Details

Add DateTimeFormat polyfills to support backward timezones and display them as modern, canonicalized timezone names. This PR adds support for timezone abbreviations which was not covered in #29113.

Fixed Issues

$ #27392
PROPOSAL: #27392 (comment)

Tests

How to change local timezone

MacOS

Chrome (or Chormium-based browsers) on MacOS Sonoma is failing to retrieve timezone. Reported issue here: https://support.google.com/chrome/thread/231926653/timezone-return-undefined. So if you're using Mac Sonoma, please use Safari for testing; or use other Mac OS versions.

Open Date & Time settings
Turn off Set time zone automatically using your current location
Under Closest city, choose the desired timezone

iOS

MacOS's timezone settings also applies to simulator. For physical device:

Open Settings >> General >> Date & Time
Turn off Set automatically
Under Timezone, choose the desired timezone

Android

Open Settings >> System >> Date & Time
Under Time zone, turn off Set automatically
Under Time zone, choose the desired region/timezone

Test steps

Automatic timezone detection requires app restart/refresh to take effects.

All platforms

Close app
Change local timezone to Kolkata - India
Open app
Go to Settings >> Profile >> Timezone
Turn on Automatically determine your location.
Verify the automatic timezone is Asia/Kolkata
Repeat step 1 to 6 with Hanoi - Vietnam city and verify Asia/Ho_Chi_Minh timezone
May test with other cities-timezones pairs here

More for iOS

Set account A's timezone to Asia/Ho_Chi_Minh on Web
Open app on iOS, already login with A, OR with any account that has chat with A before
Open any existing chat joined by A
Verify that app does not crash

Verify that no errors appear in the JS console

Offline tests

NA

QA Steps

Same as Tests

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

melvin-bot · 2023-12-11T10:06:14Z

@situchan Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

pecanoro · 2023-12-15T15:31:56Z

@situchan Don't forget to review this PR asap

tienifr · 2023-12-27T08:42:26Z

@situchan Still waiting for your review.

pecanoro · 2023-12-28T10:04:22Z

@situchan It's been 2 weeks, please review asap!

pecanoro · 2023-12-28T10:05:16Z

Auto-assigning the review so I can follow the progress and I can make sure it gets reviewed.

situchan · 2023-12-29T08:07:38Z

reviewing

situchan · 2023-12-29T08:14:07Z

src/libs/IntlPolyfill/polyfillDateTimeFormat.ts

+    let currentTimezone = timezone.automatic ? Intl.DateTimeFormat().resolvedOptions().timeZone : timezone.selected;
+    if (currentTimezone in tzLinks) {
+        currentTimezone = tzLinks[currentTimezone];
+    }


Can we reuse DateUtils.getCurrentTimezone() without connecting Onyx here unless it causes cyclic dependency?

situchan · 2024-01-03T12:23:32Z

Timezone is not updated automatically after turning on "Automatically determine your location"

web2-bug.mov

I think this can be out of scope as already happens on main

situchan · 2024-01-03T12:41:12Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

android.mov

Android: mWeb Chrome

mchrome.mov

iOS: Native

ios.mov

iOS: mWeb Safari

msafari.mov

MacOS: Chrome / Safari

web1.mov

MacOS: Desktop

desktop.mov

situchan · 2024-01-03T12:45:16Z

Performance tests are failing. It's random so let's see if success after pull main

tienifr · 2024-01-08T03:12:13Z

@pecanoro Please review.

pecanoro · 2024-01-08T09:28:58Z

Sorry @tienifr I was on vacation last week, I will review it today!!

pecanoro · 2024-01-08T12:50:28Z

src/libs/IntlPolyfill/polyfillDateTimeFormat.ts

+    PST8PDT: 'America/Los_Angeles',
+    WET: 'Europe/Lisbon',
+};
+/* eslint-disable @typescript-eslint/naming-convention */


Did you mean eslint-enable here?

@tienifr Friendly bump! Maybe I am missing something haha

You're right! I've updated.

OSBotify · 2024-01-09T14:24:12Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2024-01-10T06:20:23Z

🚀 Deployed to staging by https://github.com/pecanoro in version: 1.4.24-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2024-01-11T08:52:03Z

🚀 Deployed to production by https://github.com/thienlnam in version: 1.4.24-3 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

alitoshmatov · 2024-06-02T19:32:46Z

src/libs/IntlPolyfill/polyfillDateTimeFormat.ts

+        currentTimezone = tzLinks[currentTimezone];
+    }
+
+    require('@formatjs/intl-datetimeformat/polyfill-force');


@tienifr Can you address this comment: #34035 (comment)

I have replied on the other issue #34035 (comment)

fix for timezone abbreviations

a1021fd

tienifr mentioned this pull request Nov 8, 2023

[HOLD for payment 2024-01-18] [$250] Dev: IOS - App crashes when opening a transaction report #27392

Closed

6 tasks

tienifr added 4 commits November 9, 2023 00:59

remove console

4653beb

Merge branch 'main' of https://github.com/tienifr/App into fix/27392

edd9965

Merge branch 'main' of https://github.com/tienifr/App into fix/27392

3d3b41a

add timezone polyfills

aec6871

tienifr changed the title ~~fix for timezone abbreviations~~ Add DateTimeFormat polyfills Dec 11, 2023

tienifr changed the title ~~Add DateTimeFormat polyfills~~ Add DateTimeFormat polyfills with timezone abbreviations Dec 11, 2023

tienifr added 3 commits December 11, 2023 16:46

fix lint

78b0022

fix lint

1e6909a

fix lint

7300104

tienifr marked this pull request as ready for review December 11, 2023 10:06

tienifr requested a review from a team as a code owner December 11, 2023 10:06

melvin-bot bot requested review from situchan and removed request for a team December 11, 2023 10:06

Merge branch 'main' of https://github.com/tienifr/App into fix/27392

8658f99

pecanoro self-requested a review December 28, 2023 10:04

situchan reviewed Dec 29, 2023

View reviewed changes

tienifr added 2 commits January 3, 2024 16:25

Merge branch 'main' of https://github.com/tienifr/App into fix/27392

ba1a2d7

retrieve timezone from DateUtils

f9afabe

situchan approved these changes Jan 3, 2024

View reviewed changes

tienifr added 3 commits January 5, 2024 00:21

Merge branch 'main' of https://github.com/tienifr/App into fix/27392

2c52e0c

Merge branch 'main' of https://github.com/tienifr/App into fix/27392

d1feb9e

fix lint

5242683

pecanoro requested changes Jan 8, 2024

View reviewed changes

tienifr added 2 commits January 9, 2024 20:30

Merge branch 'main' into fix/27392

c597f1d

enable eslint

b207560

pecanoro approved these changes Jan 9, 2024

View reviewed changes

pecanoro merged commit e9f27ab into Expensify:main Jan 9, 2024

github-actions bot mentioned this pull request Jan 10, 2024

Deploy Checklist: New Expensify 2024-01-10 #34203

Closed

54 tasks

shubham1206agra mentioned this pull request Jan 10, 2024

Timezone - App detects incorrect timezone when automatic timezone is enabled #34247

Closed

6 tasks

jasperhuangg mentioned this pull request May 30, 2024

[HOLD for payment 2024-06-28] [$250] Timezone in the ND app is not updated after moving to another timezone location #34035

Closed

6 tasks

tienifr mentioned this pull request May 31, 2024

[C+ Checklist Needs Completion] [$500] Profile - Incorrect city name in automatic timezone selection #30468

Closed

6 tasks

alitoshmatov reviewed Jun 2, 2024

View reviewed changes

Conversation

tienifr commented Nov 8, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Details

Fixed Issues

Tests

How to change local timezone

MacOS

iOS

Android

Test steps

All platforms

More for iOS

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot bot commented Dec 11, 2023

Uh oh!

pecanoro commented Dec 15, 2023

Uh oh!

tienifr commented Dec 27, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

pecanoro commented Dec 28, 2023

Uh oh!

pecanoro commented Dec 28, 2023

Uh oh!

situchan commented Dec 29, 2023

Uh oh!

situchan Dec 29, 2023

Choose a reason for hiding this comment

Uh oh!

tienifr Jan 3, 2024

Choose a reason for hiding this comment

Uh oh!

situchan commented Jan 3, 2024

Uh oh!

situchan commented Jan 3, 2024

Reviewer Checklist

Screenshots/Videos

Uh oh!

situchan commented Jan 3, 2024

Uh oh!

tienifr commented Jan 8, 2024

Uh oh!

pecanoro commented Jan 8, 2024

Uh oh!

pecanoro Jan 8, 2024

Choose a reason for hiding this comment

Uh oh!

pecanoro Jan 9, 2024

Choose a reason for hiding this comment

Uh oh!

tienifr Jan 9, 2024

Choose a reason for hiding this comment

Uh oh!

OSBotify commented Jan 9, 2024

Uh oh!

OSBotify commented Jan 10, 2024

Uh oh!

OSBotify commented Jan 11, 2024

Uh oh!

alitoshmatov Jun 2, 2024

Choose a reason for hiding this comment

Uh oh!

tienifr Jun 4, 2024

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

tienifr commented Nov 8, 2023 •

edited

Loading

tienifr commented Dec 27, 2023 •

edited

Loading