feat: BankInfo step #31121

MrMuzyk · 2023-11-09T13:28:02Z

Details

Updated BankInfo step for VBBA

Fixed Issues

$ #30244
PROPOSAL:

Tests

Verify that no errors appear in the JS console
Enter adding bank account process for the workspace
Select manual/plaid and add account

Offline tests

QA Steps

Verify that no errors appear in the JS console
Enter adding bank account process for the workspace
Select manual/plaid and add account

PR Author Checklist

Screenshots/Videos

Android: Native

android.mp4

Android: mWeb Chrome

mweb.chrome.mp4

iOS: Native

ios.mp4

iOS: mWeb Safari

mweb.safari.mp4

MacOS: Chrome / Safari

web.mp4

MacOS: Desktop

desktop.mp4

ios/Podfile.lock

…ify/App into michal/bank-info-screen

src/pages/ReimbursementAccount/BankInfo/substeps/Manual.js

src/components/AddPlaidBankAccount.js

src/pages/ReimbursementAccount/BankInfo/substeps/Plaid.js

src/pages/ReimbursementAccount/BankInfo/BankInfo.js

src/pages/ReimbursementAccount/BankInfo/substeps/Plaid.js

src/pages/ReimbursementAccount/utils/getInitialSubstepForPersonalInfo.js

…ify/App into michal/bank-info-screen

melvin-bot · 2023-11-14T08:09:43Z

Hey! I see that you made changes to our Form component. Make sure to update the docs in FORMS.md accordingly. Cheers!

melvin-bot · 2023-11-14T08:12:51Z

@shubham1206agra Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

src/pages/ReimbursementAccount/utils/getSubstepValues.js

src/pages/ReimbursementAccount/utils/getInitialSubstepForBankInfo.js

shubham1206agra · 2023-11-16T13:14:04Z

@shubham1206agra Is there everything else ok?

Looks fine. We will do improvement if there's any.

MrMuzyk · 2023-11-16T13:29:13Z

Awesome. Any chance you can do the checklist today so we can merge it?

shubham1206agra · 2023-11-16T13:47:55Z

Screen.Recording.2023-11-16.at.5.25.01.PM.mov

@MrMuzyk Can you check this at the end?

MrMuzyk · 2023-11-16T13:54:05Z

@shubham1206agra What about it exactly?

shubham1206agra · 2023-11-16T14:00:26Z

After the plaid connection, it shows the landing page for a brief time.

MrMuzyk · 2023-11-16T14:09:09Z

After the plaid connection, it shows the landing page for a brief time.

It will not happen when this whole step will be on separate route. This is coming later on. Same case as back button

shubham1206agra · 2023-11-16T14:13:35Z

One minor thing the next button in the manual step is getting hidden behind the keyboard but not on native. Can you check this?

MrMuzyk · 2023-11-16T14:14:39Z

One minor thing the next button in the manual step is getting hidden behind the keyboard but not on native. Can you check this?

yes, checking

shubham1206agra · 2023-11-16T14:24:36Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

Screen.Recording.2023-11-14.at.8.39.59.PM.mov

Android: mWeb Chrome

Screen.Recording.2023-11-16.at.7.12.52.PM.mov

iOS: Native

Screen.Recording.2023-11-16.at.7.31.41.PM.mov

iOS: mWeb Safari

Screen.Recording.2023-11-16.at.5.25.01.PM.mov

MacOS: Chrome / Safari

Screen.Recording.2023-11-16.at.4.52.36.PM.mov

MacOS: Desktop

Screen.Recording.2023-11-16.at.7.19.48.PM.mov

MrMuzyk · 2023-11-16T14:58:05Z

I think it looks fine for me doesnt it?

shubham1206agra · 2023-11-16T15:08:57Z

I think it looks fine for me doesnt it?

It looks fine in this. But see video in my checklist for mWeb

mountiny · 2023-11-16T17:47:02Z

Let me know in slack if this will be ready to merge

…ify/App into michal/bank-info-screen

MrMuzyk · 2023-11-17T07:56:16Z

@shubham1206agra

Screen.Recording.2023-11-17.at.08.03.51.mov

Ive resolved the conflicts. For me it looks like this. Once user goes through the whole form and is on last field the the button is visible

shubham1206agra · 2023-11-17T07:58:23Z

Is it not related to this PR then?

MrMuzyk · 2023-11-17T08:15:51Z

@shubham1206agra
Im not sure what to do about it honestly. Im using regular components like in previous steps. Im looking at what is causing this but I have no clue tbh. Im not even sure if its undesired behaviour. Is it a blocker? The button is visible once user gets to last field and can submit

MrMuzyk · 2023-11-17T08:28:30Z

TS checks are failing because of new JS files. I guess we ignore that?

mountiny

Thanks lets keep going

mountiny · 2023-11-17T11:27:30Z

Thsi goes to a feature branch so failing ts check can be handled later

sobitneupane · 2024-05-07T09:52:55Z

#38920 regression was probably caused by the change in this PR.

allgandalf · 2024-07-01T14:40:40Z

src/pages/ReimbursementAccount/BankInfo/substeps/Manual.js

+    return (
+        <Form
+            formID={ONYXKEYS.REIMBURSEMENT_ACCOUNT}
+            onSubmit={onNext}


This update caused a regression #43135.

We should had handled the onSubmit in a function call and used useReimbursementAccountStepFormSubmit, this way we would had made sure that we trim the input number if there were any whitespaces involved

MrMuzyk commented Nov 9, 2023

View reviewed changes

ios/Podfile.lock Outdated Show resolved Hide resolved

MrMuzyk force-pushed the michal/bank-info-screen branch from d1a5c47 to 75fa77d Compare November 9, 2023 14:03

feat: BankInfo step

02f287e

MrMuzyk force-pushed the michal/bank-info-screen branch from 75fa77d to 02f287e Compare November 9, 2023 14:10

MrMuzyk added 2 commits November 9, 2023 15:11

Merge branch 'vit-tieredBankAccountFlow' of https://github.com/Expens…

88b7cee

…ify/App into michal/bank-info-screen

fix: remove console logs

a1348cb

gedu reviewed Nov 9, 2023

View reviewed changes

src/pages/ReimbursementAccount/BankInfo/substeps/Manual.js Show resolved Hide resolved