Fix: Two tags are highlighted at the same time #31475

tienifr · 2023-11-17T07:40:35Z

Details

When you disable any Tag in OldD in the IOU(NewD) details in the Tag section, two fields are highlighted instead of the one selected. This PR fixes that.

Fixed Issues

$ #30465
PROPOSAL: #30465 (comment)

Tests

Open OD with workspace's administration account
Enable Tag in the policy and add 7 tags
Open ND with workspace's member account
Create an IOU with Tag under that workspace
Open transaction details >> Open Tag
Verify the selected tag is highlighted
In OD, disable the selected Tag
In ND, select another tag (you may need to repeat this step several times)
Verify only the selected tag is highlighted
In OD, add 2 tags (so that total amount of enabled tags is 8)
In ND, search for tags
Verify the first tag is highlighted

Or use mock data here to avoid using OD.

Verify that no errors appear in the JS console

Offline tests

NA

QA Steps

Open OD with workspace's administration account
Enable Tag in the policy and add 7 tags
Open ND with workspace's member account
Create an IOU with Tag under that workspace
Open transaction details >> Open Tag
Verify the selected tag is highlighted
In OD, disable the selected Tag
In ND, select another tag (you may need to repeat this step several times)
Verify only the selected tag is highlighted
In OD, add 2 tags (so that total amount of enabled tags is 8)
In ND, search for tags
Verify the first tag is highlighted

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Screen.Recording.2023-11-17.at.15.38.47-compressed.mov

Android: mWeb Chrome

Screen.Recording.2023-11-17.at.15.45.52-compressed.mov

iOS: Native

Screen.Recording.2023-11-17.at.15.53.32-compressed.mov

iOS: mWeb Safari

Screen.Recording.2023-11-17.at.16.02.49-compressed.mov

MacOS: Chrome / Safari

https://github

.com/Expensify/App/assets/113963320/ded7c732-1743-4bcb-8d2d-1a2e84cb7128

MacOS: Desktop

Screen.Recording.2023-11-17.at.16.10.09-compressed.mov

melvin-bot · 2023-11-17T09:03:55Z

@alitoshmatov Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

alitoshmatov · 2023-11-20T18:33:31Z

src/components/CategoryPicker/index.js

            value={searchValue}
-            initialFocusedIndex={initialFocusedIndex}
+            focusedIndex={0}
+            initiallyFocusedOptionKey={lodashGet(_.filter(lodashGet(sections, '[0].data', []), (category) => category.searchText === selectedCategory)[0], 'keyForList')}


Can we extract the value to separate variable and add a comment explaining the logic for initially focused key, same in TagsPicker

alitoshmatov · 2023-11-22T15:51:50Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

tags-android.mov

Android: mWeb Chrome

tags-mweb.mov

iOS: Native

tags-ios.mp4

tags-ios1.mp4

iOS: mWeb Safari

tags-safari.mp4

MacOS: Chrome / Safari

tags-web.mov

MacOS: Desktop

tags-desktop.mov

alitoshmatov

LGTM!

OSBotify · 2023-11-23T00:19:36Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2023-11-23T17:11:09Z

🚀 Deployed to staging by https://github.com/tylerkaraszewski in version: 1.4.3-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	cancelled 🔪
🕸 web 🕸	success ✅

OSBotify · 2023-11-23T17:51:19Z

🚀 Deployed to staging by https://github.com/tylerkaraszewski in version: 1.4.3-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2023-11-27T19:05:15Z

🚀 Deployed to production by https://github.com/AndrewGable in version: 1.4.3-11 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

tienifr added 5 commits October 28, 2023 16:13

fix: 30465

e443317

Merge branch 'main' of https://github.com/tienifr/App into fix/30465

a1d912d

Merge branch 'main' of https://github.com/tienifr/App into fix/30465

eb0d064

fix: two tags highlighted at the same time

9b5d2e7

retrieve correct Onyx data

8793c8c

tienifr marked this pull request as ready for review November 17, 2023 09:03

tienifr requested a review from a team as a code owner November 17, 2023 09:03

melvin-bot bot requested review from alitoshmatov and removed request for a team November 17, 2023 09:03

tienifr mentioned this pull request Nov 17, 2023

[HOLD for payment 2023-12-04] [$500] [Wave 6: Tags] In the Tag list, two tags are highlighted at the same time #30465

Closed

6 tasks

Merge branch 'main' into fix/30465

1622d05

alitoshmatov reviewed Nov 20, 2023

View reviewed changes

tienifr added 2 commits November 22, 2023 00:22

Merge branch 'main' of https://github.com/tienifr/App into fix/30465

714440f

add comment and refector separate variable

faa9cd5

alitoshmatov approved these changes Nov 22, 2023

View reviewed changes

melvin-bot bot requested a review from tylerkaraszewski November 22, 2023 15:52

tylerkaraszewski approved these changes Nov 23, 2023

View reviewed changes

tylerkaraszewski merged commit ced40a1 into Expensify:main Nov 23, 2023

situchan mentioned this pull request Nov 23, 2023

Fix tagList highlight #31652

Closed

47 tasks

github-actions bot mentioned this pull request Nov 23, 2023

Deploy Checklist: New Expensify 2023-11-23 #31786

Closed

60 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix: Two tags are highlighted at the same time #31475

Fix: Two tags are highlighted at the same time #31475

Uh oh!

tienifr commented Nov 17, 2023 •

edited

Loading

Uh oh!

melvin-bot bot commented Nov 17, 2023

Uh oh!

alitoshmatov Nov 20, 2023

Uh oh!

tienifr Nov 21, 2023

Uh oh!

alitoshmatov commented Nov 22, 2023

Uh oh!

alitoshmatov left a comment

Uh oh!

OSBotify commented Nov 23, 2023

Uh oh!

OSBotify commented Nov 23, 2023

Uh oh!

OSBotify commented Nov 23, 2023

Uh oh!

OSBotify commented Nov 27, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Fix: Two tags are highlighted at the same time #31475

Fix: Two tags are highlighted at the same time #31475

Uh oh!

Conversation

tienifr commented Nov 17, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot bot commented Nov 17, 2023

Uh oh!

alitoshmatov Nov 20, 2023

Choose a reason for hiding this comment

Uh oh!

tienifr Nov 21, 2023

Choose a reason for hiding this comment

Uh oh!

alitoshmatov commented Nov 22, 2023

Reviewer Checklist

Screenshots/Videos

Uh oh!

alitoshmatov left a comment

Choose a reason for hiding this comment

Uh oh!

OSBotify commented Nov 23, 2023

Uh oh!

OSBotify commented Nov 23, 2023

Uh oh!

OSBotify commented Nov 23, 2023

Uh oh!

OSBotify commented Nov 27, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

tienifr commented Nov 17, 2023 •

edited

Loading