[CP Staging] Prevent infinite spinner in transition page by roryabraham · Pull Request #31522 · Expensify/App

roryabraham · 2023-11-19T17:44:21Z

Details

Fixed Issues

$ #31498

Tests

Sign into OldDot with public email
Ensure you are redirected to NewDot with this new account and you can see the Concierge chat

Sign into NewDot with UserA
Now go to OldDot and sign with some other UserB on public domain (like gmail)
Verify you have been redirected to NewDot
Verify you are signed in as UserA
Verify there was no not found page rendered or crash happened and you can correctly navigate through the app

Verify that no errors appear in the JS console

Offline tests

Same as tests

QA Steps

Same as tests

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

@allroundexperts @koko57 has been stresstesting this flow in the comments below

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

melvin-bot · 2023-11-19T17:44:55Z

@marcaaron Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

koko57 · 2023-11-20T10:52:58Z

Tired to test it locally:

for the logged out user - it works as expected

Screen.Recording.2023-11-20.at.11.35.45.mp4

for the logged in user (another account) - the user is redirected to sign in

Screen.Recording.2023-11-20.at.11.33.46.mp4

I've also tested this PR with the scenario I was working on a while ago: (#28984)

Log in to expensify.com with one of your accounts (account A).
Log in to the new app with another account (account B).
On expensify.com go to Support and choose Concierge.
A new tab will open, when a long URL with transition and token appear, quickly copy it. *
Open a new tab (or in a tab with the app running) paste the address and change 'https://new.expensify.com/' for 'https://dev.new.expensify:8082/' [or any port your app is running] *
Verify that user is properly logged in to the account A and the sidebar with chat and main screen are not empty.

I also tried the steps for the similar issue (with the Workspace chats)

Navigate to OldDot and sign in to a different account that has a existing workspace.
Go to Settings > Workspaces > Group and click on any "Chat with admins" button on the Workspace policy

For both scenarios I was logged in as the user transitioned from the OD but I had only one chat displayed and after a refresh I was logged out

Screen.Recording.2023-11-20.at.11.46.29.mp4

Screen.Recording.2023-11-20.at.11.11.53.mp4

mountiny · 2023-11-20T11:52:45Z

Thanks for the digging @koko57 and workin gon this one now, @allroundexperts is also going to help out now

allroundexperts · 2023-11-20T12:21:25Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

Screen.Recording.2023-11-20.at.9.28.32.PM.mov

MacOS: Desktop

allroundexperts · 2023-11-20T12:46:53Z

Update Testing well for the initial test case.

Screen.Recording.2023-11-20.at.5.40.27.PM.mov

Screen.Recording.2023-11-20.at.5.45.18.PM.mov

allroundexperts · 2023-11-20T12:54:45Z

Also, not sure if this should be handled in this PR, but I see the not found page for a small time when redirecting.

Screen.Recording.2023-11-20.at.5.53.09.PM.mov

mountiny · 2023-11-20T13:00:31Z

I think it looks alright, but ideally we fix that too in next iterations.

koko57 · 2023-11-20T13:51:36Z

Still digging - a few times while recreating the #28984 scenario I was logged out immediately after logging in as a new user - the proper chat appeared for a few seconds then I was redirected to signIn without refreshing

koko57 · 2023-11-20T14:32:46Z

@mountiny @allroundexperts @roryabraham still haven't found the exact root cause, but just discovered that adding !isLoggingInAsNewUser to the exitTo logic condition fixes the issue with #28984 scenario

Screen.Recording.2023-11-20.at.15.28.00.mp4

but still it's a fix to the fix, as Rory mentioned in the issue the login-logout flow should be simplified

allroundexperts · 2023-11-20T15:20:32Z

Does the redirect not work on mobile? I was trying to test this on mobile without any luck.

Screen.Recording.2023-11-20.at.8.18.49.PM.mov

mountiny · 2023-11-20T16:08:44Z

@allroundexperts oldDot mWeb flow should not redirect

I have pushed in the suggestion from Agata and fixed the lint. @allroundexperts could you please do a final review and checlist?

allroundexperts

Looks good!

melvin-bot · 2023-11-20T16:35:41Z

@cristipaval Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

luacmartins

LGTM

[CP Staging] Prevent infinite spinner in transition page (cherry picked from commit eeece25)

OSBotify · 2023-11-20T16:58:01Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2023-11-20T17:21:17Z

🚀 Cherry-picked to staging by https://github.com/luacmartins in version: 1.4.1-5 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes.

OSBotify · 2023-11-22T00:52:00Z

🚀 Deployed to production by https://github.com/luacmartins in version: 1.4.1-13 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

arosiclair · 2024-02-05T13:55:31Z

src/pages/LogOutPreviousUserPage.js

+                });
+            }
+        });
+    }, [props]);


Not really confirmed, but this might be the root cause of #33413. Let's try to be a little more careful with effect dependencies to avoid many unnecessary API calls 🙏

Prevent infinite spinner in transition page

ac14a1f

roryabraham requested a review from a team as a code owner November 19, 2023 17:44

melvin-bot bot requested review from marcaaron and removed request for a team November 19, 2023 17:44

roryabraham mentioned this pull request Nov 19, 2023

[HOLD for payment 2023-11-30] Chat not loading after redirection from OldDot #31498

Closed

6 tasks

mountiny requested a review from allroundexperts November 20, 2023 11:52

Add default props and additonal check for isLoggingInAsNewUser

cc06335

mountiny changed the title ~~[WIP] Prevent infinite spinner in transition page~~ [CP Staging] Prevent infinite spinner in transition page Nov 20, 2023

allroundexperts approved these changes Nov 20, 2023

View reviewed changes

melvin-bot bot requested a review from cristipaval November 20, 2023 16:35

luacmartins approved these changes Nov 20, 2023

View reviewed changes

mountiny merged commit eeece25 into main Nov 20, 2023

mountiny deleted the Rory-FixOldDotTransition branch November 20, 2023 16:54

OSBotify pushed a commit that referenced this pull request Nov 20, 2023

Merge pull request #31522 from Expensify/Rory-FixOldDotTransition

1c7dffe

[CP Staging] Prevent infinite spinner in transition page (cherry picked from commit eeece25)

os-botify bot mentioned this pull request Nov 20, 2023

Deploy Checklist: New Expensify 2023-11-20 #31556

Closed

90 tasks

kbecciv mentioned this pull request Nov 20, 2023

[$500] Web - User It is not redirected to New dot after logging in in Old dot #31595

Closed

6 tasks

marcaaron removed their request for review November 21, 2023 23:44

arosiclair reviewed Feb 5, 2024

View reviewed changes

arosiclair mentioned this pull request Feb 5, 2024

[HOLD for payment 2024-02-05] [$500] SignInWithShortLivedAuthToken sometimes gets called in a loop #33413

Closed

6 tasks

Conversation

roryabraham commented Nov 19, 2023 • edited by mountiny Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot bot commented Nov 19, 2023

Uh oh!

koko57 commented Nov 20, 2023

Uh oh!

mountiny commented Nov 20, 2023

Uh oh!

allroundexperts commented Nov 20, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

allroundexperts commented Nov 20, 2023

Uh oh!

allroundexperts commented Nov 20, 2023

Uh oh!

mountiny commented Nov 20, 2023

Uh oh!

koko57 commented Nov 20, 2023

Uh oh!

koko57 commented Nov 20, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

allroundexperts commented Nov 20, 2023

Uh oh!

mountiny commented Nov 20, 2023

Uh oh!

allroundexperts left a comment

Choose a reason for hiding this comment

Uh oh!

melvin-bot bot commented Nov 20, 2023

Uh oh!

luacmartins left a comment

Choose a reason for hiding this comment

Uh oh!

OSBotify commented Nov 20, 2023

Uh oh!

OSBotify commented Nov 20, 2023

Uh oh!

OSBotify commented Nov 22, 2023

Uh oh!

arosiclair Feb 5, 2024

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

roryabraham commented Nov 19, 2023 •

edited by mountiny

Loading

allroundexperts commented Nov 20, 2023 •

edited

Loading

koko57 commented Nov 20, 2023 •

edited

Loading