Allow split bill for hidden user by dukenv0307 · Pull Request #32166 · Expensify/App

dukenv0307 · 2023-11-29T08:52:40Z

Details

Since displayName doesn't return for new user who doesn't change default display name, we change the condition in confirm page to allow split bill with new user.

Fixed Issues

$ #31792
PROPOSAL: #31792 (comment)

Tests

Create a group chat with new user
In composer, click on plus icon > split bill
Enter any amount and go to next step
Verify that hidden users appear and when clicking on confirm button, split bill is created sucessfully.

Verify that no errors appear in the JS console

Offline tests

Same as above

QA Steps

Create a group chat with new user
In composer, click on plus icon > split bill
Enter any amount and go to next step
Verify that hidden users appear and when clicking on confirm button, split bill is created sucessfully.

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Screen.Recording.2023-11-29.at.15.34.56.mov

Android: mWeb Chrome

Screen.Recording.2023-11-29.at.15.31.00.mov

iOS: Native

Screen.Recording.2023-11-29.at.15.37.40.mov

iOS: mWeb Safari

Screen.Recording.2023-11-29.at.15.28.03.mov

MacOS: Chrome / Safari

Screen.Recording.2023-11-29.at.15.26.11.mov

MacOS: Desktop

Screen.Recording.2023-11-29.at.15.43.52.mov

melvin-bot · 2023-11-29T08:52:59Z

@s77rt Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

s77rt · 2023-11-29T13:29:53Z

src/pages/iou/steps/MoneyRequestConfirmPage.js

                    const isPolicyExpenseChat = lodashGet(participant, 'isPolicyExpenseChat', false);
                    return isPolicyExpenseChat ? OptionsListUtils.getPolicyExpenseReportOption(participant) : OptionsListUtils.getParticipantsOption(participant, props.personalDetails);
                })
-                .filter((participant) => !!participant.login || !!participant.text)


Remove the _.chain and _.value. We only need _.map here

@s77rt I updated.

s77rt · 2023-11-29T14:12:15Z

Bug: On Native the participant name is not visible

Screen.Recording.2023-11-29.at.3.09.33.PM.mov

dukenv0307 · 2023-11-29T15:35:19Z

@s77rt Updated.

luacmartins

Code LGTM!

s77rt · 2023-11-29T17:18:21Z

src/libs/OptionsListUtils.js

 function getIOUConfirmationOptionsFromParticipants(participants, amountText) {
    return _.map(participants, (participant) => ({
        ...participant,
+        text: participant.text || Localize.translateLocal('common.hidden'),


Why this seems to be only needed for Native?

@s77rt Because in native DisplayNames component render the text which is fullTitle here. On other platforms, we use displayNamesWithTooltips props which already set Hidden for displayName field in getDisplayNameForParticipant function

App/src/components/OptionRow.js

Line 115 in a0b2197

const fullTitle = props.isMultilineSupported ? text.trimStart() : text;

App/src/components/OptionRow.js

Line 221 in a0b2197

<DisplayNames

App/src/components/DisplayNames/index.native.tsx

Line 13 in a0b2197

{fullTitle}

Ah I see. But the suggested solution does not fix the bug. I think the DisplayNames component on itself is inconsistent as the shouldUseFullTitle prop is only available on non-native.

Do you have any suggestions? I think we only have the bug for the participant case so we can fix this in getIOUConfirmationOptionsFromParticipants function.

What do you think about add Hidden as default value here.

App/src/components/OptionRow.js

Line 114 in a0b2197

const text = lodashGet(props.option, 'text', '');

Can we add the Hidden as a default in DisplayNames instead? I think that would make more sense

So we will add Hidden as default in native DisplayNames right?

Yes, that seems safer as OptionRow is a generic component where Hidden may not be wanted

@s77rt Updated.

s77rt · 2023-11-30T12:14:19Z

src/components/DisplayNames/index.native.tsx

            numberOfLines={numberOfLines}
        >
-            {fullTitle}
+            {fullTitle || translate('common.hidden')}


For consistency please add the same to index.tsx

@s77rt Updated.

s77rt · 2023-11-30T13:09:01Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

mweb-chrome.mov

iOS: Native

iOS: mWeb Safari

mweb-safari.mov

MacOS: Chrome / Safari

web.mov

MacOS: Desktop

desktop.mov

luacmartins · 2023-11-30T18:02:12Z

@dukenv0307 we have conflicts

dukenv0307 · 2023-11-30T18:07:00Z

@luacmartins Updated.

OSBotify · 2023-11-30T18:17:31Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2023-12-01T12:57:25Z

🚀 Deployed to staging by https://github.com/luacmartins in version: 1.4.7-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2023-12-05T02:27:48Z

🚀 Deployed to production by https://github.com/yuwenmemon in version: 1.4.7-4 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	failure ❌
🕸 web 🕸	success ✅

Allow split bill for hidden user

0a0f592

dukenv0307 marked this pull request as ready for review November 29, 2023 08:52

dukenv0307 requested a review from a team as a code owner November 29, 2023 08:52

melvin-bot bot requested review from s77rt and removed request for a team November 29, 2023 08:52

s77rt suggested changes Nov 29, 2023

View reviewed changes

remove un-use function

cd5fa9c

update hidden for native

f109a3c

luacmartins self-requested a review November 29, 2023 16:04

luacmartins previously approved these changes Nov 29, 2023

View reviewed changes

s77rt suggested changes Nov 29, 2023

View reviewed changes

dukenv0307 added 2 commits November 30, 2023 18:33

Merge branch 'main' into fix/31792

52efc96

add hidden for display name native component

2aafb7a

dukenv0307 dismissed luacmartins’s stale review via 2aafb7a November 30, 2023 11:58

s77rt suggested changes Nov 30, 2023

View reviewed changes

dukenv0307 added 2 commits November 30, 2023 19:24

add title for display name web component

bab320b

fix lint

4ecea54

s77rt approved these changes Nov 30, 2023

View reviewed changes

melvin-bot bot requested a review from luacmartins November 30, 2023 13:09

luacmartins previously approved these changes Nov 30, 2023

View reviewed changes

dukenv0307 added 2 commits December 1, 2023 01:04

Merge branch 'main' into fix/31792

61bc06b

merge main

e875e3c

dukenv0307 dismissed luacmartins’s stale review via e875e3c November 30, 2023 18:06

fix lint

0a457f4

luacmartins approved these changes Nov 30, 2023

View reviewed changes

luacmartins merged commit a6eb7f9 into Expensify:main Nov 30, 2023

github-actions bot mentioned this pull request Dec 1, 2023

Deploy Checklist: New Expensify 2023-12-01 #32342

Closed

53 tasks

melvin-bot bot mentioned this pull request Dec 5, 2023

[HOLD for payment 2023-12-12] [$500] IOU - Unable to create IOU with "Hidden" users #31792

Closed

6 tasks

situchan mentioned this pull request Dec 15, 2023

[HOLD for payment 2023-12-28] [HOLD for payment 2023-12-26] [$500] Web - IOU – Unable to create IOU with non-existing user via 1:1 conversation #33151

Closed

6 tasks

bernhardoj mentioned this pull request Dec 22, 2023

[LOW] [Splits] [$500] Request – Unable to Request money twice to the same user you have no conversation with. #33487

Closed

6 tasks

allroundexperts mentioned this pull request Jan 3, 2024

Refactor the money request creation flow #28618

Merged

58 tasks

Conversation

dukenv0307 commented Nov 29, 2023

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot bot commented Nov 29, 2023

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

s77rt commented Nov 29, 2023

Uh oh!

dukenv0307 commented Nov 29, 2023

Uh oh!

luacmartins left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

dukenv0307 Nov 29, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

dukenv0307 Nov 30, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

s77rt commented Nov 30, 2023

Reviewer Checklist

Screenshots/Videos

Uh oh!

luacmartins commented Nov 30, 2023

Uh oh!

dukenv0307 commented Nov 30, 2023

Uh oh!

OSBotify commented Nov 30, 2023

Uh oh!

OSBotify commented Dec 1, 2023

Uh oh!

OSBotify commented Dec 5, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

dukenv0307 Nov 29, 2023 •

edited

Loading

dukenv0307 Nov 30, 2023 •

edited

Loading