[Form Provider Refactor] IdologyQuestions fixes by kowczarz · Pull Request #32196 · Expensify/App

kowczarz · 2023-11-29T16:30:32Z

Details

Fixed Issues

$ #30313
$ #32104

Tests

Login with expensify account
Go to Settings > Wallet > Enable Wallet
Go through plaid verification flow
Follow the flow until Additional details
Fill the form with following data: First name: Alberta Last name: Bobbeth SSN: 3333 Any other information for the rest of the fields
Press Save & continue
Idology questions should appear
Hit back button
Additional details should be filled with draft values
Press Save & continue
Don't fill anything and press Save & continue -> Errors should appear
Select any response -> Tap on "Save & continue"
Don't fill anything for second question and press Save & continue
Select any response -> Tap on "Save & continue"
You should be able to proceed to the next question and fill rest of the questions

Verify that no errors appear in the JS console

Offline tests

Same as above

QA Steps

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

android.native_H.265.mp4

Android: mWeb Chrome

android.web_H.265.mp4

iOS: Native

ios.native_H.265.mp4

iOS: mWeb Safari

ios.web_H.265.mp4

MacOS: Chrome / Safari

web_H.265.mp4

MacOS: Desktop

desktop_H.265.mp4

This reverts commit 8996772.

…2 & next idology question

melvin-bot · 2023-11-29T16:30:37Z

Hey! I see that you made changes to our Form component. Make sure to update the docs in FORMS.md accordingly. Cheers!

melvin-bot · 2023-11-29T16:34:07Z

@s77rt Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

kowczarz · 2023-11-29T16:35:41Z

Cc. @luacmartins

kowczarz · 2023-11-29T16:37:18Z

src/pages/EnablePayments/IdologyQuestions.js

+            <FormProvider
+                formID={ONYXKEYS.WALLET_ADDITIONAL_DETAILS}
+                onSubmit={submitAnswers}
+                key={currentQuestionIndex}


Here is the fix of the issue that the form doesn't re-render properly reported in #32104 rest of the code is identical as in #31401

s77rt · 2023-11-29T16:43:46Z

Can you remove #31612 from the fixed issues list

s77rt · 2023-11-29T16:57:38Z

Just to be sure we are not missing anything, this does not fix #32083. That issue does not even seem to be a regression from the v1 PR

luacmartins · 2023-11-29T17:00:32Z

@s77rt agreed. TBH I think that's the expected behavior. We just display a "warning the first time, but tapping save&continue should work the 2nd time.

s77rt · 2023-11-29T17:15:34Z

I confirm this fixed the regression.

s77rt · 2023-11-29T17:16:31Z

In step 14

Don't fill anything for second question and press Save & continue

Please clarify that an error should appear

Edit: I will go ahead and approve the PR since this is not a blocker

s77rt · 2023-11-29T18:02:35Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

OSBotify · 2023-11-29T18:10:46Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2023-12-01T12:45:05Z

🚀 Deployed to production by https://github.com/mountiny in version: 1.4.6-2 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

kowczarz added 2 commits November 29, 2023 15:24

Revert "Revert "[Form Provider Refactor] IdologyQuestions""

4fed72e

This reverts commit 8996772.

Fix no error message if press Save&Continue without fill anything in …

92fcded

…2 & next idology question

kowczarz marked this pull request as ready for review November 29, 2023 16:34

kowczarz requested a review from a team as a code owner November 29, 2023 16:34

melvin-bot bot requested review from s77rt and removed request for a team November 29, 2023 16:34

kowczarz commented Nov 29, 2023

View reviewed changes

luacmartins self-requested a review November 29, 2023 16:50

s77rt approved these changes Nov 29, 2023

View reviewed changes

luacmartins approved these changes Nov 29, 2023

View reviewed changes

luacmartins merged commit ee92da0 into Expensify:main Nov 29, 2023

github-actions bot mentioned this pull request Nov 30, 2023

Deploy Checklist: New Expensify 2023-11-30 #32266

Closed

42 tasks

fedirjh mentioned this pull request Dec 6, 2023

[HOLD for payment 2024-01-26] [$500] Wallet - Fix the errors button is non-functional in Additional details #32520

Closed

6 tasks

roryabraham mentioned this pull request Jan 23, 2024

Mandatory exit survey for users going back to OldDot #34925

Merged

50 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Form Provider Refactor] IdologyQuestions fixes#32196

[Form Provider Refactor] IdologyQuestions fixes#32196
luacmartins merged 2 commits intoExpensify:mainfrom
software-mansion-labs:form-migration/idology-questions-fix

kowczarz commented Nov 29, 2023 •

edited

Loading

Uh oh!

melvin-bot bot commented Nov 29, 2023

Uh oh!

melvin-bot bot commented Nov 29, 2023

Uh oh!

kowczarz commented Nov 29, 2023

Uh oh!

kowczarz Nov 29, 2023 •

edited

Loading

Uh oh!

s77rt commented Nov 29, 2023

Uh oh!

s77rt commented Nov 29, 2023

Uh oh!

luacmartins commented Nov 29, 2023

Uh oh!

s77rt commented Nov 29, 2023

Uh oh!

s77rt commented Nov 29, 2023 •

edited

Loading

Uh oh!

s77rt commented Nov 29, 2023

Uh oh!

OSBotify commented Nov 29, 2023

Uh oh!

OSBotify commented Dec 1, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Conversation

kowczarz commented Nov 29, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot bot commented Nov 29, 2023

Uh oh!

melvin-bot bot commented Nov 29, 2023

Uh oh!

kowczarz commented Nov 29, 2023

Uh oh!

kowczarz Nov 29, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

s77rt commented Nov 29, 2023

Uh oh!

s77rt commented Nov 29, 2023

Uh oh!

luacmartins commented Nov 29, 2023

Uh oh!

s77rt commented Nov 29, 2023

Uh oh!

s77rt commented Nov 29, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

s77rt commented Nov 29, 2023

Reviewer Checklist

Screenshots/Videos

Uh oh!

OSBotify commented Nov 29, 2023

Uh oh!

OSBotify commented Dec 1, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

kowczarz commented Nov 29, 2023 •

edited

Loading

kowczarz Nov 29, 2023 •

edited

Loading

s77rt commented Nov 29, 2023 •

edited

Loading