fix: hide pending deleted actions by dummy-1111 · Pull Request #32474 · Expensify/App

dummy-1111 · 2023-12-05T13:00:32Z

Details

Hide the delete pending actions

Fixed Issues

$ #31637
PROPOSAL: #30485 (comment)

Tests

Open ND and log in with any account
Go to any chat
Send a message and mark the message unread
Deleted the last message
Verify that "New" marker disappears immediately
Switch to offline mode
Send a message and mark that unread
Delete the last message
Switch to online
Verify that "New" marker disappears immediately

Verify that no errors appear in the JS console

Offline tests

Open ND and log in with any account
Go to any chat
Send a message and mark the message unread
Deleted the last message
Verify that "New" marker disappears immediately

QA Steps

Open ND and log in with any account
Go to any chat
Send a message and mark the message unread
Deleted the last message
Verify that "New" marker disappears immediately
Switch to offline mode
Send a message and mark that unread
Delete the last message
Switch to online
Verify that "New" marker disappears immediately

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

31637_android_native.mp4

Android: mWeb Chrome

31637_android_chrome.mp4

iOS: Native

31637_ios_native.mp4

iOS: mWeb Safari

31637_ios_safari.mp4

MacOS: Chrome / Safari

31637_mac_chrome.mp4

MacOS: Desktop

31637_mac_desktop.mp4

…ine mode

melvin-bot · 2023-12-05T13:45:03Z

@ArekChr Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

ArekChr · 2023-12-06T10:32:16Z

@s-alves10 A similar issue happens when removing a message in offline mode and then going online; the difference is that the green marker never disappears. Please fix that, thanks!

Details in the video below:

Nagranie.z.ekranu.2023-12-6.o.11.28.35.mov

dummy-1111 · 2023-12-06T22:18:51Z

@ArekChr

The root cause of the issue mentioned in #32474 (comment) is that report actions are not filtered again when network offline status changes.

I updated the solution and the PR description(test steps, videos)

ArekChr · 2023-12-07T10:14:57Z

@s-alves10 I'm having some desktop build & run issues. Please update with the latest main

dummy-1111 · 2023-12-07T10:48:25Z

@ArekChr

I merged the PR with the latest main. Please check

ArekChr · 2023-12-07T11:19:59Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

android.mov

Android: mWeb Chrome

android.chrome.mov

iOS: Native

ios.mov

iOS: mWeb Safari

ios.safari.mov

MacOS: Chrome / Safari

web.mov

MacOS: Desktop

desktop.mov

ArekChr

All works! Thanks for PR

MonilBhavsar · 2023-12-07T12:08:12Z

src/pages/home/ReportScreen.js

    const screenWrapperStyle = [styles.appContent, styles.flex1, {marginTop: viewportOffsetTop}];

+    // eslint-disable-next-line react-hooks/exhaustive-deps -- need to re-filter the report actions when network status changes
+    const filteredReportActions = useMemo(() => _.filter(reportActions, (action) => ReportActionsUtils.shouldReportActionBeVisible(action)), [isOffline, reportActions]);


I think iterating over report actions is going to be responsible for performance?

@MonilBhavsar

Yes, it may be. We can remove the selector function from the onyx connector here and call getSortedReportActionsForDisplay inside the useMemo.

What do you think?

cc @ArekChr

Will you check again @MonilBhavsar ?

MonilBhavsar · 2023-12-13T07:14:49Z

Looks good! @ArekChr if you could also please take a look

ArekChr

LGTM, retested and all works

MonilBhavsar

Thanks!

OSBotify · 2023-12-13T16:20:37Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2023-12-14T16:05:43Z

🚀 Deployed to staging by https://github.com/MonilBhavsar in version: 1.4.13-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	failure ❌
🕸 web 🕸	success ✅

OSBotify · 2023-12-14T16:45:31Z

🚀 Deployed to staging by https://github.com/MonilBhavsar in version: 1.4.13-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2023-12-19T02:01:49Z

🚀 Deployed to production by https://github.com/jasperhuangg in version: 1.4.13-8 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

sangar-1028 added 2 commits December 5, 2023 06:23

fix: hide pending deleted actions

e6ec283

fix: update test case - we're hiding pending deleted ccomments in onl…

e111654

…ine mode

dummy-1111 mentioned this pull request Dec 5, 2023

[HOLD for payment 2024-01-17] [$500] Threads - When deleting the last unread message, the "New" marker appears for a second #31637

Closed

6 tasks

dummy-1111 marked this pull request as ready for review December 5, 2023 13:44

dummy-1111 requested a review from a team as a code owner December 5, 2023 13:44

melvin-bot bot requested review from ArekChr and removed request for a team December 5, 2023 13:45

sangar-1028 added 4 commits December 6, 2023 05:24

Merge branch 'main' into fix/issue-31637

762b11f

fix: filter the report actions when network status changes

9c2ecb4

Merge branch 'main' into fix/issue-31637

02483c2

Merge branch 'main' into fix/issue-31637

e17a223

Merge branch 'main' into fix/issue-31637

3624b40

ArekChr approved these changes Dec 7, 2023

View reviewed changes

melvin-bot bot requested a review from MonilBhavsar December 7, 2023 11:21

MonilBhavsar reviewed Dec 7, 2023

View reviewed changes

sangar-1028 added 2 commits December 7, 2023 10:06

fix: filter report actions when network offline status changes as well

6babf69

Merge branch 'main' into fix/issue-31637

22eca2a

ArekChr approved these changes Dec 13, 2023

View reviewed changes

melvin-bot bot requested a review from MonilBhavsar December 13, 2023 09:48

MonilBhavsar approved these changes Dec 13, 2023

View reviewed changes

MonilBhavsar merged commit 57cd25a into Expensify:main Dec 13, 2023

github-actions bot mentioned this pull request Dec 14, 2023

Deploy Checklist: New Expensify 2023-12-14 #33072

Closed

77 tasks

This was referenced Dec 14, 2023

Revert "fix: hide pending deleted actions" #33133

Closed

[HOLD for payment 2024-01-17] Web – Chat – Edit mode doesn’t open when Press ArrowUp in DM if delete message using keyboard #33118

Closed

situchan mentioned this pull request Jan 4, 2024

fix: hide new marker for pending deleted action in online mode #33162

Merged

50 tasks

Conversation

dummy-1111 commented Dec 5, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot bot commented Dec 5, 2023

Uh oh!

ArekChr commented Dec 6, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

dummy-1111 commented Dec 6, 2023

Uh oh!

ArekChr commented Dec 7, 2023

Uh oh!

dummy-1111 commented Dec 7, 2023

Uh oh!

ArekChr commented Dec 7, 2023

Reviewer Checklist

Screenshots/Videos

Uh oh!

ArekChr left a comment

Choose a reason for hiding this comment

Uh oh!

MonilBhavsar Dec 7, 2023

Choose a reason for hiding this comment

Uh oh!

dummy-1111 Dec 7, 2023

Choose a reason for hiding this comment

Uh oh!

dummy-1111 Dec 7, 2023

Choose a reason for hiding this comment

Uh oh!

MonilBhavsar commented Dec 13, 2023

Uh oh!

ArekChr left a comment

Choose a reason for hiding this comment

Uh oh!

MonilBhavsar left a comment

Choose a reason for hiding this comment

Uh oh!

OSBotify commented Dec 13, 2023

Uh oh!

OSBotify commented Dec 14, 2023

Uh oh!

OSBotify commented Dec 14, 2023

Uh oh!

OSBotify commented Dec 19, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

dummy-1111 commented Dec 5, 2023 •

edited

Loading

ArekChr commented Dec 6, 2023 •

edited

Loading