Replace categories changelog by rlinoz · Pull Request #33253 · Expensify/App

rlinoz · 2023-12-18T19:43:08Z

Details

Fixed Issues

$ https://github.com/Expensify/Expensify/issues/316104

Tests

In OldDot have a workspace with Quickbooks/Xero integration setup
Go to Workspace -> Categories
Edited GL Code of a category
Run the sync with the integration
Open NewDot #admins room and see that a changelog was sent for the synchronization as well as for the other changes.

Verify that no errors appear in the JS console

Offline tests

N/A

QA Steps

This can only be tested in staging until Web-E gets deployed in production.

In OldDot have a Collect workspace that has chat rooms enabled
Create the integration with Quickbooks or Xero
1. Open the workspace settings and go to Connections
2. Select QuickBooks or Xero
3. When prompted use QBO QA Account or Xero QA Account from 1password
4. Wait for the sync to finish
Click on Sync now
Go to Workspace -> Categories
See that the categories got updated with the integration
Open NewDot #admins room and see that a changelog was sent for the synchronization as well as for any other change that you made.

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Details

…ories-changelog

melvin-bot · 2023-12-18T20:10:58Z

@cubuspl42 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

melvin-bot · 2023-12-18T20:24:59Z

@fedirjh Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

jakub-trzebiatowski · 2023-12-19T10:24:36Z

src/CONST.ts

                    INDIVIDUAL_BUDGET_NOTIFICATION: 'POLICYCHANGELOG_INDIVIDUAL_BUDGET_NOTIFICATION',
                    INVITE_TO_ROOM: 'POLICYCHANGELOG_INVITETOROOM',
                    REMOVE_FROM_ROOM: 'POLICYCHANGELOG_REMOVEFROMROOM',
+                    REPLACE_CATEGORIES: 'POLICYCHANGELOG_REPLACE_CATEGORIES',


Does this constant have any uses?

It is used here with the spread operator, if this constant is not here this action type is not shown in the chat.

App/src/pages/home/report/ReportActionItem.js

Line 445 in aa1d87c

..._.values(CONST.REPORT.ACTIONS.TYPE.POLICYCHANGELOG),

Oh, it's tricky. So we never refer to it TypeScript-wise. Thank you for clarification!

jakub-trzebiatowski · 2023-12-19T10:26:47Z

I've seen you pullerbear'ed twice, I'm not sure if this was on purpose or by accident. I can handle testing this one, I have the capacity for it.

rlinoz · 2023-12-19T13:30:19Z

It was by accident

jakub-trzebiatowski · 2023-12-20T11:43:35Z

I'll get to testing, the single line looks good as now I understand it! 😃

jakub-trzebiatowski · 2023-12-20T13:23:59Z

@rlinoz

In OldDot have a workspace with Quickbooks/Xero integration setup

I tried creating such a workspace, but I don't think it's currently possible to create new workspaces without being redirected to NewDot.

Would it be possible to invite me to such a workspace?

E-mail: cubuspl42.1+5@gmail.com

rlinoz · 2023-12-20T15:20:55Z

Now that I am thinking, I don't have access to such a workspace in staging/prod either.

I think only applause and internal engineering will be able to test this.

jakub-trzebiatowski · 2023-12-21T11:38:37Z

@rlinoz

I think only applause and internal engineering will be able to test this.

I pasted a filled checklist to satisfy the check, although no actual testing was done

jakub-trzebiatowski · 2023-12-21T11:39:46Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

melvin-bot · 2023-12-21T11:42:24Z

@blimpich Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

melvin-bot · 2023-12-21T11:42:28Z

🎯 @cubuspl42, thanks for reviewing and testing this PR! 🎉

An E/App issue has been created to issue payment here: #33409.

blimpich · 2023-12-22T19:36:14Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

n/a

Android: mWeb Chrome

n/a

iOS: Native

n/a

iOS: mWeb Safari

n/a

MacOS: Chrome / Safari

MacOS: Desktop

n/a

blimpich · 2023-12-22T22:01:58Z

@rlinoz Can you make the QA steps more verbose? I have the integration server running locally but it isn't clear to me how to setup a Xero or QBO connection locally. What steps did you follow?

rlinoz · 2023-12-26T20:31:04Z

@blimpich I updated the steps, if you have the IS server running they should work.

Let me know if I can help with anything.

blimpich · 2023-12-27T01:29:26Z

I needed to turn off Zero Trust 🤦‍♂️. Kept getting 500 error when I was trying to connect to QBO. Checklist ✅

blimpich

LGTM

blimpich · 2023-12-27T01:38:05Z

@rlinoz I can't merge it because of the author PR checklist failure here. Not sure if anything changed their recently and now has to be updated in this PR.

jakub-trzebiatowski · 2023-12-27T09:51:03Z

There were changes to the checklists recently

rlinoz · 2023-12-27T12:45:38Z

Thanks!

OSBotify · 2023-12-27T12:49:46Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2023-12-28T21:19:24Z

🚀 Deployed to production by https://github.com/mountiny in version: 1.4.18-8 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	failure ❌
🕸 web 🕸	success ✅

rlinoz added 3 commits December 12, 2023 20:49

adding new policy changelog

c01d620

Merge remote-tracking branch 'origin/main' into rodrigo-replace-categ…

37f0e08

…ories-changelog

Merge remote-tracking branch 'origin/main' into rodrigo-replace-categ…

7d748aa

…ories-changelog

rlinoz self-assigned this Dec 18, 2023

rlinoz marked this pull request as ready for review December 18, 2023 20:10

rlinoz requested a review from a team as a code owner December 18, 2023 20:10

melvin-bot bot requested review from jakub-trzebiatowski and removed request for a team December 18, 2023 20:10

rlinoz requested review from a team and removed request for jakub-trzebiatowski December 18, 2023 20:11

melvin-bot bot requested review from fedirjh and removed request for a team December 18, 2023 20:24

jakub-trzebiatowski reviewed Dec 19, 2023

View reviewed changes

rlinoz changed the title ~~Rodrigo replace categories changelog~~ Replace categories changelog Dec 20, 2023

jakub-trzebiatowski approved these changes Dec 21, 2023

View reviewed changes

melvin-bot bot requested a review from blimpich December 21, 2023 11:42

melvin-bot bot mentioned this pull request Dec 21, 2023

Payment issue for E/App PR#33253 #33409

Closed

blimpich approved these changes Dec 27, 2023

View reviewed changes

rlinoz merged commit 4a0fb97 into main Dec 27, 2023

rlinoz deleted the rodrigo-replace-categories-changelog branch December 27, 2023 12:45

github-actions bot mentioned this pull request Dec 27, 2023

Deploy Checklist: New Expensify 2023-12-27 #33644

Closed

41 tasks

Conversation

rlinoz commented Dec 18, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot bot commented Dec 18, 2023

Uh oh!

melvin-bot bot commented Dec 18, 2023

Uh oh!

jakub-trzebiatowski Dec 19, 2023

Choose a reason for hiding this comment

Uh oh!

rlinoz Dec 19, 2023

Choose a reason for hiding this comment

Uh oh!

jakub-trzebiatowski Dec 20, 2023

Choose a reason for hiding this comment

Uh oh!

jakub-trzebiatowski commented Dec 19, 2023

Uh oh!

rlinoz commented Dec 19, 2023

Uh oh!

jakub-trzebiatowski commented Dec 20, 2023

Uh oh!

jakub-trzebiatowski commented Dec 20, 2023

Uh oh!

rlinoz commented Dec 20, 2023

Uh oh!

jakub-trzebiatowski commented Dec 21, 2023

Uh oh!

jakub-trzebiatowski commented Dec 21, 2023

Reviewer Checklist

Screenshots/Videos

Uh oh!

melvin-bot bot commented Dec 21, 2023

Uh oh!

melvin-bot bot commented Dec 21, 2023

Uh oh!

blimpich commented Dec 22, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

blimpich commented Dec 22, 2023

Uh oh!

rlinoz commented Dec 26, 2023

Uh oh!

blimpich commented Dec 27, 2023

Uh oh!

blimpich left a comment

Choose a reason for hiding this comment

Uh oh!

blimpich commented Dec 27, 2023

Uh oh!

jakub-trzebiatowski commented Dec 27, 2023

Uh oh!

rlinoz commented Dec 27, 2023

Uh oh!

OSBotify commented Dec 27, 2023

Uh oh!

OSBotify commented Dec 28, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

rlinoz commented Dec 18, 2023 •

edited

Loading

blimpich commented Dec 22, 2023 •

edited

Loading