[NoQA] Add a README file to the perf tests#33400
Merged
mountiny merged 4 commits intoExpensify:mainfrom Dec 27, 2023
Merged
Conversation
koko57
reviewed
Dec 21, 2023
koko57
reviewed
Dec 21, 2023
koko57
reviewed
Dec 21, 2023
rezkiy37
reviewed
Dec 21, 2023
bd5251e to
010bcb9
Compare
fabioh8010
reviewed
Dec 22, 2023
010bcb9 to
3fdf464
Compare
fabioh8010
approved these changes
Dec 22, 2023
|
@hoangzinh Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
Contributor
Author
|
Hey @mountiny , PR is ready for review. |
Contributor
|
@mountiny, let me know if you need me (as a C+) review this PR. |
34 tasks
Contributor
|
@hoangzinh no need, thanks! |
Contributor
Reviewer Checklist
Screenshots/VideosAndroid: NativeAndroid: mWeb ChromeiOS: NativeiOS: mWeb SafariMacOS: Chrome / SafariMacOS: Desktop |
mountiny
requested changes
Dec 26, 2023
Contributor
mountiny
left a comment
There was a problem hiding this comment.
Thanks! One change requested
Contributor
|
@mountiny done! |
Contributor
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
41 tasks
Contributor
|
🚀 Deployed to production by https://github.com/mountiny in version: 1.4.18-8 🚀
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Details
This PR introduces instruction and tips for adding a performance test using Reassure
Fixed Issues
$ #33229
PROPOSAL:
Tests
Offline tests
QA Steps
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectiontoggleReportand notonIconClick)myBool && <MyComponent />.src/languages/*files and using the translation methodWaiting for Copylabel for a copy review on the original GH to get the correct copy.STYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel so the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari
MacOS: Desktop