Skip to content

Fix default avatar render with low quality #33745

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
robertjchen merged 3 commits into from
Jan 4, 2024
Merged

Fix default avatar render with low quality #33745

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
6f80412
fix default avatar render with low quality
dukenv0307 Dec 29, 2023
efe12b3
Merge branch 'main' into fix/33616
dukenv0307 Jan 2, 2024
0ab7aad
update change
dukenv0307 Jan 2, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions src/components/Lightbox.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -183,8 +183,8 @@ function Lightbox({isAuthTokenRequired, source, onScaleChanged, onPress, onError
onError={onError}
onLoadEnd={() => setImageLoaded(true)}
onLoad={(e) => {
const width = (e.nativeEvent?.width || 0) / PixelRatio.get();
const height = (e.nativeEvent?.height || 0) / PixelRatio.get();
const width = (e.nativeEvent?.width || 0) * PixelRatio.get();
const height = (e.nativeEvent?.height || 0) * PixelRatio.get();
setImageDimensions({...imageDimensions, lightboxSize: {width, height}});
}}
/>
Expand All @@ -205,8 +205,8 @@ function Lightbox({isAuthTokenRequired, source, onScaleChanged, onPress, onError
isAuthTokenRequired={isAuthTokenRequired}
onLoadEnd={() => setFallbackLoaded(true)}
onLoad={(e) => {
const width = e.nativeEvent?.width || 0;
const height = e.nativeEvent?.height || 0;
const width = (e.nativeEvent?.width || 0) * PixelRatio.get();
const height = (e.nativeEvent?.height || 0) * PixelRatio.get();

if (imageDimensions?.lightboxSize != null) {
return;
Expand Down