Set default currency for IOUBadge #3382
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
roryabraham
requested changes
Jun 4, 2021
Contributor
Author
|
@roryabraham updated |
roryabraham
approved these changes
Jun 4, 2021
Contributor
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
Contributor
|
🚀 Deployed to staging in version: 1.0.63-1🚀
|
Contributor
|
🚀 Deployed to production in version: 1.0.64-0🚀
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@roryabraham will you please review this
Details
This PR fixes an issue that I found while testing Expensify/react-native-onyx#76 (review). Currency does not have a default value, so if the IOUReport isn't done fetching before we try to display the IOUBadge, we can get a white screen on Web and Desktop. We also have default values for the other iouReport props in the IOUBadge, so we should add one for currency anyway.
Tests/QA
Tested On
Screenshots
N/A