fixes : copy to clipboard mention whisper message and hide mention whisper on any action by ishpaul777 · Pull Request #34560 · Expensify/App

ishpaul777 · 2024-01-16T09:26:19Z

Details

Fixed Issues

$ #34504
#33665 (comment)
#34560
PROPOSAL: N/a

Tests

Verify that no errors appear in the JS console

Tests 1:

Create a room
Go to the room
Send a text mention a user
Right click on Concierge message > Copy to clipboard
Paste the content
Verify pasted content includes the mentions as in the Concierge message.

Tests 2:

Create a room
Go to the room
Send a text mention a user
Invite user to room using whisper message button, verify concierge message disappear
Click Do nothing from whisper message button, verify concierge message disappear

Note

concierge whisper message will still be visible in LHN even after resolution, this requires a seperate Backend fix

Offline tests

QA Steps

Verify that no errors appear in the JS console

Tests 1:

Create a room
Go to the room
Send a text mention a user
Right click on Concierge message > Copy to clipboard
Paste the content
Verify pasted content includes the mentions as in the Concierge message.

Tests 2:

Create a room
Go to the room
Send a text mention a user
Invite user to room using whisper message button, verify concierge message disappear
Click Do nothing from whisper message button, verify concierge message disappear

Note

concierge whisper message will still be visible in LHN even after resolution, this requires a seperate Backend fix

PR Author Checklist

Screenshots/Videos

Android: Native

Record_2024-01-25-06-37-50.mp4

Android: mWeb Chrome

Record_2024-01-25-03-12-04.mp4

iOS: Native

Screen.Recording.2024-01-25.at.2.27.07.AM-1.mov

iOS: mWeb Safari

Screen.Recording.2024-01-25.at.2.44.38.AM-1.mov

MacOS: Chrome / Safari

Screen.Recording.2024-01-25.at.2.38.14.AM.mov

MacOS: Desktop

Screen.Recording.2024-01-25.at.6.44.31.AM.mov

ishpaul777 · 2024-01-18T16:02:56Z

@jasperhuangg Can you review changes when you get chance, i'll complete checklist and video if the solution is approved.

jasperhuangg

Looks good so far. I'm wondering if we can take your changes and apply them to all types of report actions that include accountID based mentions, but I guess that's kind of outside the scope of this issue.

src/libs/ReportActionsUtils.ts

aimane-chnaif · 2024-01-24T11:23:04Z

I think the solution goes in the right direction. Please complete author checklist and mark ready for review when ready

melvin-bot · 2024-01-25T01:15:47Z

@alitoshmatov Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

alitoshmatov · 2024-01-25T07:26:42Z

I think my review is not needed here or should I also review the PR?

cc: @jasperhuangg @aimane-chnaif

aimane-chnaif · 2024-01-25T07:48:34Z

Maybe one C+ is enough. I came from this request so I can continue if you don't mind

alitoshmatov · 2024-01-25T08:03:44Z

Sounds good

src/components/ReportActionItem/ActionableItemButtons.tsx

ishpaul777 · 2024-01-26T13:24:42Z

@aimane-chnaif gentle bump for review

ishpaul777 · 2024-02-04T11:33:37Z

Resolved conflicts.

ishpaul777 · 2024-02-05T18:11:03Z

gentle bump @aimane-chnaif

ishpaul777 · 2024-02-08T18:27:53Z

@aimane-chnaif gentle bump for feedback 🙇‍♂️

aimane-chnaif · 2024-02-08T18:57:06Z

reviewing

aimane-chnaif

Please merge main

src/pages/home/report/ReportActionItem.js

aimane-chnaif · 2024-02-11T15:52:47Z

I consider these out of scope but mentioning in case anyone reports as regression or bug as part of this PR.

whisper message says "@hidden" but actually email is copied. Seems like backend bug since I already know this contact

Screen.Recording.2024-02-11.at.4.50.15.PM.mov

manually selecting and copying doesn't work correctly and inconsistent with copy from context menu

Screen.Recording.2024-02-11.at.4.51.29.PM.mov

src/libs/ReportActionsUtils.ts

src/pages/home/report/ReportActionItem.js

aimane-chnaif · 2024-02-11T16:34:31Z

Please address all feedback above and request my review when ready. Thanks

ishpaul777 · 2024-02-13T17:43:19Z

@aimane-chnaif lmk if your concerns all are addressed, can we move this one forward?

aimane-chnaif · 2024-02-14T09:39:01Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

android.mov

Android: mWeb Chrome

iOS: Native

ios.mov

iOS: mWeb Safari

msafari.mov

MacOS: Chrome / Safari

web.mov

MacOS: Desktop

desktop1.mov

desktop2.mov

aimane-chnaif · 2024-02-14T09:40:50Z

@ishpaul777 let's sync main before merge

ishpaul777 · 2024-02-14T09:42:35Z

merged main 👍

OSBotify · 2024-02-14T20:24:33Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2024-02-15T05:35:37Z

🚀 Deployed to staging by https://github.com/jasperhuangg in version: 1.4.42-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2024-02-19T23:33:45Z

🚀 Deployed to production by https://github.com/chiragsalian in version: 1.4.42-5 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

ishpaul777 · 2025-02-05T20:41:57Z

src/pages/home/report/ReportActionItem.js


+    // if action is actionable mention whisper and resolved by user, then we don't want to render anything
+    if (ReportActionsUtils.isActionableMentionWhisper(props.action) && lodashGet(props.action, 'originalMessage.resolution', null)) {
+        return null;


coming from #49824 {BZ Checklist), Instead of manually return null when the whisper action is resolved, we should filter it out early here by including it in shouldReportActionBeVisible.

ishpaul777 added 3 commits January 16, 2024 14:54

fixes the issue of copy to clipboard of whisper message

1ac87b0

Merge branch 'main' into fix/34504

d222e30

Merge branch 'main' into fix/34504

cc388b6

ishpaul777 added 2 commits January 18, 2024 21:35

prettier diffs

80251b4

fixes the issue

bef0612

This was referenced Jan 19, 2024

New Feature: Create the UI for Actionable Mention Whispers #33665

Merged

[$500] The whisper to invite someone to a room is persistent #34868

Closed

jasperhuangg reviewed Jan 22, 2024

View reviewed changes

aimane-chnaif reviewed Jan 22, 2024

View reviewed changes

src/libs/ReportActionsUtils.ts Show resolved Hide resolved

ishpaul777 mentioned this pull request Jan 24, 2024

fix: use focus listeners for message read status #35004

Closed

50 tasks

Merge branch 'Expensify:main' into fix/34504

a56b138

ishpaul777 marked this pull request as ready for review January 25, 2024 01:15

ishpaul777 requested a review from a team as a code owner January 25, 2024 01:15

melvin-bot bot requested review from alitoshmatov and removed request for a team January 25, 2024 01:15

ishpaul777 mentioned this pull request Jan 25, 2024

[$500] Expense - The gap between buttons in Concierge whisper is too wide #35168

Closed

6 tasks

fixes gap between buttons

4a66337

ishpaul777 commented Jan 25, 2024

View reviewed changes

src/components/ReportActionItem/ActionableItemButtons.tsx Show resolved Hide resolved

Merge branch 'main' into fix/34504

5c6ad97

ishpaul777 mentioned this pull request Jan 27, 2024

[PAID] [$500] New Feature: Create the UI for Actionable Mention Whispers #32741

Closed

ishpaul777 and others added 3 commits January 27, 2024 17:53

Merge branch 'main' into fix/34504

da48a4e

fixes autoscroll issue with ios

0af51b5

refactor for conditions for readablity

4533c7f

prettier diffs

c482570

aimane-chnaif reviewed Feb 11, 2024

View reviewed changes

src/pages/home/report/ReportActionItem.js Show resolved Hide resolved

Merge branch 'Expensify:main' into fix/34504

49d6883

aimane-chnaif reviewed Feb 11, 2024

View reviewed changes

src/libs/ReportActionsUtils.ts Outdated Show resolved Hide resolved

aimane-chnaif reviewed Feb 11, 2024

View reviewed changes

src/pages/home/report/ReportActionItem.js Show resolved Hide resolved

ishpaul777 and others added 2 commits February 12, 2024 04:08

added changes per review comments

85d1991

Merge branch 'main' into fix/34504

34b4285

ishpaul777 requested a review from aimane-chnaif February 13, 2024 09:45

aimane-chnaif approved these changes Feb 14, 2024

View reviewed changes

Merge branch 'Expensify:main' into fix/34504

f814513

jasperhuangg approved these changes Feb 14, 2024

View reviewed changes

jasperhuangg merged commit 28bcc85 into Expensify:main Feb 14, 2024

This was referenced Feb 14, 2024

Investigate workflow job failing on main: e2ePerformanceTests / Run E2E tests in AWS device farm #36547

Closed

Deploy Checklist: New Expensify 2024-02-15 #36558

Closed

lanitochka17 mentioned this pull request Feb 15, 2024

[VSB] [$500] Room - Inviting a user to the room does not remove other whisper messages #36629

Closed

6 tasks

melvin-bot bot mentioned this pull request Feb 19, 2024

[HOLD for payment 2024-02-26] Room - Email in Concierge message is not copied when copied to clipboard #34504

Closed

6 tasks

ishpaul777 commented Feb 5, 2025

View reviewed changes

Conversation

ishpaul777 commented Jan 16, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

ishpaul777 commented Jan 18, 2024

Uh oh!

jasperhuangg left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

aimane-chnaif commented Jan 24, 2024

Uh oh!

melvin-bot bot commented Jan 25, 2024

Uh oh!

alitoshmatov commented Jan 25, 2024

Uh oh!

aimane-chnaif commented Jan 25, 2024

Uh oh!

alitoshmatov commented Jan 25, 2024

Uh oh!

Uh oh!

ishpaul777 commented Jan 26, 2024

Uh oh!

ishpaul777 commented Feb 4, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ishpaul777 commented Feb 5, 2024

Uh oh!

ishpaul777 commented Feb 8, 2024

Uh oh!

aimane-chnaif commented Feb 8, 2024

Uh oh!

aimane-chnaif left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

aimane-chnaif commented Feb 11, 2024

Uh oh!

Uh oh!

Uh oh!

aimane-chnaif commented Feb 11, 2024

Uh oh!

ishpaul777 commented Feb 13, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

aimane-chnaif commented Feb 14, 2024

Reviewer Checklist

Screenshots/Videos

Uh oh!

aimane-chnaif commented Feb 14, 2024

Uh oh!

ishpaul777 commented Feb 14, 2024

Uh oh!

OSBotify commented Feb 14, 2024

Uh oh!

OSBotify commented Feb 15, 2024

Uh oh!

OSBotify commented Feb 19, 2024

Uh oh!

ishpaul777 Feb 5, 2025

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

ishpaul777 commented Jan 16, 2024 •

edited

Loading

ishpaul777 commented Feb 4, 2024 •

edited

Loading

ishpaul777 commented Feb 13, 2024 •

edited

Loading