Use hrefAttrs for links #3486
Merged
Use hrefAttrs for links #3486
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Skipping iOS and Android testing since those flows are not touched. |
Contributor
Author
|
@Luke9389 this PR fixes a deploy blocker |
AndrewGable
approved these changes
Jun 9, 2021
Contributor
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
github-actions bot
pushed a commit
that referenced
this pull request
Jun 9, 2021
Use hrefAttrs for links (cherry picked from commit 8a254ee)
Contributor
|
🚀 Cherry-picked to staging in version: 1.0.66-3🚀
|
Contributor
|
🚀 Deployed to staging in version: 1.0.66-13🚀
|
49 tasks
5 tasks
Contributor
|
🚀 Deployed to production in version: 1.0.68-4🚀
|
1 similar comment
Contributor
|
🚀 Deployed to production in version: 1.0.68-4🚀
|
This was referenced Jun 25, 2021
57 tasks
|
@roryabraham Looks like something's off with this PR, it has been added to several checklists but it was already deployed to production almost 23 days ago 🤔🤔 |
5 tasks
Contributor
|
Thanks for pointing this out @isagoico. We're still trying to get to the bottom of the issues with the deploy checklist. Sorry for the hassle! |
This was referenced Jul 12, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details
linkandrelattributes must be passed viahrefAttrsas per https://necolas.github.io/react-native-web/docs/accessibility/#linksFixed Issues (Comment)
#3215 (comment)
Tests
QA Steps
Tested On
Screenshots
Web
Mobile Web
Desktop
iOS
Android