Allow accessing the members page in a thread by jasperhuangg · Pull Request #34993 · Expensify/App

jasperhuangg · 2024-01-23T19:40:41Z

Details

We should be able to invite users to all types of chat reports that aren't DMs, default rooms, or policy expense chats (this includes threads in DMs).

We previously only allowed invites in user created rooms.

Fixed Issues

Related to https://github.com/Expensify/Expensify/issues/362613
PROPOSAL:

Tests/QA

Open a DM with any user.
Send a message in the DM, and thread this message.
Click into the "Members" tab in the report details.
Verify you can invite people to the thread.

PR Author Checklist

I linked the correct issue in the ### Fixed Issues section above
I wrote clear testing steps that cover the changes made in this PR
- I added steps for local testing in the Tests section
- I added steps for the expected offline behavior in the Offline steps section
- I added steps for Staging and/or Production testing in the QA steps section
- I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
- I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
I included screenshots or videos for tests on all platforms
I ran the tests on all platforms & verified they passed on:
- Android / native
- Android / Chrome
- iOS / native
- iOS / Safari
- MacOS / Chrome / Safari
- MacOS / Desktop
I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
I followed proper code patterns (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
  - If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I followed the guidelines as stated in the Review Guidelines
I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
I verified that if a function's arguments changed that all usages have also been updated correctly
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- If we are not using the full Onyx data that we loaded, I've added the proper selector in order to ensure the component only re-renders when the data it is using changes
  - Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG))
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR author checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

Screen.Recording.2024-01-23.at.1.17.02.PM.mov

MacOS: Desktop

melvin-bot · 2024-01-23T22:17:52Z

@arosiclair Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

arosiclair · 2024-01-24T15:38:08Z

Weird that it didn't assign a C+. @jasperhuangg want to ask for a volunteer in #contributor-plus?

aimane-chnaif · 2024-01-24T15:39:49Z

Can I be?

jasperhuangg · 2024-01-25T18:22:39Z

@aimane-chnaif go for it if you're able to prioritize this review, thanks

aimane-chnaif · 2024-02-01T20:38:09Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android / native
- Android / Chrome
- iOS / native
- iOS / Safari
- MacOS / Chrome / Safari
- MacOS / Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

web.mov

MacOS: Desktop

aimane-chnaif

Please fix conflict. This component is now migrated to TS

aimane-chnaif · 2024-02-12T07:14:56Z

src/pages/ReportDetailsPage.js

                isAnonymousAction: false,
                action: () => {
-                    if (isUserCreatedPolicyRoom && !props.report.parentReportID) {
+                    if ((props.report.type === CONST.REPORT.TYPE.CHAT && props.report.parentReportID) || isUserCreatedPolicyRoom) {


Suggested change

if ((props.report.type === CONST.REPORT.TYPE.CHAT && props.report.parentReportID) || isUserCreatedPolicyRoom) {

if (isUserCreatedPolicyRoom || ReportUtils.isChatThread(report)) {

aimane-chnaif

This might be considered as bug:
Can invite/remove members in Concierge chat thread

aimane-chnaif · 2024-02-14T17:39:27Z

src/pages/RoomMembersPage.js

+                shouldShow={
+                    _.isEmpty(props.report) ||
+                    (_.isEmpty(ReportUtils.getParentReport(props.report)) && ReportUtils.isUserCreatedPolicyRoom(props.report) && !isPolicyMember) ||
+                    (_.isEmpty(ReportUtils.getParentReport(props.report)) && (ReportUtils.isDefaultRoom(props.report) || ReportUtils.isPolicyExpenseChat(props.report)))


Any reason for using getParentReport instead of isChatThread?
It's possible that parent report might not exist in Onyx even if this is thread (i.e. login with deeplink to thread, without opening parent chat)

True, I switched it to use isChatThread instead

aimane-chnaif · 2024-02-22T14:53:35Z

@jasperhuangg kindly bump on above concerns

jasperhuangg · 2024-02-23T19:27:17Z

@aimane-chnaif this is ready for another look

jasperhuangg · 2024-03-08T20:49:51Z

@aimane-chnaif I think I got everything working, we can access the members page and invite/remove in all threads regardless of the parent report type now

aimane-chnaif · 2024-03-08T21:09:50Z

React Hook useMemo has missing dependencies: 'isChatThread' and 'isDefaultRoom'. Either include them or remove the dependency array

aimane-chnaif · 2024-03-11T15:01:37Z

@jasperhuangg please merge main and fix lint

…tesInThreadsInDMs

jasperhuangg · 2024-03-11T20:28:43Z

@aimane-chnaif thanks, updated.

src/pages/ReportDetailsPage.tsx

aimane-chnaif · 2024-03-12T15:34:46Z

Members page of Concierge chat thread is still wrong. This should be participants page

jasperhuangg · 2024-03-12T16:57:51Z

@aimane-chnaif I think that's actually the behavior we want, threads in any type of report are invitable.

Co-authored-by: Aimane Chnaif <96077027+aimane-chnaif@users.noreply.github.com>

aimane-chnaif · 2024-03-12T17:10:10Z

ok, hope you'd cover any deploy blockers QA team is reporting since this PR might change the existing behaviors in TestRail.

aimane-chnaif · 2024-03-12T17:46:30Z

It's weird user who left thread is able to invite someone but maybe out of scope

Screen.Recording.2024-03-12.at.5.45.06.PM.mov

melvin-bot · 2024-03-12T18:00:29Z

@srikarparsi Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

melvin-bot · 2024-03-12T18:00:32Z

🎯 @aimane-chnaif, thanks for reviewing and testing this PR! 🎉

An E/App issue has been created to issue payment here: #38157.

arosiclair · 2024-03-12T20:07:58Z

src/pages/ReportDetailsPage.tsx

+            ((isDefaultRoom && isChatThread && isPolicyMember) ||
+                (!isUserCreatedPolicyRoom && participants.length) ||
+                (isUserCreatedPolicyRoom && (isPolicyMember || (isChatThread && !ReportUtils.isPublicRoom(report))))) &&
+            !ReportUtils.isConciergeChatReport(report)


NAB: these conditions are super confusing and I'd be surprised if somebody doesn't break these eventually. No idea how to simplify things, but something we should consider in case we have to revisit this

Yeah I agree, I was thinking of ways to simplify them but that would involve touching a bunch of other flows, so I elected to keep them the same for now so we could get them out sooner.

srikarparsi

lgtm

OSBotify · 2024-03-12T21:38:09Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2024-03-13T19:58:54Z

🚀 Deployed to staging by https://github.com/srikarparsi in version: 1.4.52-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2024-03-15T10:15:15Z

🚀 Deployed to production by https://github.com/Beamanator in version: 1.4.52-6 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

allow accessing the members page in a thread

d5c50b6

jasperhuangg changed the title ~~allow accessing the members page in a thread~~ Allow accessing the members page in a thread Jan 23, 2024

jasperhuangg self-assigned this Jan 23, 2024

jasperhuangg added 3 commits January 23, 2024 13:25

restrict to chat reports

545e368

update condition, add comment

c644fd0

style

a7bfccb

jasperhuangg marked this pull request as ready for review January 23, 2024 22:17

jasperhuangg requested a review from a team as a code owner January 23, 2024 22:17

melvin-bot bot requested review from arosiclair and removed request for a team January 23, 2024 22:17

arosiclair previously approved these changes Jan 24, 2024

View reviewed changes

arosiclair requested a review from aimane-chnaif January 24, 2024 17:05

aimane-chnaif suggested changes Feb 12, 2024

View reviewed changes

fix conflicts

13cb504

jasperhuangg dismissed arosiclair’s stale review via 13cb504 February 13, 2024 03:56

simplify condition

6708926

jasperhuangg requested review from aimane-chnaif and arosiclair February 13, 2024 03:56

aimane-chnaif reviewed Feb 14, 2024

View reviewed changes

jasperhuangg added 3 commits February 23, 2024 11:08

fix conflicts

7ca3f44

don't allow invites in Concierge reports

fe3cdf8

remove unused import

f37d119

jasperhuangg requested a review from aimane-chnaif February 23, 2024 19:27

fix behavior for public rooms

d98a459

lint

ee6a2b5

jasperhuangg added 3 commits March 11, 2024 13:26

Merge branch 'main' of github.com:Expensify/App into jasper-allowInvi…

c062879

…tesInThreadsInDMs

use correct variable naming

a93f1c5

add missing hook dependencies

9860894

aimane-chnaif reviewed Mar 12, 2024

View reviewed changes

src/pages/ReportDetailsPage.tsx Outdated Show resolved Hide resolved

Update ReportDetailsPage.tsx

c4ee5d3

Co-authored-by: Aimane Chnaif <96077027+aimane-chnaif@users.noreply.github.com>

jasperhuangg requested a review from aimane-chnaif March 12, 2024 17:18

aimane-chnaif approved these changes Mar 12, 2024

View reviewed changes

melvin-bot bot requested a review from srikarparsi March 12, 2024 18:00

melvin-bot bot mentioned this pull request Mar 12, 2024

Payment issue for E/App PR#34993 #38157

Closed

arosiclair approved these changes Mar 12, 2024

View reviewed changes

srikarparsi approved these changes Mar 12, 2024

View reviewed changes

srikarparsi merged commit 92bbd8b into main Mar 12, 2024

srikarparsi deleted the jasper-allowInvitesInThreadsInDMs branch March 12, 2024 21:32

github-actions bot mentioned this pull request Mar 13, 2024

Deploy Checklist: New Expensify 2024-03-13 #38257

Closed

74 tasks

lanitochka17 mentioned this pull request Mar 14, 2024

[HOLD for payment 2024-03-25] Invite - Selected contacts with names disappeared from the invite listing page #38324

Closed

6 tasks

	if ((props.report.type === CONST.REPORT.TYPE.CHAT && props.report.parentReportID) \|\| isUserCreatedPolicyRoom) {
	if (isUserCreatedPolicyRoom \|\| ReportUtils.isChatThread(report)) {

Conversation

jasperhuangg commented Jan 23, 2024 • edited by github-actions bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Details

Fixed Issues

Tests/QA

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot bot commented Jan 23, 2024

Uh oh!

arosiclair commented Jan 24, 2024

Uh oh!

aimane-chnaif commented Jan 24, 2024

Uh oh!

jasperhuangg commented Jan 25, 2024

Uh oh!

aimane-chnaif commented Feb 1, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

aimane-chnaif left a comment

Choose a reason for hiding this comment

Uh oh!

aimane-chnaif Feb 12, 2024

Choose a reason for hiding this comment

Uh oh!

aimane-chnaif left a comment

Choose a reason for hiding this comment

Uh oh!

aimane-chnaif Feb 14, 2024

Choose a reason for hiding this comment

Uh oh!

jasperhuangg Feb 23, 2024

Choose a reason for hiding this comment

Uh oh!

aimane-chnaif commented Feb 22, 2024

Uh oh!

jasperhuangg commented Feb 23, 2024

Uh oh!

jasperhuangg commented Mar 8, 2024

Uh oh!

aimane-chnaif commented Mar 8, 2024

Uh oh!

aimane-chnaif commented Mar 11, 2024

Uh oh!

jasperhuangg commented Mar 11, 2024

Uh oh!

Uh oh!

aimane-chnaif commented Mar 12, 2024

Uh oh!

jasperhuangg commented Mar 12, 2024

Uh oh!

aimane-chnaif commented Mar 12, 2024

Uh oh!

aimane-chnaif commented Mar 12, 2024

Uh oh!

melvin-bot bot commented Mar 12, 2024

Uh oh!

melvin-bot bot commented Mar 12, 2024

Uh oh!

arosiclair Mar 12, 2024

Choose a reason for hiding this comment

Uh oh!

jasperhuangg Mar 12, 2024

Choose a reason for hiding this comment

Uh oh!

srikarparsi left a comment

Choose a reason for hiding this comment

Uh oh!

OSBotify commented Mar 12, 2024

Uh oh!

OSBotify commented Mar 13, 2024

Uh oh!

OSBotify commented Mar 15, 2024

Uh oh!

Reviewers

Assignees

Labels

jasperhuangg commented Jan 23, 2024 •

edited by github-actions bot

Loading

aimane-chnaif commented Feb 1, 2024 •

edited

Loading