Skip to content

Conversation

@AndrewGable
Copy link
Contributor

Closes #27

Adds pusher by:

  1. Importing pusher web and pusher react native versions (I tried using react native for web and it didn't work)
  2. Removing deferred in pusher.js

Demo in slack here: https://expensify.slack.com/archives/G01960P56HW/p1597031774357300

@AndrewGable AndrewGable self-assigned this Aug 10, 2020
@AndrewGable AndrewGable changed the title Andrew pusher Add Pusher 💥 Aug 10, 2020
flexGrow: 1,
},
historyItemAvatar: {
borderRadius: '50%',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mobile didn't support this either I take it? Bummer!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep, just had to calculate the 50% manually 😞

@tgolen
Copy link
Contributor

tgolen commented Aug 10, 2020

Ah, there is a conflict

@AndrewGable
Copy link
Contributor Author

1 sec, fixing conflicts now

@AndrewGable
Copy link
Contributor Author

Kk good to merge now!

@tgolen tgolen merged commit 8a4998d into master Aug 10, 2020
@tgolen tgolen deleted the andrew-pusher branch August 10, 2020 16:53
gegham-khachatryan added a commit to gegham-khachatryan/App that referenced this pull request Aug 31, 2023
gegham-khachatryan added a commit to gegham-khachatryan/App that referenced this pull request Sep 1, 2023
* Fix Map Panning behavior

* Add screen focus state props to MapView

Added new props to avoid introducing unnecessary dependencies ('@react-navigation/native') to the 'react-native-x-maps' library.

* feat: Move code from react-native-x-maps to the App

* fix: rename mapbox consts

* fix: Fix app crashing on waypoint delete

* Remove unnecessary re exports

* Fix react duplicate keys Expensify#35

* Fix Not Found Page appearing issue and add comment

* Fix panning issue

* fix: add PropTypes import which is mised during conflict resolution
@cloudflare-workers-and-pages
Copy link

cloudflare-workers-and-pages bot commented Oct 12, 2023

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: d30a850
Status:⚡️  Build in progress...

View logs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Implement live report actions with pusher so that comments made to the report on www show up automatically

3 participants