Skip to content

fix: use focus listeners for message read status #35004

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
jeremy-croff wants to merge 11 commits into from
Closed

fix: use focus listeners for message read status #35004

Changes from all commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
3969369
fix: uses visibility api from electron to determine visibility, imple…
jeremy-croff Jan 23, 2024
2002050
fix: handle visibility and focus events
jeremy-croff Jan 24, 2024
1a1b84c
fix/34829: refactor condition
jeremy-croff Jan 24, 2024
da88368
fix/34829: only mark as read if changed
jeremy-croff Jan 24, 2024
609e16f
Merge branch 'main' into fix/34829
jeremy-croff Jan 31, 2024
13b0752
fix/34829: format
jeremy-croff Jan 31, 2024
7a5b09a
Merge remote-tracking branch 'origin/main' into fix/34829
jeremy-croff Jan 31, 2024
cf94890
fix/34829: remove other logic to simplify solution
jeremy-croff Feb 1, 2024
b03d47a
Delete .ruby-version
jeremy-croff Feb 1, 2024
bb4cef0
Update index.desktop.ts
jeremy-croff Feb 1, 2024
3e71481
Update ReportActionsList.js
jeremy-croff Feb 1, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 11 additions & 9 deletions src/pages/home/report/ReportActionsList.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@ import InvertedFlatList from '@components/InvertedFlatList';
import {withPersonalDetails} from '@components/OnyxProvider';
import withCurrentUserPersonalDetails, {withCurrentUserPersonalDetailsDefaultProps, withCurrentUserPersonalDetailsPropTypes} from '@components/withCurrentUserPersonalDetails';
import withWindowDimensions, {windowDimensionsPropTypes} from '@components/withWindowDimensions';
import useAppFocusEvent from '@hooks/useAppFocusEvent';
import useLocalize from '@hooks/useLocalize';
import useNetwork from '@hooks/useNetwork';
import useReportScrollManager from '@hooks/useReportScrollManager';
Expand Down Expand Up @@ -202,29 +203,30 @@ function ReportActionsList({
prevReportID = report.reportID;
}, [report.reportID]);

useEffect(() => {
const readNewestReportAction = () => {
if (!userActiveSince.current || report.reportID !== prevReportID) {
return;
}

if (ReportUtils.isUnread(report)) {
if (Visibility.isVisible() && scrollingVerticalOffset.current < MSG_VISIBLE_THRESHOLD) {
Report.readNewestAction(report.reportID);
} else {
readActionSkipped.current = true;
}
if (ReportUtils.isUnread(report) && Visibility.isVisible() && scrollingVerticalOffset.current < MSG_VISIBLE_THRESHOLD) {
Report.readNewestAction(report.reportID);
} else {
readActionSkipped.current = true;
}
};

useEffect(() => {
readNewestReportAction();
if (currentUnreadMarker || lastVisibleActionCreatedRef.current === report.lastVisibleActionCreated) {
return;
}

cacheUnreadMarkers.delete(report.reportID);
lastVisibleActionCreatedRef.current = report.lastVisibleActionCreated;
setCurrentUnreadMarker(null);
// eslint-disable-next-line react-hooks/exhaustive-deps
}, [report.lastVisibleActionCreated, report.reportID]);

useAppFocusEvent(readNewestReportAction);

useEffect(() => {
if (!userActiveSince.current || report.reportID !== prevReportID) {
return;
Expand Down