Skip to content

Fix/34820: Hide join button once leaving #35202

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
neil-marcellini merged 4 commits into from
Jan 29, 2024
Merged

Fix/34820: Hide join button once leaving #35202

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
4fe3878
fix hide join button once leaving
DylanDylann Jan 25, 2024
6c5499e
fix: issue
DylanDylann Jan 25, 2024
20441ac
fix add isLoading to render condition of join button
DylanDylann Jan 27, 2024
76d4e47
fix issue
DylanDylann Jan 27, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/pages/home/HeaderView.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -217,7 +217,7 @@ function HeaderView(props) {
const shouldShowBorderBottom = !isTaskReport || !isSmallScreenWidth;
const shouldDisableDetailPage = ReportUtils.shouldDisableDetailPage(props.report);

const isLoading = !props.report || !title;
const isLoading = !props.report || !props.report.reportID || !title;

return (
<View
Expand Down Expand Up @@ -321,7 +321,7 @@ function HeaderView(props) {
)}
</View>
</View>
{canJoin && isSmallScreenWidth && <View style={[styles.ph5, styles.pb2]}>{joinButton}</View>}
{!isLoading && canJoin && isSmallScreenWidth && <View style={[styles.ph5, styles.pb2]}>{joinButton}</View>}
</View>
);
}
Expand Down