[TS migration] Migrate 'IOUEditRequestReceipt' page to TypeScript by eucool · Pull Request #36314 · Expensify/App

eucool · 2024-02-12T08:44:13Z

Details

Fixed Issues

$ #32000
PROPOSAL: #32000 (comment)

Tests

Same as QA step

Verify that no errors appear in the JS console

Offline tests

Same as QA step

QA Steps

Go to FAB/workspace chat/1:1
Click on request money
click on scan
Click photo (Native)/ upload file (MacOS/ safari)
The photo should be clicked successfully and we should be able to go to the confirmation page

Verify that no errors appear in the JS console

PR Author Checklist

I linked the correct issue in the ### Fixed Issues section above
I wrote clear testing steps that cover the changes made in this PR
- I added steps for local testing in the Tests section
- I added steps for the expected offline behavior in the Offline steps section
- I added steps for Staging and/or Production testing in the QA steps section
- I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
- I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
I included screenshots or videos for tests on all platforms
I ran the tests on all platforms & verified they passed on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
I followed proper code patterns (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
  - If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I followed the guidelines as stated in the Review Guidelines
I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
I verified that if a function's arguments changed that all usages have also been updated correctly
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

iOS: mWeb Safari

Android: mWeb Chrome

iOS: Native

Android: Native

MacOS: Desktop

MacOS: Chrome / Safari

melvin-bot · 2024-02-12T08:44:18Z

@akinwale Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

kubabutkiewicz · 2024-02-12T14:28:45Z

Hi @codinggeek2023 can you fix ts check, lint and do a PR author checklist?

eucool · 2024-02-12T14:30:30Z

hello @kubabutkiewicz , thanks for responding, i will do it ASAP, i am getting some error while converting a HOC into typescript, can you please help me out over here :), i'll comment over the HOC

src/pages/iou/request/step/IOURequestStepScan/index.tsx

eucool · 2024-02-13T23:58:21Z

Hello @kubabutkiewicz , please review the PR when you find time :), i have pushed the latest changes

kubabutkiewicz · 2024-02-14T09:42:43Z

@codinggeek2023 hi I will review it today, can you also fill the PR Author Checklist?

src/pages/EditRequestCreatedPage.js

src/pages/iou/ReceiptDropUI.tsx

src/pages/iou/request/step/IOURequestStepScan/IOURequestStepProps.tsx

src/pages/iou/request/step/IOURequestStepScan/NavigationAwareCamera/index.native.tsx

src/pages/iou/request/step/IOURequestStepScan/index.tsx

kubabutkiewicz · 2024-02-15T09:03:55Z

@codinggeek2023 there is still typescript check failing and also a lint

melvin-bot · 2024-04-09T11:42:12Z

We did not find an internal engineer to review this PR, trying to assign a random engineer to #32000 as well as to this PR... Please reach out for help on Slack if no one gets assigned!

MonilBhavsar · 2024-04-09T12:19:23Z

src/libs/actions/IOU.ts

+function setMoneyRequestParticipantsFromReport(transactionID: string, report: OnyxEntry<OnyxTypes.Report>) {
    // If the report is iou or expense report, we should get the chat report to set participant for request money
-    const chatReport = ReportUtils.isMoneyRequestReport(report) ? ReportUtils.getReport(report.chatReportID) : report;
+    const chatReport = ReportUtils.isMoneyRequestReport(report) ? ReportUtils.getReport(report?.chatReportID) : report;


Is optional chaining really required for chatReportID?

This function must be used in a bunch of places so not to break any functionality here :)

Okay, I would assume chatReportID is always set. But it's fine

src/pages/iou/ReceiptDropUI.tsx

src/pages/iou/request/step/IOURequestStepScan/index.native.tsx

MonilBhavsar · 2024-04-09T12:34:41Z

src/pages/iou/request/step/IOURequestStepScan/index.native.tsx

        // So, let us also save the file type in receipt for later use during blob fetch
-        IOU.setMoneyRequestReceipt(transactionID, file.uri, file.name, action !== CONST.IOU.ACTION.EDIT, file.type);
+        // eslint-disable-next-line @typescript-eslint/prefer-nullish-coalescing
+        IOU.setMoneyRequestReceipt(transactionID, file?.uri ?? '', file.name || '', action !== CONST.IOU.ACTION.EDIT, file.type);


Why not use null coalesce here?

Can do 👍

Ok thanks! I wonder if || was added for any specific case where we could not use ??

blazejkustra · 2024-04-09T21:48:51Z

@codinggeek2023 Typecheck is failing, please have a look

eucool · 2024-04-09T22:29:20Z

Fixed the typecheck, i guess one more component was migrated to TS so the error again, otherwise the tests were passing :) thanks @blazejkustra

eucool · 2024-04-09T22:30:56Z

@MonilBhavsar can you please put a ready to build label here? This is the camera component and it would be good if we test it in ADHOC build on physical devices too

MonilBhavsar · 2024-04-10T07:56:31Z

Good idea! There are conflicts now. Can you please resolve it. I can generate a build then

eucool · 2024-04-10T21:44:36Z

Fixed the conflicts, letss build @MonilBhavsar 💪

github-actions · 2024-04-11T06:52:42Z

🧪🧪 Use the links below to test this adhoc build on Android, iOS, Desktop, and Web. Happy testing! 🧪🧪

Android 🤖	iOS 🍎
https://ad-hoc-expensify-cash.s3.amazonaws.com/android/36314/index.html	https://ad-hoc-expensify-cash.s3.amazonaws.com/ios/36314/index.html

Desktop 💻	Web 🕸️
https://ad-hoc-expensify-cash.s3.amazonaws.com/desktop/36314/NewExpensify.dmg	https://36314.pr-testing.expensify.com

👀 View the workflow run that generated this build 👀

fabioh8010 · 2024-04-11T06:58:05Z

Build is ready, what are next steps here @codinggeek2023 @MonilBhavsar ? Need any help?

eucool · 2024-04-11T11:44:30Z

Let's merge this one, I was not able to test on Native IOS it says integrity could not be verified but should work fine

OSBotify · 2024-04-11T13:13:02Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2024-04-18T04:54:26Z

🚀 Deployed to staging by https://github.com/MonilBhavsar in version: 1.4.63-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2024-04-22T14:55:25Z

🚀 Deployed to production by https://github.com/mountiny in version: 1.4.63-21 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

Migrate to Typescript

91f94c7

eucool requested a review from a team as a code owner February 12, 2024 08:44

melvin-bot bot requested review from akinwale and removed request for a team February 12, 2024 08:44

eucool added 2 commits February 12, 2024 14:20

Put Request types

9a291eb

Update types

5bcb3e3

blank commit for HOC

eb8dd5f

eucool commented Feb 12, 2024

View reviewed changes

src/pages/iou/request/step/IOURequestStepScan/index.tsx Show resolved Hide resolved

eucool added 4 commits February 12, 2024 20:47

fix lint

bbacf1c

Add typescript exception for AttachmentPicker

d632eb8

Resolve merge conflict

2ddae0c

Migrate to typescript

63e86cb

kubabutkiewicz reviewed Feb 14, 2024

View reviewed changes

eucool added 7 commits February 14, 2024 19:49

Update types

7273c5b

Push deleted file

1725caa

Migrate to typescript

8960d8f

revert deleted file

243afc8

remove conflict

1bb8fc2

remove conflict

33363ca

Merge branch 'main' into issueScan

3c6c657

eucool added 4 commits February 16, 2024 00:29

Fix lint

4384ed3

Fix lint

cdaec4b

Fix Route type

a056120

Fix Route type

c3e70d3

akinwale approved these changes Apr 9, 2024

View reviewed changes

melvin-bot bot requested a review from MonilBhavsar April 9, 2024 11:43

MonilBhavsar reviewed Apr 9, 2024

View reviewed changes

eucool and others added 2 commits April 10, 2024 01:47

Merge branch 'Expensify:main' into issueScan

35c05cf

Fix on suggestions

0eca33c

Fix not found

a671cfe

Resolve merge conflicts

4c53b63

MonilBhavsar added Ready To Build and removed Ready To Build labels Apr 11, 2024

MonilBhavsar approved these changes Apr 11, 2024

View reviewed changes

MonilBhavsar merged commit 9e10604 into Expensify:main Apr 11, 2024

This was referenced Apr 11, 2024

Investigate workflow job failing on main: e2ePerformanceTests / Build apk from delta ref #40111

Closed

Deploy Checklist: New Expensify 2024-04-18 #40392

Closed

kbecciv mentioned this pull request Apr 18, 2024

[$250] Submit Expense - Error message about corrupted file when dragging and dropping image receipt #40440

Closed

6 tasks

lanitochka17 mentioned this pull request Apr 18, 2024

Submit Expense - 'No PDF file specified' shown on confirmation page after adding PDF receipt #40476

Closed

6 tasks

kbecciv mentioned this pull request Apr 18, 2024

Submit Expense - PDF files can not be added to scan expense on mobile apps #40486

Closed

6 tasks

danieldoglas mentioned this pull request Apr 19, 2024

[HOLD for payment 2024-05-02] Scan - "Let it go" copy is not centered when dragging and dropping a file to Scan RHP #40539

Closed

6 tasks

Conversation

eucool commented Feb 12, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot bot commented Feb 12, 2024

Uh oh!

kubabutkiewicz commented Feb 12, 2024

Uh oh!

eucool commented Feb 12, 2024

Uh oh!

Uh oh!

eucool commented Feb 13, 2024

Uh oh!

kubabutkiewicz commented Feb 14, 2024

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

kubabutkiewicz commented Feb 15, 2024

Uh oh!

melvin-bot bot commented Apr 9, 2024

Uh oh!

MonilBhavsar Apr 9, 2024

Choose a reason for hiding this comment

Uh oh!

eucool Apr 9, 2024

Choose a reason for hiding this comment

Uh oh!

MonilBhavsar Apr 10, 2024

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

MonilBhavsar Apr 9, 2024

Choose a reason for hiding this comment

Uh oh!

eucool Apr 9, 2024

Choose a reason for hiding this comment

Uh oh!

MonilBhavsar Apr 10, 2024

Choose a reason for hiding this comment

Uh oh!

blazejkustra commented Apr 9, 2024

Uh oh!

eucool commented Apr 9, 2024

Uh oh!

eucool commented Apr 9, 2024

Uh oh!

MonilBhavsar commented Apr 10, 2024

Uh oh!

eucool commented Apr 10, 2024

Uh oh!

github-actions bot commented Apr 11, 2024

Uh oh!

fabioh8010 commented Apr 11, 2024

Uh oh!

eucool commented Apr 11, 2024

Uh oh!

OSBotify commented Apr 11, 2024

Uh oh!

OSBotify commented Apr 18, 2024

Uh oh!

OSBotify commented Apr 22, 2024

Uh oh!

Reviewers

eucool commented Feb 12, 2024 •

edited

Loading