[CP Staging] Add nav backup back so we can CP to staging#36329
Merged
Beamanator merged 1 commit intomainfrom Feb 12, 2024
Merged
[CP Staging] Add nav backup back so we can CP to staging#36329Beamanator merged 1 commit intomainfrom
Beamanator merged 1 commit intomainfrom
Conversation
Contributor
Reviewer Checklist
Screenshots/VideosAndroid: NativeAndroid: mWeb ChromeiOS: NativeiOS: mWeb SafariMacOS: Chrome / SafariMacOS: Desktop |
Contributor
|
@Beamanator Feel free to self-merge when the performance test is done, thanks. |
77 tasks
OSBotify
pushed a commit
that referenced
this pull request
Feb 12, 2024
Add nav backup back so we can CP to staging (cherry picked from commit 4c98589)
Contributor
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
Beamanator
added a commit
that referenced
this pull request
Feb 12, 2024
…ng-36329-1 🍒 Cherry pick PR #36329 to staging 🍒
Contributor
|
🚀 Deployed to staging by https://github.com/Beamanator in version: 1.4.39-8 🚀
|
This was referenced Feb 12, 2024
Contributor
|
🚀 Deployed to production by https://github.com/Beamanator in version: 1.4.39-8 🚀
|
50 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
cc @techievivek if you've got time to review! 🙏
Details
This change was recently added in #36050, with a lot of other changes (30 files total).
I'm making this PR so we can CP it to staging, to fix the below deploy blockers
Fixed Issues
$ #36175
$ #36306
$ #36307
Tests
Offline tests
Same steps as above, do the entire flow offline
QA Steps
Same steps as above
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectiontoggleReportand notonIconClick)myBool && <MyComponent />.src/languages/*files and using the translation methodWaiting for Copylabel for a copy review on the original GH to get the correct copy.STYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel so the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari
MacOS: Desktop