-
Notifications
You must be signed in to change notification settings - Fork 3.7k
Fix/address page state navigation 2 #36770
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
mountiny
merged 75 commits into
Expensify:main
from
ygshbht:fix/address-page-state-navigation-2
Apr 2, 2024
Merged
Changes from all commits
Commits
Show all changes
75 commits
Select commit
Hold shift + click to select a range
cd8ca07
Convert StatePicker modal to StateSelection page
ygshbht 1284e59
Incorporation state resets bugfix
ygshbht 963cf67
Modify pages to accomodate for StateSelection
ygshbht 1305561
Merge https://github.com/Expensify/App into fix/address-page-state-na…
ygshbht 16ba084
Refactor to use useGeographicalStateFromRoute hook
ygshbht 0f83cff
move getStateFromRoute to useGeographicalStateFromRoute
ygshbht 0951d5d
Add displayname to StateSelectorWithRef
ygshbht 3b88d46
Merge https://github.com/Expensify/App into fix/address-page-state-na…
ygshbht 598c7c6
Fix AddressPage: State not changing on autocomplete
ygshbht 4a21636
Refactor StateSelector logic
ygshbht 312d0c6
Refactor AddressPage
ygshbht 8a293b5
linting fixes StateSelector
ygshbht c946cbb
linting
ygshbht 144eea9
StateSelector and related files refactoring
ygshbht d2848d3
Merge https://github.com/Expensify/App into fix/address-page-state-na…
ygshbht 17f2aab
Fix incorrect merge
ygshbht 9fb4f72
Reverted scripts/shellCheck.sh to state at 33f15e8d85b3366b1a09bca914…
ygshbht d6a643c
Linting
ygshbht 080285a
Merge https://github.com/Expensify/App into fix/address-page-state-na…
ygshbht 9bb88ee
Comment formatting src/hooks/useGeographicalStateFromRoute.ts
ygshbht 5e38447
Rename useStateFomrUrl to shouldUseStateFromUrl
ygshbht 470ec03
forwardedRef type correction StateSelector
ygshbht 8f28580
StateSelector: rename paramName to queryParam
ygshbht 7be20b3
Remove lodashGet from useGeographicalStateFromRoute
ygshbht 428e48c
StateSelectionPage appendParam restructuring
ygshbht 7cd8b6f
Prettier formatting
ygshbht 5a02b71
Merge branch 'main' into fix/address-page-state-navigation-2
ygshbht ec0eb6f
Comment typo fix src/pages/settings/Profile/PersonalDetails/StateSele…
ygshbht 07f6f21
Comment formatting src/pages/settings/Profile/PersonalDetails/Address…
ygshbht 77f236c
Merge branch 'main' into fix/address-page-state-navigation-2
ygshbht 877740b
Fix TS errors
ygshbht 6731502
Merge branch 'main' into fix/address-page-state-navigation-2
ygshbht a6faef4
Refactor StateSelectionPage with more explanatory comments
ygshbht 7db144b
Merge branch 'main' into fix/address-page-state-navigation-2
ygshbht c0c1c6b
Merge branch 'main' into fix/address-page-state-navigation-2
ygshbht 7b15308
Incorrect header space fix: src/pages/settings/Profile/PersonalDetail…
ygshbht 21b215a
Remove unused code StateSelectionPage.tsx
ygshbht 0fd833f
Merge branch 'main' into fix/address-page-state-navigation-2
ygshbht 8c59969
Merge branch 'main' into fix/address-page-state-navigation-2
ygshbht 397278d
Prettier formatting
ygshbht 4a8d6d6
Merge branch 'main' into fix/address-page-state-navigation-2
ygshbht 5d223d6
fix: handle potential 'undefined' object issue
ygshbht 3a3c767
Typo fix src/components/StateSelector.tsx
ygshbht c56f8d5
Format src/libs/Url.ts
ygshbht 470be54
Format src/libs/Url.ts
ygshbht 1670b66
Format src/pages/settings/Profile/PersonalDetails/StateSelectionPage.tsx
ygshbht 5d2ff1e
Format src/pages/settings/Profile/PersonalDetails/AddressPage.tsx
ygshbht 18717ea
Comment for function useGeographicalStateFromRoute
ygshbht 3ba97a5
hash append for StateSelector edge cases
ygshbht 0dc7f49
Comment update useGeographicalStateFromRoute
ygshbht 57bcee2
Add StateSelector to MoneyRequest Navigation stack to work for /send/…
ygshbht 9ffea05
Formatting src/pages/settings/Profile/PersonalDetails/AddressPage.tsx
ygshbht d25904c
Commnet udpate src/ROUTES.ts
ygshbht 81f452c
Comment update ROUTES.ts
ygshbht dc35055
Example update src/hooks/useGeographicalStateFromRoute.ts
ygshbht a764d21
Merge branch 'main' into fix/address-page-state-navigation-2
ygshbht 78afcd5
Refactor linking config StateSelector
ygshbht ecc3953
Revert "hash append for StateSelector edge cases"
ygshbht 713a91c
Sync URL 'state' param with StateSelector value
ygshbht 9a79421
Merge branch 'main' into fix/address-page-state-navigation-2
ygshbht 2a76bed
change moneyrequest/state url to request/state
ygshbht 49f2e46
change moneyrequest/state url to request/state
ygshbht 15c54b2
Merge branch 'main' into fix/address-page-state-navigation-2
ygshbht 58d92f1
StateSelector bugfix - for issue causing url to not update in browser…
ygshbht af6c3c5
useGeographicalStateFromRoute - check for state before accessing stat…
ygshbht 24cbec3
Merge branch 'main' into fix/address-page-state-navigation-2
ygshbht 2619a29
Fix: Inconsistent validation error for required field in home address
ygshbht f48a7fc
Remove unused code: StateSelector
ygshbht 4efccc0
StateSelectionPage: Fix issue of page crash when country is changed m…
ygshbht b9fe092
es lint comment formatting
ygshbht 5f0cc47
eslint Formatting fix
ygshbht 3585296
prettier
ygshbht 639a646
Merge branch 'main' into fix/address-page-state-navigation-2
ygshbht 7e81480
Merge branch 'main' into fix/address-page-state-navigation-2
ygshbht 3f87bf2
Add explanatory comments to StateSelector
ygshbht File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
This file was deleted.
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.