[TS migration] Migrate 'NewTask' page to TypeScript by pasyukevich · Pull Request #36886 · Expensify/App

pasyukevich · 2024-02-20T14:23:43Z

Details

Fixed Issues

$#25213
PROPOSAL:

Tests

Open the Create New Task screen
Verify ui
Press Next
Observe error
Fill required fields
Press Next
Choose assignee
Press Confirm task
Observe successful creation

Verify that no errors appear in the JS console

Offline tests

QA Steps

Open the Create New Task screen
Verify ui
Press Next
Observe error
Fill required fields
Press Next
Choose assignee
Press Confirm task
Observe successful creation

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

android-native-converted.webm

Android: mWeb Chrome

android-web-converted.webm

iOS: Native

ios-native-converted.mp4

iOS: mWeb Safari

ios-web-converted.mp4

MacOS: Chrome / Safari

Desktop-web-converted.mov

MacOS: Desktop

desktop-native-converted.mov

src/pages/tasks/NewTaskDescriptionPage.tsx

src/pages/tasks/NewTaskTitlePage.tsx

src/pages/tasks/NewTaskDescriptionPage.tsx

src/pages/tasks/NewTaskDetailsPage copy.tsx

src/pages/tasks/NewTaskPage.tsx

src/pages/tasks/NewTaskDetailsPage.tsx

src/ONYXKEYS.ts

c3024 · 2024-02-28T18:03:57Z

src/pages/tasks/NewTaskPage.tsx

+                    <View style={styles.flexShrink0}>
                        <FormAlertWithSubmitButton
-                            isAlertVisible={!_.isEmpty(errorMessage)}
+                            isAlertVisible={!isEmptyObject(errorMessage)}


The way isEmptyObject is implemented with obj, it looks like isEmptyObject is true for any string. I think this is not what we expect here.

Updated to Boolean, since isEmptyObject is mostly for objects

But cannot agree. isEmptyObject will work well with empty and nonempty strings. (you can check it by yourself, Object.keys() works great with string and converting it into an empty or nonempty array )

c3024 · 2024-02-28T18:20:25Z

src/pages/tasks/NewTaskDescriptionPage.tsx

-
-    ...withLocalizePropTypes,
+type NewTaskDescriptionPageOnyxProps = {
+    /** Grab the Share title of the Task */


NAB/NIT: In this comment, Share title is kinda irrelevant to this description page. Maybe just Details of the Task or Grab the details of the Task appears better to me.

Or just omit this comment? Does not appear to be useful at all.

Same for the NewTaskDetailsPage and NewTaskTitlePage. I think Share is only applicable to Share somewhere and is not for details and title.

melvin-bot · 2024-03-06T12:13:53Z

@neil-marcellini Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

pasyukevich · 2024-03-06T12:15:20Z

@c3024 PR updated

c3024 · 2024-03-06T16:21:06Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

newTaskAndroid.mp4

Android: mWeb Chrome

newTaskAndroidChrome.mp4

iOS: Native

newTaskiOS.mp4

iOS: mWeb Safari

newTaskSafari.mp4

MacOS: Chrome / Safari

newTaskChrome.mp4

MacOS: Desktop

newTaskDesktop.mp4

c3024

LGTM

melvin-bot · 2024-03-06T16:51:03Z

🎯 @c3024, thanks for reviewing and testing this PR! 🎉

An E/App issue has been created to issue payment here: #37828.

neil-marcellini

@c3024 @pasyukevich these test steps do not meet our standards, they are way too vague and subjective. Please get them updated and retest if needed. I'll review the code in the meantime.

neil-marcellini

The code looks good, thanks

src/pages/tasks/NewTaskPage.tsx

pasyukevich · 2024-03-12T12:53:25Z

@neil-marcellini test cases updated

c3024 · 2024-03-12T13:05:41Z

Tests well

newTaskAfterMainMerge.mp4

neil-marcellini

Looks great. Thanks for explaining the optional chaining and improving the test steps.

OSBotify · 2024-03-12T22:26:33Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2024-03-13T19:59:06Z

🚀 Deployed to staging by https://github.com/neil-marcellini in version: 1.4.52-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2024-03-15T10:15:27Z

🚀 Deployed to production by https://github.com/Beamanator in version: 1.4.52-6 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

parasharrajat · 2024-03-18T09:33:27Z

src/pages/tasks/NewTaskPage.tsx

+                                onPress={() => Navigation.navigate(ROUTES.NEW_TASK_SHARE_DESTINATION)}
+                                interactive={!task?.parentReportID}
+                                shouldShowRightIcon={!task?.parentReportID}
+                                titleWithTooltips={shareDestination?.shouldUseFullTitleToDisplay ? shareDestination?.displayNamesWithTooltips : []}


Incorrect conversion of this old conditional caused a regression #38294

[TS migration] Migrate 'NewTask' page to TypeScript

329aa95

VickyStash reviewed Feb 20, 2024

View reviewed changes

rezkiy37 reviewed Feb 20, 2024

View reviewed changes

src/pages/tasks/NewTaskDetailsPage.tsx Outdated Show resolved Hide resolved

rezkiy37 reviewed Feb 20, 2024

View reviewed changes

src/pages/tasks/NewTaskDetailsPage.tsx Outdated Show resolved Hide resolved

rezkiy37 reviewed Feb 20, 2024

View reviewed changes

src/pages/tasks/NewTaskDetailsPage.tsx Outdated Show resolved Hide resolved

address comments

f16ad88

pasyukevich force-pushed the feature/migrate-NewTask branch from aaefe05 to f16ad88 Compare February 22, 2024 13:47

VickyStash approved these changes Feb 22, 2024

View reviewed changes

fabioh8010 approved these changes Feb 23, 2024

View reviewed changes

blazejkustra suggested changes Feb 27, 2024

View reviewed changes

src/ONYXKEYS.ts Outdated Show resolved Hide resolved

Merge branch 'main' into feature/migrate-NewTask

de24a0b

blazejkustra approved these changes Feb 27, 2024

View reviewed changes

c3024 reviewed Feb 28, 2024

View reviewed changes

pasyukevich added 4 commits March 6, 2024 12:11

change is not empty flag for string

dee61b1

update comment for task

2c5986a

Merge branch 'main' into feature/migrate-NewTask

8a3cd58

fix set title handler

9c17b9c

pasyukevich force-pushed the feature/migrate-NewTask branch from 4f76cd9 to 9c17b9c Compare March 6, 2024 11:56

pasyukevich marked this pull request as ready for review March 6, 2024 12:13

pasyukevich requested a review from a team as a code owner March 6, 2024 12:13

melvin-bot bot removed the request for review from a team March 6, 2024 12:13

melvin-bot bot requested a review from neil-marcellini March 6, 2024 12:13

c3024 approved these changes Mar 6, 2024

View reviewed changes

melvin-bot bot mentioned this pull request Mar 6, 2024

Payment issue for E/App PR#36886 #37828

Closed

neil-marcellini requested changes Mar 6, 2024

View reviewed changes

neil-marcellini reviewed Mar 6, 2024

View reviewed changes

src/pages/tasks/NewTaskPage.tsx Show resolved Hide resolved

pasyukevich added 3 commits March 12, 2024 12:53

Merge branch 'main' into feature/migrate-NewTask

8fcf7d5

fix prettier

2524978

remove redundant optional chaining

4e52920

neil-marcellini approved these changes Mar 12, 2024

View reviewed changes

neil-marcellini merged commit 87fb21e into Expensify:main Mar 12, 2024

github-actions bot mentioned this pull request Mar 13, 2024

Deploy Checklist: New Expensify 2024-03-13 #38257

Closed

74 tasks

luacmartins mentioned this pull request Mar 14, 2024

[CP Staging] Fix share somewhere title #38348

Merged

50 tasks

parasharrajat reviewed Mar 18, 2024

View reviewed changes

parasharrajat mentioned this pull request Mar 18, 2024

[HOLD for payment 2024-03-25] [HOLD for payment 2024-03-22] [$500] Email Replaces Workspace Room Title When Selecting Admin or Announcement in "Share Somewhere" #38294

Closed

6 tasks

Conversation

pasyukevich commented Feb 20, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

c3024 Feb 28, 2024

Choose a reason for hiding this comment

Uh oh!

pasyukevich Mar 6, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

c3024 Feb 28, 2024

Choose a reason for hiding this comment

Uh oh!

pasyukevich Mar 6, 2024

Choose a reason for hiding this comment

Uh oh!

melvin-bot bot commented Mar 6, 2024

Uh oh!

pasyukevich commented Mar 6, 2024

Uh oh!

c3024 commented Mar 6, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

c3024 left a comment

Choose a reason for hiding this comment

Uh oh!

melvin-bot bot commented Mar 6, 2024

Uh oh!

neil-marcellini left a comment

Choose a reason for hiding this comment

Uh oh!

neil-marcellini left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

pasyukevich commented Mar 12, 2024

Uh oh!

c3024 commented Mar 12, 2024

Uh oh!

neil-marcellini left a comment

Choose a reason for hiding this comment

Uh oh!

OSBotify commented Mar 12, 2024

Uh oh!

OSBotify commented Mar 13, 2024

Uh oh!

OSBotify commented Mar 15, 2024

Uh oh!

parasharrajat Mar 18, 2024

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

pasyukevich commented Feb 20, 2024 •

edited

Loading

pasyukevich Mar 6, 2024 •

edited

Loading

c3024 commented Mar 6, 2024 •

edited

Loading