Have the ability to add comments now#37
Merged
AndrewGable merged 12 commits intomasterfrom Aug 10, 2020
Merged
Conversation
AndrewGable
reviewed
Aug 10, 2020
Co-authored-by: Andrew Gable <andrewgable@gmail.com>
Contributor
Author
|
Updated |
AndrewGable
reviewed
Aug 10, 2020
| numberOfLines={3} | ||
| minHeight={60} | ||
| maxHeight={60} | ||
| onChange={this.updateComment} |
Contributor
There was a problem hiding this comment.
This isn't working on iOS, can we use onChangeText? I think we use it a couple other places.
Contributor
Author
There was a problem hiding this comment.
Yeah, the docs were identical for those, so we can try that. That's so odd why iOS would support one but not the other
Contributor
There was a problem hiding this comment.
The event fires, but e.target.value is always undefined 🤔
Contributor
Author
|
Updated |
AndrewGable
approved these changes
Aug 10, 2020
Merged
5 tasks
Deploying with
|
| Latest commit: |
5ec2e8a
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://14f09467.helpdot.pages.dev |
hayata-suenaga
pushed a commit
that referenced
this pull request
Feb 1, 2024
…odal Add dismissModalWithReport
50 tasks
7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.