-
Notifications
You must be signed in to change notification settings - Fork 3.7k
Fix - Mark the chat as "read" immediately upon switching to the tab #37021
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
hayata-suenaga
merged 8 commits into
Expensify:main
from
FitseTLT:fix-mark-as-read-switching-between-tabs
Mar 5, 2024
Merged
Changes from all commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
db75668
updated to mark as read on switching between tabs
FitseTLT e08338f
Merge branch 'main' into fix-mark-as-read-switching-between-tabs
FitseTLT d801483
removed focus event
FitseTLT 3118f03
add focus check
FitseTLT 34cbadf
fix performance test
FitseTLT 3e76052
Merge branch 'main' into fix-mark-as-read-switching-between-tabs
FitseTLT e5b14a6
Merge branch 'main' into fix-mark-as-read-switching-between-tabs
FitseTLT f12d925
fix mock
FitseTLT File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Coming from #72774,
ReadNewestActioncan be called 2 times so we should combine this hook with the one above to avoid API call duplication