[TS migration] Migrate 'AddPlaidBankAccount.js' component to TypeScript by pac-guerreiro · Pull Request #37034 · Expensify/App

pac-guerreiro · 2024-02-21T16:43:53Z

Details

Fixed Issues

$#25119
PROPOSAL: N/A

Tests

Go to Settings > Wallet
Click on Add bank account on the Bank accounts section
Select Personal bank account option
You should be redirected to a new page with a loading spinner, then a white page will fill the screen asking you to authorize Plaid to connect to your bank account

Offline tests

Same as tests.

QA Steps

Same as tests.

PR Author Checklist

Screenshots/Videos

Android: Native

Android.mp4

Android: mWeb Chrome

Android.-.Chrome.mp4

iOS: Native

iOS.mp4

iOS: mWeb Safari

iOS.-.Safari.mp4

MacOS: Chrome / Safari

Web.mp4

MacOS: Desktop

Desktop.mp4

src/components/AddPlaidBankAccount.tsx

koko57 · 2024-02-22T08:58:13Z

@pac-guerreiro FYI:

App/src/pages/ReimbursementAccount/BankInfo/substeps/Plaid.tsx

Line 91 in d33bf6e

    
           // @ts-expect-error TODO: Remove this once AddPlaidBankAccount (https://github.com/Expensify/App/issues/25119) is migrated to TypeScript

I think you can remove it 🙂

…ccount-to-typescript

blazejkustra

Solid work! LGTM with one minor comment

blazejkustra · 2024-03-04T16:43:48Z

src/components/Form/types.ts

    | typeof ValuePicker
-    | typeof RadioButtons;
+    | typeof RadioButtons
+    | typeof AddPlaidBankAccount;


Let's adjust the comment above and remove this:

* TODO: Add remaining inputs here once these components are migrated to Typescript: * EmojiPickerButtonDropdown

@blazejkustra that component is not merged yet

Lol, I thought comment referenced AddPlaidBankAccount, sorry!

fabioh8010 · 2024-03-07T09:23:18Z

FYI @pac-guerreiro is OOO this week and will return on March 11th.

…ccount-to-typescript # Conflicts: # src/components/Form/types.ts

melvin-bot · 2024-03-12T05:01:10Z

Hey! I see that you made changes to our Form component. Make sure to update the docs in FORMS.md accordingly. Cheers!

src/components/AddPlaidBankAccount.tsx

Co-authored-by: Viktoryia Kliushun <vikstash@gmail.com>

melvin-bot · 2024-03-12T10:39:43Z

@Gonals Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

Gonals · 2024-03-12T12:29:37Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

OSBotify · 2024-03-13T16:26:30Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2024-03-13T19:59:12Z

🚀 Deployed to staging by https://github.com/Gonals in version: 1.4.52-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2024-03-15T10:15:33Z

🚀 Deployed to production by https://github.com/Beamanator in version: 1.4.52-6 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

refactor(typescript): migrate addplaidbankaccount

9e641bd

VickyStash reviewed Feb 22, 2024

View reviewed changes

fabioh8010 reviewed Feb 22, 2024

View reviewed changes

src/components/AddPlaidBankAccount.tsx Show resolved Hide resolved

src/components/AddPlaidBankAccount.tsx Show resolved Hide resolved

pac-guerreiro added 5 commits February 22, 2024 12:28

Merge branch 'main' into pac-guerreiro/refactor/migrate-addplaidbanka…

c9096dd

…ccount-to-typescript

Merge branch 'main' into pac-guerreiro/refactor/migrate-addplaidbanka…

24834fb

…ccount-to-typescript

refactor(typescript): remove expect error and unused props

cbd59bf

refactor(typescript): receivedRedirectURI prop type

4d4e6d7

refactor(typescript): apply pull request suggestions

c07a624

fabioh8010 approved these changes Feb 28, 2024

View reviewed changes

chore: fix linter issues

2bdb2fa

fabioh8010 approved these changes Mar 1, 2024

View reviewed changes

blazejkustra approved these changes Mar 4, 2024

View reviewed changes

Merge branch 'main' into pac-guerreiro/refactor/migrate-addplaidbanka…

73ce1c3

…ccount-to-typescript # Conflicts: # src/components/Form/types.ts

fix: wrong conversion of condition into typescript

ba011b9

VickyStash approved these changes Mar 12, 2024

View reviewed changes

src/components/AddPlaidBankAccount.tsx Outdated Show resolved Hide resolved

refactor(typescript): apply pull request suggestion

a3addf2

Co-authored-by: Viktoryia Kliushun <vikstash@gmail.com>

pac-guerreiro marked this pull request as ready for review March 12, 2024 10:39

pac-guerreiro requested a review from a team as a code owner March 12, 2024 10:39

melvin-bot bot requested review from Gonals and removed request for a team March 12, 2024 10:39

Gonals approved these changes Mar 12, 2024

View reviewed changes

Gonals merged commit 86200bb into Expensify:main Mar 13, 2024

This was referenced Mar 13, 2024

Investigate workflow job failing on main: test / test (job 1) #38238

Closed

Investigate workflow job failing on main: confirmPassingBuild #38239

Closed

github-actions bot mentioned this pull request Mar 13, 2024

Deploy Checklist: New Expensify 2024-03-13 #38257

Closed

74 tasks

Conversation

pac-guerreiro commented Feb 21, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

koko57 commented Feb 22, 2024

Uh oh!

blazejkustra left a comment

Choose a reason for hiding this comment

Uh oh!

blazejkustra Mar 4, 2024

Choose a reason for hiding this comment

Uh oh!

pac-guerreiro Mar 11, 2024

Choose a reason for hiding this comment

Uh oh!

blazejkustra Mar 11, 2024

Choose a reason for hiding this comment

Uh oh!

fabioh8010 commented Mar 7, 2024

Uh oh!

melvin-bot bot commented Mar 12, 2024

Uh oh!

Uh oh!

melvin-bot bot commented Mar 12, 2024

Uh oh!

Gonals commented Mar 12, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

OSBotify commented Mar 13, 2024

Uh oh!

OSBotify commented Mar 13, 2024

Uh oh!

OSBotify commented Mar 15, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

pac-guerreiro commented Feb 21, 2024 •

edited

Loading

Gonals commented Mar 12, 2024 •

edited

Loading