Feature/35712 redesign of members list by burczu · Pull Request #37074 · Expensify/App

burczu · 2024-02-22T10:16:43Z

Details

In this PR the list of members displayed on the Workspace Members Page is re-designed to match the new design.

The new design for reference:

Fixed Issues

$ #35712
PROPOSAL: https://docs.google.com/document/d/1gk3xqOs7epMbUrSSiX8K7YcqfPLVgqEos0sf-D-GMDA/edit#heading=h.qjcht79r25s1

Tests

LogIn to the App
Open any Workspace
Open Members page
Check if the members list looks the same as on the design.

Verify that no errors appear in the JS console

Offline tests

Same as above.

QA Steps

Same as above.

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

src/components/SelectionList/TableListItem.tsx

melvin-bot · 2024-02-22T11:48:08Z

@getusha Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

ArekChr · 2024-02-22T11:57:18Z

cc: @Expensify/design

getusha · 2024-02-22T12:33:50Z

@shawnborton i wonder if we should also use the new Badge design here?

shawnborton · 2024-02-22T12:49:05Z

Looking pretty good!

Totally agree that we should use the new badge component. Has that been merged into main yet?

For this area here:

I would think that the "Role" heading would be right-aligned since it's the last column. It also feels like each row has too much padding-right - I would expect the badge to be further over to the right. How much right-padding is currently being applied?

burczu · 2024-02-22T12:53:27Z

Looking pretty good!

Totally agree that we should use the new badge component. Has that been merged into main yet?

For this area here:

I would think that the "Role" heading would be right-aligned since it's the last column. It also feels like each row has too much padding-right - I would expect the badge to be further over to the right. How much right-padding is currently being applied?

@shawnborton What is the new badge and where can I find it? Regarding alignment - I recall a long discussion (first in the Proposal document, and later in Slack) and I thought there was a conclusion that the last column should be aligned left and it was finally reflected in Figma.

shawnborton · 2024-02-22T12:54:32Z

Ah okay, you can ignore me then. cc @trjExpensify @JmillsExpensify @Expensify/design for confirmation.

Can you show me how much right padding is being used though?

shawnborton · 2024-02-22T12:54:46Z

If you pull main, perhaps the new badge component should be there already.

getusha · 2024-02-22T12:58:16Z

src/pages/workspace/WorkspaceMembersPage.js

-                        <Text style={styles.peopleBadgeText}>{props.translate('common.admin')}</Text>
-                    </View>
-                ) : null,
+                rightElement: roleBadge,


App/src/components/MenuItem.tsx

Lines 574 to 583 in 29ad878

<Badge

text={badgeText}

textStyles={styles.textStrong}

badgeStyles={[

styles.alignSelfCenter,

styles.badgeBordered,

brickRoadIndicator ? styles.mr2 : undefined,

focused || isHovered || pressed ? styles.activeItemBadge : {},

badgeStyle,

]}

burczu · 2024-02-22T13:15:53Z

Ah okay, you can ignore me then. cc @trjExpensify @JmillsExpensify @Expensify/design for confirmation.

Can you show me how much right padding is being used though?

@shawnborton the last "column" (which is not an actual column because in fact it is not a table) has a fixed width of 60px and right-margin of 16px; the wrapper has padding of 16px so putting this together the badge is 32px far from the right edge of the item container (in Figma it is 29px from the right edge, so I guess it's quite random, but I could change the right margin of the badge to 12px so it would be 30px from the edge then)

regarding badge styles - is one of the below designs what we are looking for?:

shawnborton · 2024-02-22T13:19:48Z

That is quite random, and I think it's a mistake because there was a hidden caret layer that never got removed. I would just remove the 16px margin from the badge so that there is a clean 16px padding between the badge and the edge of the row.

And yes, this is the style we're after:

burczu · 2024-02-22T13:25:26Z

@shawnborton Alright, fixed the badge - thanks. It looks like below now:

getusha · 2024-02-22T14:27:30Z

@getusha Thanks for pointing this out - I didn't touch the removal functionality yet. I'll be working on it in the next issue so I think I'll address this there (it's not a breaking issue I guess). What do you think?

Yes, it is minor, can be handled later.

shawnborton · 2024-02-22T14:30:15Z

@dannymcclain I think I am team 16px right now, will tag ya in Figma where I'm using that currently.

dannymcclain · 2024-02-22T14:33:30Z

:gavel: :gavel: :gavel: 16px sounds good to me! :send-it:

luacmartins · 2024-02-22T15:45:50Z

Thanks for the reviews so far! @burczu would you mind addressing the latest comments and fixing the conflict so we can get this merged today?

burczu · 2024-02-22T16:28:56Z

@getusha your comments addressed + storybook updated
@shawnborton 16px vertical padding applied
@dannymcclain the Role column label center aligned as requested
@luacmartins conflicts solved and all the comments and requests addressed, I believe

getusha · 2024-02-22T16:41:45Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

luacmartins

There are a couple of small issues, but I think we can address those in a follow up since this PR unblocks Categories main page and the whole dependency chain of issues there.

luacmartins · 2024-02-22T17:01:16Z

src/languages/es.ts

        iAcceptThe: 'Acepto los ',
        remove: 'Eliminar',
        admin: 'Administrador',
+        owner: 'Poseedor',


NAB I think this should be Dueño

luacmartins · 2024-02-22T17:09:17Z

src/pages/workspace/WorkspaceMembersPage.tsx

-    };
+    const getHeaderContent = () => (
+        <>
+            <Text style={[styles.pl5, styles.mb5, styles.mt3]}>{translate('workspace.people.membersListTitle')}</Text>


NAB I think this text should use textSupporting color

getusha

Looks good to me!

OSBotify · 2024-02-22T18:30:10Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2024-02-26T21:11:17Z

🚀 Deployed to staging by https://github.com/luacmartins in version: 1.4.44-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2024-02-28T23:59:53Z

🚀 Deployed to production by https://github.com/puneetlath in version: 1.4.44-13 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

hoangzinh · 2024-03-15T09:29:43Z

src/components/SelectionList/TableListItem.tsx

+            pressableStyle={[[styles.selectionListPressableItemWrapper, isFocused && styles.activeComponentBG]]}
+            wrapperStyle={[styles.flexRow, styles.flex1, styles.justifyContentBetween, styles.userSelectNone, styles.alignItemsCenter, isFocused && styles.sidebarLinkActive]}


Hi team, come from this issue #37293:

For a focused background in this case, we should use styles.sidebarLinkActive

We don't need to add isFocused style in wrapperStyle otherwise it causes the above bug.

rlinoz · 2024-04-15T11:57:04Z

src/pages/workspace/WorkspaceMembersPage.tsx


+            let roleBadge = null;
+            if (isOwner || isAdmin) {
+                roleBadge = (


The badge wasn't being styled properly when removing admin while offline in the native apps: #37776

burczu added 5 commits February 22, 2024 10:10

table list item component introduced

d24b4f5

workspace members page: search removed and new list item used

1f638ed

members list items styling added

316863b

custom list header handled

9a28821

badge positioning fixed

61f20d1

ArekChr reviewed Feb 22, 2024

View reviewed changes

src/components/SelectionList/TableListItem.tsx Outdated Show resolved Hide resolved

burczu added 5 commits February 22, 2024 11:41

component name fixed

2f81b23

simplified statement

2ff80c9

badge styles adjusted

32ee7cd

lint fixed

35d430b

prettier, one more time...

330927f

burczu marked this pull request as ready for review February 22, 2024 11:48

burczu requested a review from a team as a code owner February 22, 2024 11:48

melvin-bot bot requested review from getusha and removed request for a team February 22, 2024 11:48

burczu mentioned this pull request Feb 22, 2024

[HOLD for payment 2024-03-06][$500] [Simplified Collect][Members] WorkspaceMembersPage: Members list redesign #35712

Closed

getusha reviewed Feb 22, 2024

View reviewed changes

switched to use badge component

7f43da6

burczu added 2 commits February 22, 2024 14:20

Merge branch 'main' into feature/35712-redesign-of-members-list

5a4a6b1

badge styles adjusted

957cce7

burczu added 4 commits February 22, 2024 17:12

unnecessary styles removed

ddf1f64

role column text center alligned

b5c721a

Merge branch 'main' into feature/35712-redesign-of-members-list

bce9160

unnecessary underscore reference removed

5833bea

fix after main sync

118ca71

luacmartins requested review from getusha and luacmartins February 22, 2024 16:47

luacmartins approved these changes Feb 22, 2024

View reviewed changes

getusha approved these changes Feb 22, 2024

View reviewed changes

melvin-bot bot requested a review from luacmartins February 22, 2024 18:18

luacmartins approved these changes Feb 22, 2024

View reviewed changes

luacmartins merged commit 510d118 into Expensify:main Feb 22, 2024

This was referenced Feb 22, 2024

[Awaiting Payment 7th March] [Simplified Collect] [Members] Update member page translation and subtitle color #37096

Closed

Feat/categories main page #36324

Merged

luacmartins mentioned this pull request Feb 22, 2024

[HOLD #37199][$500] Remove members out of a workspace are not crossed out in offline mode #37109

Closed

6 tasks

github-actions bot mentioned this pull request Feb 26, 2024

Deploy Checklist: New Expensify 2024-02-26 #37224

Closed

lanitochka17 mentioned this pull request Feb 27, 2024

[HOLD for payment 2024-04-03] [$500] Workspace - Member and Role can be clicked to select all the members in Members list #37295

Closed

6 tasks

hoangzinh mentioned this pull request Feb 27, 2024

[HOLD for payment 2024-03-11] [$500] Workspace - The selection is smaller than member name row when navigating via keyboard #37293

Closed

6 tasks

hoangzinh reviewed Mar 15, 2024

View reviewed changes

rlinoz reviewed Apr 15, 2024

View reviewed changes

inimaga mentioned this pull request May 8, 2025

[Due for payment 2025-05-22] [Due for payment 2025-05-20] [$250] iOS - Workspace - After returning from role selection page, Role field is highlighted #61669

Closed

8 tasks

	<Badge
	text={badgeText}
	textStyles={styles.textStrong}
	badgeStyles={[
	styles.alignSelfCenter,
	styles.badgeBordered,
	brickRoadIndicator ? styles.mr2 : undefined,
	focused \|\| isHovered \|\| pressed ? styles.activeItemBadge : {},
	badgeStyle,
	]}

		pressableStyle={[[styles.selectionListPressableItemWrapper, isFocused && styles.activeComponentBG]]}
		wrapperStyle={[styles.flexRow, styles.flex1, styles.justifyContentBetween, styles.userSelectNone, styles.alignItemsCenter, isFocused && styles.sidebarLinkActive]}

Conversation

burczu commented Feb 22, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

Uh oh!

melvin-bot bot commented Feb 22, 2024

Uh oh!

ArekChr commented Feb 22, 2024

Uh oh!

getusha commented Feb 22, 2024

Uh oh!

shawnborton commented Feb 22, 2024

Uh oh!

burczu commented Feb 22, 2024

Uh oh!

shawnborton commented Feb 22, 2024

Uh oh!

shawnborton commented Feb 22, 2024

Uh oh!

getusha Feb 22, 2024

Choose a reason for hiding this comment

Uh oh!

burczu commented Feb 22, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

shawnborton commented Feb 22, 2024

Uh oh!

burczu commented Feb 22, 2024

Uh oh!

getusha commented Feb 22, 2024

Uh oh!

shawnborton commented Feb 22, 2024

Uh oh!

dannymcclain commented Feb 22, 2024

Uh oh!

luacmartins commented Feb 22, 2024

Uh oh!

burczu commented Feb 22, 2024

Uh oh!

getusha commented Feb 22, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

luacmartins left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

luacmartins Feb 22, 2024

Choose a reason for hiding this comment

Uh oh!

luacmartins Feb 22, 2024

Choose a reason for hiding this comment

Uh oh!

getusha left a comment

Choose a reason for hiding this comment

Uh oh!

OSBotify commented Feb 22, 2024

Uh oh!

OSBotify commented Feb 26, 2024

Uh oh!

OSBotify commented Feb 28, 2024

Uh oh!

hoangzinh Mar 15, 2024

Choose a reason for hiding this comment

Uh oh!

rlinoz Apr 15, 2024

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

burczu commented Feb 22, 2024 •

edited

Loading

burczu commented Feb 22, 2024 •

edited

Loading

getusha commented Feb 22, 2024 •

edited

Loading

luacmartins left a comment •

edited

Loading