Feature/35713 bulk actions by burczu · Pull Request #37199 · Expensify/App

burczu · 2024-02-26T10:05:29Z

Details

This PR changes the way how we handle the removal flow of the workspace members. It also adds the ability to make multiple users admins of the workspace or make them regular members back.

Design used in the PR below:

Fixed Issues

$ #35713
PROPOSAL: https://docs.google.com/document/d/1gk3xqOs7epMbUrSSiX8K7YcqfPLVgqEos0sf-D-GMDA/edit#heading=h.mkdaimqk6cz

Tests

Log in to the App
Open any Workspace (or create new one)
Head into the Members page
Add few members if necessary
Test removal flow:
a. Select one or more members ->
b. Expand the dropdown menu on the "X selected" button
c. Press "Remove members"
d. Check the process (if the confirmation modal appears with correct copy, if the removal works)
Test making admins
a. Select one or more members that are not admins yet
b. Expand the dropdown menu on the "X selected" button
c. Press "Make admin"
d. Check if selected members became admins
Test making members
a. Select one or more members that are admins currently
b. Expand the dropdown menu on the "X selected" button
c. Press "Make member"
d. Check if selected admins became members

Verify that no errors appear in the JS console

Offline tests

Same as above.

QA Steps

Same as above.

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Screen.Recording.2024-02-27.at.12.00.04.mov

Android: mWeb Chrome

Screen.Recording.2024-02-27.at.11.53.12.mov

iOS: Native

Screen.Recording.2024-02-27.at.11.48.26.mov

iOS: mWeb Safari

Screen.Recording.2024-02-27.at.11.50.18.mov

MacOS: Chrome / Safari

Screen.Recording.2024-02-27.at.11.38.54.mov

MacOS: Desktop

Screen.Recording.2024-02-27.at.11.41.28.mov

…ers page

luacmartins

Left an early review

src/components/ButtonWithDropdownMenu/index.tsx

src/pages/workspace/WorkspaceMembersPage.tsx

src/CONST.ts

src/pages/workspace/WorkspaceMembersPage.tsx

Co-authored-by: Carlos Martins <luacmartins@gmail.com>

burczu · 2024-03-01T14:43:55Z

@aimane-chnaif applied your suggestion - I think it indeed may help, can you confirm?

aimane-chnaif · 2024-03-01T15:05:20Z

Not a blocker but data isn't updated immediately on another device

Screen.Recording.2024-03-01.at.4.02.58.PM.mov

luacmartins · 2024-03-01T15:07:18Z

Not a blocker but data isn't updated immediately on another device

This is know and we're working on the backend solution for all of these cross device syncs

aimane-chnaif · 2024-03-01T15:10:53Z

There's conflict

aimane-chnaif · 2024-03-01T15:12:06Z

Can we create separate GH for this?
Not found message should not show while loading members

Screen.Recording.2024-03-01.at.4.11.19.PM.mov

luacmartins · 2024-03-01T15:15:08Z

I asked @ArekChr to resolve the conflict since Bartek has left for the day

aimane-chnaif · 2024-03-01T15:15:49Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

android.mov

Android: mWeb Chrome

iOS: Native

ios.mov

iOS: mWeb Safari

msafari.mov

MacOS: Chrome / Safari

web.mov

web2.mov

MacOS: Desktop

desktop.mov

luacmartins · 2024-03-01T15:23:24Z

created issue for the reported bug here

OSBotify · 2024-03-01T16:15:43Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2024-03-04T21:04:02Z

🚀 Deployed to staging by https://github.com/luacmartins in version: 1.4.47-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	failure ❌
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2024-03-06T21:53:04Z

🚀 Deployed to production by https://github.com/roryabraham in version: 1.4.47-10 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

rushatgabhane

we caused a small issue in radio button items #53467 (comment)

ahmedGaber93 · 2025-07-01T05:54:36Z

src/hooks/useHover.ts

+        hovered,
+        bind: {
+            onMouseEnter: () => setHovered(true),
+            onMouseLeave: () => setHovered(false),


Coming from #63685, we faced an issue on mWeb related to onMouseLeave support, so we limited this hook to non touch screen.

burczu added 11 commits February 23, 2024 13:23

button with dropdown menu refactor

bc020b1

button with dropdown refactor simplified

f8bcd09

showing button with dropdown menu when item selected

6b01648

Merge branch 'main' into feature/35713-bulk-actions

aab0b73

text and style of the dropdown button adjusted for the workspace memb…

8d96108

…ers page

custom onSelect action handling by ButtonWithDropdown added

a1c7b3c

Merge branch 'main' into feature/35713-bulk-actions

a811d75

remove members bulk action handled

7480bc0

offline deletion issue (not striking out member) fixed

ce0a424

handling style prop injected by the OfflineWithFeedback component

7afd58c

line through on native issue fixed

9a6be7a

burczu force-pushed the feature/35713-bulk-actions branch from 1087c8d to 9a6be7a Compare February 26, 2024 12:54

luacmartins self-requested a review February 26, 2024 17:43

luacmartins requested changes Feb 26, 2024

View reviewed changes

burczu and others added 5 commits February 27, 2024 08:19

always show drop down menu prop renamed

65de55f

Co-authored-by: Carlos Martins <luacmartins@gmail.com>

switched to use variables for icon sizing

9afe006

Co-authored-by: Carlos Martins <luacmartins@gmail.com>

building bulk actions options conditional fixed

bdddc57

Co-authored-by: Carlos Martins <luacmartins@gmail.com>

missing import added

9bab577

using dedicated method for all the bulk actions added

8440181

burczu requested a review from luacmartins February 27, 2024 07:27

burczu added 9 commits February 27, 2024 08:34

lint and prettier changes

a4c37a2

on selected definition fixed

335aa49

updating workspace member's role added

6440417

Merge branch 'main' into feature/35713-bulk-actions

4ab2e7a

type definition fixed

632b3a5

prettier fix

0a560d5

missing API types added

55ded25

unnecessary comment removed

631e8c1

renamings

70988c3

burczu mentioned this pull request Feb 27, 2024

[HOLD #37199][$500] Remove members out of a workspace are not crossed out in offline mode #37109

Closed

6 tasks

luacmartins approved these changes Mar 1, 2024

View reviewed changes

aimane-chnaif approved these changes Mar 1, 2024

View reviewed changes

melvin-bot bot requested a review from luacmartins March 1, 2024 15:16

luacmartins previously approved these changes Mar 1, 2024

View reviewed changes

luacmartins mentioned this pull request Mar 1, 2024

[$500] [HOLD for payment 2024-03-19] Do not show "member not found" when loading member list #37605

Closed

resolve conflicts

c151114

luacmartins dismissed their stale review via c151114 March 1, 2024 15:49

luacmartins approved these changes Mar 1, 2024

View reviewed changes

luacmartins merged commit 7afbf43 into Expensify:main Mar 1, 2024

github-actions bot mentioned this pull request Mar 4, 2024

Deploy Checklist: New Expensify 2024-03-04 #37698

Closed

97 tasks

dukenv0307 mentioned this pull request Mar 5, 2024

[HOLD for payment 2024-03-14] [HOLD for payment 2024-03-13] Split scan - Split button in split menu is gray instead of green #37711

Closed

6 tasks

aimane-chnaif mentioned this pull request Mar 5, 2024

Members - 'Make admin' option is not displayed before refreshing the page #37748

Closed

6 tasks

kbecciv mentioned this pull request Mar 5, 2024

[HOLD for payment 2024-03-14] [HOLD for payment 2024-03-13] Workspace - "Free" user is able to see "Admin Role" when WS is made as "Default" #37779

Closed

6 tasks

burczu mentioned this pull request Mar 6, 2024

#35715 workspace member details page #37715

Merged

50 tasks

luacmartins mentioned this pull request Mar 6, 2024

[HOLD for payment 2024-03-18] [$500] [Simplified Collect][Members] - admin badge is not grayed out when making user admin in offline mode #37757

Closed

6 tasks

jayeshmangwani mentioned this pull request Apr 8, 2024

[Awaiting Payment 29th April] [$250] Web - Category - No hover effect for an already selected category #39716

Closed

6 tasks

rushatgabhane reviewed Jan 9, 2025

View reviewed changes

rushatgabhane mentioned this pull request Jan 9, 2025

[HOLD for payment 2025-01-02] [$250] Tags - In expense report, full tag name is not shown in tag list page #53467

Closed

8 tasks

ahmedGaber93 reviewed Jul 1, 2025

View reviewed changes

Conversation

burczu commented Feb 26, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

luacmartins left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

burczu commented Mar 1, 2024

Uh oh!

aimane-chnaif commented Mar 1, 2024

Uh oh!

luacmartins commented Mar 1, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

aimane-chnaif commented Mar 1, 2024

Uh oh!

aimane-chnaif commented Mar 1, 2024

Uh oh!

luacmartins commented Mar 1, 2024

Uh oh!

aimane-chnaif commented Mar 1, 2024

Reviewer Checklist

Screenshots/Videos

Uh oh!

luacmartins commented Mar 1, 2024

Uh oh!

OSBotify commented Mar 1, 2024

Uh oh!

OSBotify commented Mar 4, 2024

Uh oh!

OSBotify commented Mar 6, 2024

Uh oh!

rushatgabhane left a comment

Choose a reason for hiding this comment

Uh oh!

ahmedGaber93 Jul 1, 2025

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

9 participants

burczu commented Feb 26, 2024 •

edited

Loading

luacmartins commented Mar 1, 2024 •

edited

Loading